From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by dpdk.org (Postfix) with ESMTP id A2B636CD7 for ; Mon, 4 Jun 2018 14:10:08 +0200 (CEST) Received: by mail-lf0-f65.google.com with SMTP id n15-v6so7520082lfn.10 for ; Mon, 04 Jun 2018 05:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=50EDqNAHYTeGQ7yFDRX+BN9QjxA5IHd479aJ8eNzjRw=; b=Dg0nnD66SKlufIegZB44VUKAKaunWahbewuqTbSrtJ+/5ZiAe9+2AB2seyviCpraWl SvTHtlRUyGweneogcT8pqSThN/j8EM2ONPsUJeG6N3dIxw1kA17cLxfankcMhlUj9LAy L2zGJsckH2J4TT8eaTf6Hk/htMN4hIVbqb2IQiqBPmoa+5YQdgqkbT2hE+hCzCXgqIqI NxDR3iinI4xP68vByWO/m7efuRRc0nrh8y05CiVGmKsmaB0mBmy8YPGUC4gEwsgM4BQg qdKupm0ZVTNjnmOelazaQHtgtGAzspG6CvCB6a+4lF5wINEJI5vkaVxuW6rDfdbHuEcF q5Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=50EDqNAHYTeGQ7yFDRX+BN9QjxA5IHd479aJ8eNzjRw=; b=kRkO+elVs7JlagFpUy/GXv4mL6as38aK/Mox+QV6kI7+TiXLASYwst2/+B7fkDKRfp tj9krEEGr1loRrJf4wb9KCMVdRW3fngXojmCrdtz09HPLEM3C0C4zx22BSRKYi/J6rVq TLJrIDcQ4FEWbGmDcvpw5fhrqq43LsZIadA/cuvGTdrdgzLdhhleDqFsMf9MmQUQ0P9k Zjdlf2x7dK/A8p4Ob9agY4v/OxF0kQlLRo1go8VhVccN7L64rmqQoDOAHVuMxmEiIsw9 oE7L65e4FKvsxcH/3GfbhJrgJmcatnyAQDgh97PTfgYFwO7DqF3OC6vifVS7huZ6KcoF u9Ow== X-Gm-Message-State: APt69E3PDj8ojPI8AJdZ85XWqcc5w4ImekCz6tLvHbLzicXeIpRNkLlr 4xb8F7xuD8LEf0nxebtnUoeabw== X-Google-Smtp-Source: ADUXVKLJkWAExN4IsxZwj11cseJDj1w91H+MW0geW9s3H6BgPRqLpslVyYwi1binwCxFxw5fQTOujA== X-Received: by 2002:a19:d898:: with SMTP id r24-v6mr8822971lfi.7.1528114208225; Mon, 04 Jun 2018 05:10:08 -0700 (PDT) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id g23-v6sm3817415lfi.49.2018.06.04.05.10.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 05:10:07 -0700 (PDT) From: Michal Krawczyk To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik Date: Mon, 4 Jun 2018 14:09:44 +0200 Message-Id: <20180604120955.17319-7-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180604120955.17319-1-mk@semihalf.com> References: <20180604120955.17319-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH v2 16/26] net/ena: unimplemented handler error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 12:10:09 -0000 From: Rafal Kozik Enable AENQ FATAL_ERROR and WARNING callbacks by setting flags in aenq_groups. They are handled by "unimplemented handler". If unimplemented handler is called, error is logged. Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 3e3ae69bb..2d9b104d6 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1415,7 +1415,9 @@ static int ena_device_init(struct ena_com_dev *ena_dev, aenq_groups = BIT(ENA_ADMIN_LINK_CHANGE) | BIT(ENA_ADMIN_NOTIFICATION) | - BIT(ENA_ADMIN_KEEP_ALIVE); + BIT(ENA_ADMIN_KEEP_ALIVE) | + BIT(ENA_ADMIN_FATAL_ERROR) | + BIT(ENA_ADMIN_WARNING); aenq_groups &= get_feat_ctx->aenq.supported_groups; rc = ena_com_set_aenq_config(ena_dev, aenq_groups); @@ -2196,7 +2198,8 @@ static void ena_keep_alive(void *adapter_data, static void unimplemented_aenq_handler(__rte_unused void *data, __rte_unused struct ena_admin_aenq_entry *aenq_e) { - // Unimplemented handler + RTE_LOG(ERR, PMD, "Unknown event was received or event with " + "unimplemented handler\n"); } static struct ena_aenq_handlers aenq_handlers = { -- 2.14.1