From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A2BAC1B016 for <dev@dpdk.org>; Thu, 7 Jun 2018 06:58:14 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 21:58:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="55397798" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.203]) by FMSMGA003.fm.intel.com with ESMTP; 06 Jun 2018 21:58:12 -0700 Date: Thu, 7 Jun 2018 12:58:25 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180607045825.GB32696@debian> References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-5-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180606123128.7868-5-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/virtio: don't use simple Rx if TCP LRO or VLAN strip requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 07 Jun 2018 04:58:16 -0000 On Wed, Jun 06, 2018 at 02:31:27PM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com> > --- > drivers/net/virtio/virtio_ethdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index b023ec02e..357968fdd 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1963,7 +1963,9 @@ virtio_dev_configure(struct rte_eth_dev *dev) > } > > if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | > - DEV_RX_OFFLOAD_TCP_CKSUM)) > + DEV_RX_OFFLOAD_TCP_CKSUM | > + DEV_RX_OFFLOAD_TCP_LRO | > + DEV_RX_OFFLOAD_VLAN_STRIP)) > hw->use_simple_rx = 0; > > if (tx_offloads & (DEV_TX_OFFLOAD_TCP_CKSUM | > -- > 2.14.3 >