From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
by dpdk.org (Postfix) with ESMTP id 927A41B01F
for <dev@dpdk.org>; Thu, 7 Jun 2018 11:26:35 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
[10.11.54.6])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 2FFCE8AA08;
Thu, 7 Jun 2018 09:26:35 +0000 (UTC)
Received: from localhost.localdomain (ovpn-112-46.ams2.redhat.com
[10.36.112.46])
by smtp.corp.redhat.com (Postfix) with ESMTP id 0737420357CA;
Thu, 7 Jun 2018 09:26:33 +0000 (UTC)
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: zhihong.wang@intel.com,
tiwei.bie@intel.com,
dev@dpdk.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Date: Thu, 7 Jun 2018 11:26:13 +0200
Message-Id: <20180607092616.27720-3-maxime.coquelin@redhat.com>
In-Reply-To: <20180607092616.27720-1-maxime.coquelin@redhat.com>
References: <20180607092616.27720-1-maxime.coquelin@redhat.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.11.55.2]); Thu, 07 Jun 2018 09:26:35 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]);
Thu, 07 Jun 2018 09:26:35 +0000 (UTC) for IP:'10.11.54.6'
DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''
Subject: [dpdk-dev] [PATCH v3 2/5] net/virtio: use simple path for Tx even
if Rx mergeable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2018 09:26:36 -0000
Having Rx mergeable buffers feature enabled should not be
a reason to not use Tx simple path.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/net/virtio/virtio_ethdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 052dd056a..c6087d9b1 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1948,10 +1948,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)
hw->use_simple_tx = 0;
}
#endif
- if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
+ if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF))
hw->use_simple_rx = 0;
- hw->use_simple_tx = 0;
- }
if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
DEV_RX_OFFLOAD_TCP_CKSUM))
--
2.14.3