From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f54.google.com (mail-pl0-f54.google.com [209.85.160.54]) by dpdk.org (Postfix) with ESMTP id 635148D97 for ; Fri, 8 Jun 2018 02:07:48 +0200 (CEST) Received: by mail-pl0-f54.google.com with SMTP id z9-v6so7135500plk.11 for ; Thu, 07 Jun 2018 17:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9iKFfleJE2FZ0WurX2nfLsCJRVyvDjrsw2rAUf8Bw+g=; b=ncgp/WOj1KzVasPLns5RskPrFRn7ZvRxuB5aQxWw4Wu86TCWjlebPUaz93l/OQJAqH jXpG3phMUVWmQNDpPLFj7b2QLQwGzo1cqz0Gdytv6uTIFIEQjuwmXaSpHIz+MwWw7rcm GQf/joIf7V4cqnHQgJpJzG05YtCTNKx1B9f/fdtnkmgkB+h5cj46bU6WN1T54YHUcu1y 0xoi0Zmvy5q1trroT9+gOl/pnDZKavM4bcmyDgpcDNd5gzGGJ35SCPMnF45E2V5v269S 5zcRE/exGHgFkV7Cg6e8ndISGHgop3HP+fh8DmRBBUUI5v0VC5HcWJvr2EbZBg+McCUW yj3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9iKFfleJE2FZ0WurX2nfLsCJRVyvDjrsw2rAUf8Bw+g=; b=ISDQ4jZOJ5EVYWF2jC75KcylFGhA6n3dukxkaNEeGzWL8sXBPFI1pHaJsHupxd0sEu bL4jRJllV4FDikH64YdXU8BOrilPSYzwN+DYf70bjm8snwsvq7gyQO+25zh4A6PCjzs0 CClLg9RLYtWqXtTkCJOAGVjiZ20+rJ7b7yC8s8MqZYhJEUCAWyrpyQHkgxn95zN1l1Xr KSDQWjOmPkucODOC0x8oc4QobkeZxEP7F/Hs5xhjX0W6d4eRngFMIJsIxvrqPnwjMoK7 iEJ6vBMfPTPAiCgh3NCEPY/P79O2qPkITWyf8Lk+uAi1HL88zT2JAD/UuWJ2DN9HsQ+6 rpLA== X-Gm-Message-State: APt69E3iyT5gf4zus/Q4/mhL8i49Q0Zs5ker9QD+E+ZlmtgoQZnw7jzR mh+iT4ofJeWHKiQL6Ib/S7yWnA== X-Google-Smtp-Source: ADUXVKLmObLssXk+4xJ3KSgaA0KeINDU9+8knDC4M1LGKvzJs9T2Ed4jWJ+7vb/nvLsklCRSsr4BpQ== X-Received: by 2002:a17:902:b60b:: with SMTP id b11-v6mr4150882pls.330.1528416467510; Thu, 07 Jun 2018 17:07:47 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id q82-v6sm65201200pfg.170.2018.06.07.17.07.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Jun 2018 17:07:47 -0700 (PDT) Date: Thu, 7 Jun 2018 17:07:45 -0700 From: Stephen Hemminger To: "Iremonger, Bernard" Cc: "dev@dpdk.org" Message-ID: <20180607170745.0eac95bd@xeon-e3> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CAF443@IRSMSX108.ger.corp.intel.com> References: <20180321034436.4089-1-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260CAF443@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 00:07:48 -0000 On Thu, 7 Jun 2018 12:52:59 +0000 "Iremonger, Bernard" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Wednesday, March 21, 2018 3:45 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses > > > > Change the transmit only side of testpmd to use the IP addresses that are > > marked as reserved for benchmarking by RFC2544 192.18.0.0/27; rather than > > RFC2544 seems to use 198.18.0.0 and 198.19.0.0 ? The 18 and 19 networks would be used when doing L3fwd type test. The addresses this patch addresses are those used in the default case for a transmit only type of test (on same subnet). > > > the commonly used subnet 192.168.0.0/24 which is likely to used for > > administrative interface. > > Typo in the commit message "to used" should be "to be used" yes. > > > > > Signed-off-by: Stephen Hemminger > > --- > > app/test-pmd/txonly.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index > > 1f08b6ed37a2..22785bdcbe44 100644 > > --- a/app/test-pmd/txonly.c > > +++ b/app/test-pmd/txonly.c > > @@ -43,8 +43,9 @@ > > #define UDP_SRC_PORT 1024 > > #define UDP_DST_PORT 1024 > > > > -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define > > IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2) > > +/* RFC 2544 reserved IP addresses for benchmarking */ #define > > +IP_SRC_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 1) #define > > +IP_DST_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 2) > > > > #define IP_DEFTTL 64 /* from RFC 1340. */ > > #define IP_VERSION 0x40 > > -- > > 2.16.2 > > From RFC 2544: > "The single filter case should permit traffic from IP address 198.18.1.2 to IP address 198.19.65.2 and deny all other traffic." > > Should the macros be as follows? > #define IP_SRC_ADDR ((198U << 24) | (18 << 16) | (0 << 8) | 1) > #define IP_DST_ADDR ((198U << 24) | (19 << 16) | (0 << 8) | 2) > > Regards, > > Bernard >