[dpdk-dev] DPDK checkpatch and SPDX tags?

[dpdk-dev] DPDK checkpatch and SPDX tags?

[Stephen Hemminger]

What ever happened to my patch to fix the DPDK checkpatch wrapper ignore fields?
Is the build bot using current version?

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40880

_coding style issues_


WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#158: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#185: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#519: FILE: drivers/bus/vmbus/linux/vmbus_uio.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1839: FILE: drivers/bus/vmbus/vmbus_bufring.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#2086: FILE: drivers/bus/vmbus/vmbus_channel.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause

Re: [dpdk-dev] DPDK checkpatch and SPDX tags?

[Thomas Monjalon]

08/06/2018 19:15, Stephen Hemminger:
> What ever happened to my patch to fix the DPDK checkpatch wrapper ignore fields?
> Is the build bot using current version?

There was a discussion about implementing more checks,
and I did not apply your patch.
It is a mistake because even if we need to implement more checks,
we must disable the Linux SPDX check.
That's why I'm applying your patch now.