From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 537B91BB4E for ; Fri, 8 Jun 2018 20:12:02 +0200 (CEST) Received: by mail-pg0-f67.google.com with SMTP id l2-v6so6738806pgc.7 for ; Fri, 08 Jun 2018 11:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jRIjzHAVzg/1sphdyMZ8Pdih/jiJAkpsbKs2EpUdyo0=; b=ehBtjUvW1/GpFFkxcHB0FbX4NBpNPCM6mpkpk6JmK5qeWl7B29++NCKSlJT74VGZEy 4tFZzzw6gYaDBqSt1qOuFwgLO3upD5M7fv0JzEx7hkb+b1r+QlsNCU7NZIlRn+TMcmws rossPNxviMQvXieH+MdrlKQEzHrdY4eUcDDIUj+r/SYMJ3lEh+cUdFZiPDL8/Yx33uEC KVdpcEkWJuU77JuMymxFH59cNBbj1zwn0EIYs0x9E6JEFdHSrccsZjg801kEriYp4GX1 iUYY+QuPXQAfs0qcsu1mnhOst70831gNr/JuwY/hl4usH1Mow1sRVIZHF9PWeM4/0WD9 3WtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jRIjzHAVzg/1sphdyMZ8Pdih/jiJAkpsbKs2EpUdyo0=; b=qYZo6FlviS6gMpKMKuUFJ95SGB2RzuodGsPj/1ME6Yt13Bq+WwtNgwMAJBU4MInvz1 6N51RjOYh4jK+PFzR5T7IK+R1UE6MNEm78pXkXmxiIbqCW4VnBhma+WT3Z3NjIXjjpmI nw776Td2pVn/yEQGPdmSEKA+VOKbK86LcBcQLpkVfduHgfoaj73c6OrhbDzmNrayXKMI /k4W7S38WtLS6dGeaDze6437qyCZUZMCitV0km9XU2+Imqg0pDfpYI/e57ZeTTCNZ1V9 MQJ2O0lThmfP8IjWPa0L6zGrX/KcYVq7jYki2hmon6gVaWWoafT5L+wABJ0Hp9srIOTh IPdQ== X-Gm-Message-State: APt69E0QbPBkijWommmw7F4j1sKWMMn1PNzkRvYrzH8T1gDZ+gNya1Bb u0F0CeDqvbPY2KqEcpIDH5HI4w== X-Google-Smtp-Source: ADUXVKIyUmMNJW1rSVCKBC9eyinvsm+nbACHtA75DQ9m0Z60JXxuO/AlvYtqPn8XQXHPhzcTvwnWog== X-Received: by 2002:a65:4809:: with SMTP id h9-v6mr6221941pgs.258.1528481521420; Fri, 08 Jun 2018 11:12:01 -0700 (PDT) Received: from xeon-e3 (204-195-35-107.wavecable.com. [204.195.35.107]) by smtp.gmail.com with ESMTPSA id p3-v6sm9318626pga.72.2018.06.08.11.12.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Jun 2018 11:12:01 -0700 (PDT) Date: Fri, 8 Jun 2018 11:11:54 -0700 From: Stephen Hemminger To: "Wiles, Keith" Cc: "dev@dpdk.org" , Stephen Hemminger Message-ID: <20180608111154.4a034010@xeon-e3> In-Reply-To: <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com> References: <20180608165920.12228-1-stephen@networkplumber.org> <20180608165920.12228-2-stephen@networkplumber.org> <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 1/5] eal: add rte_uuid support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 18:12:02 -0000 On Fri, 8 Jun 2018 17:15:04 +0000 "Wiles, Keith" wrote: > > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger wrote: > > > > Since uuid functions may not be available everywhere, implement > > uuid functions in DPDK. These are based off the BSD licensed > > libuuid in util-link. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/librte_eal/bsdapp/eal/Makefile | 1 + > > lib/librte_eal/common/Makefile | 2 +- > > lib/librte_eal/common/eal_common_uuid.c | 193 +++++++++++++++++++++++ > > lib/librte_eal/common/include/rte_uuid.h | 129 +++++++++++++++ > > lib/librte_eal/common/meson.build | 2 + > > lib/librte_eal/linuxapp/eal/Makefile | 1 + > > lib/librte_eal/rte_eal_version.map | 9 ++ > > 7 files changed, 336 insertions(+), 1 deletion(-) > > create mode 100644 lib/librte_eal/common/eal_common_uuid.c > > create mode 100644 lib/librte_eal/common/include/rte_uuid.h > > > > Hi Stephen, Why does this need to be in EAl/Common would this be better in the lib directory for utils or string routines? Does the EAl use the feature for something? > > Regards, > Keith > It could be anywhere. Not tied to being in EAL common but that is where the PCI parsing code is. Still not 100% sure we need our own version of this simple code. It is more about BSD and eventually Windows support.