From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0069.outbound.protection.outlook.com [104.47.37.69]) by dpdk.org (Postfix) with ESMTP id 3CD8E1E2D1; Mon, 11 Jun 2018 14:16:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R4VJKwljA+tQiG4MS1FZ+r9+teTdpOC+HsS9FkvGIgg=; b=h7/2he6nijchvJT/Bw8ddAXocNfgpX2bc7a0rokN+Uf6V+HFlIusTBRuGsFEe0raVS/C1D4GK+nCZDlA7ECQW8dKdFhZgSy1XUZ5ylWaGDyUQIIQAR1f5AX5axd3aThJV5xEr+Z2NU73kmg3J0EHO3g7TOWWInUVdkmJlFMegL8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by CY1PR07MB2523.namprd07.prod.outlook.com (2a01:111:e400:c636::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.17; Mon, 11 Jun 2018 12:16:01 +0000 Date: Mon, 11 Jun 2018 17:45:44 +0530 From: Jerin Jacob To: Nikhil Rao Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180611121542.GA8358@jerin> References: <1528026068-45239-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528026068-45239-1-git-send-email-nikhil.rao@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: PN1PR0101CA0035.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::21) To CY1PR07MB2523.namprd07.prod.outlook.com (2a01:111:e400:c636::14) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2523; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 3:3lRjPi6Svl6aO6DRWNk/myXBLUyQnqgeAkBJ/vXlgY82Gvfo2DQCkWeA1azNiKJIAkNy3VEqcEUcfNgZK2DUOPKgSeHpRmmw2UkcqqPHQp4Gm8MzmYv6ewlcb0fsvclS1MubYKKMy31VPWj7SzmuWGttvFejrfnREnglr6gBWX/FxoIUjL91VFk7FQ5punGvB5/vPrr53d8/wnPQBNLzenOKZ8PTiL7BHhsGy3WEeyTCdgQpOLJILDoS492a1yEP; 25:5TYHN5fDfXM1CHWUhWRRHi0liG3zey2tV4aOTU+XgGMhm7IEcuFo3h/C4wS2PD8NSS25qIFfx5b7ToLldzQhUvZTjKlMb5cPN4vaG6DQ0JF4jaWK1x8V4BwwtWgmC05aOQyQF7NnuZN4Im6LM5FElvhHw/hvf6R9n5MWPWem/5GmOWQSWX/AfEWIsi1Ag7vLC97xrFO5/dnpCVSf1O/PI1kPsEI7u6oiYcs3km7SZLUaD0cdALznm/GjmJIltaWUiY41XukThaxbyl+KWHj4QHsYTkGblLjkE8hIK5HOYOa5Amg/qkJ8GKIW/eMH+/1+K34uKRzS/LsNaZhwjtwUwA==; 31:cb0VT3PFQI7iGh7YSf9HaEwKitPfZuUO/SfB+bF4pJlpj5HuZXOuL33DRBhwopvv6VLo+iETUrWb3A0dyA68qNamoKlbLEB3rCRDFNzz4WUs8rQan3H+06CfaXtjZ3C57qaRcF3eZDjag0klk4v+X228MYyKbAta/PIvzQ4DwfLPN5AaxurFq0Zf50bZXa79oZMYWHkj0WLVl1fpISRTwGTO2qL7vso/kRwTKk1SPDQ= X-MS-TrafficTypeDiagnostic: CY1PR07MB2523: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 20:uugCNrr/dLEya+2eP6YgcGuXBKqr3rRuUgWADvKaV1ZUU+4k95OmppbF5h79MAiC4XSxX8qAtXmaP16nFVT/jdFm9fYXLtBM4uX+KPIPdR/WEhl61IEzRwxj5QhqLmjtxy4cAqM2fvxvFl9IkeOl2imspfV/rlpYum9ZM3cQUTEE5iqerz85Ly2seuNt4OVlcfoBu1sojXw6AFeoKSrg7wLKNompNqqXMm9rvHzoeFkB4Mt2XESe6QlswTLXMUlnt+SbtH3V53bq8PUAcm7385daLcSvaNkkyv7jY+3Xe6mN+16be+/eKlQ8o5vXTU4SXDn5FPPstsRSYhBD1NVwvEaHbEl70rKQ1+WsG6cObXXXV6cd7tg+E7cXk31w60ZIJyGskufpMFJ5AcAgDGKhdt5kWMZkDRKsx3bmdRNuYuvLlySjr6uf+5lbbLCyBOD6KSujV5V6Fw0eB2nGj4r4cZ5qchUwJSTZR9KETf8Qpq7UVrK2+camMZuCgD/fBvnSULYATfof6X+RNAsOeePzyIrl7WQxrXJa7WEvwcDnExmvI5UYg2grLm1aN1oz/kpE8lbxsO9iEL9A0VffiY1OyLGQrm0mZY3FWuJI8NZRujY=; 4:CeHO3tS+FzV0QiZ51ZyjWPxnS+fcBrvqD8SaX6npZqmei3BwchJoGUoTcV7Ek6pgibOAi6iaVkmXlVmXMKzSRqYa5qpVp8bzL03bDdjLyV91oUw6uQ8wzR67G8ZQ0CLqTI+b3wDo/H1+qhUxFzBLCHDCHcvjNWlr6F34hZ84r5d9y+3MEmQSMxaw5LKnujYYv+7v8XL8rFJwiSYphPLq+9gME6VkT17cVWx5dyJFIyctQ2sqgVFYkE5GCr90sprP9QrMOmkDkfO/vQvLNXZDInR+qPgUgSBjbgBqQ7pTjqgpRvchUdV8X3txewaswAQT X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB2523; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2523; X-Forefront-PRVS: 070092A9D3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39850400004)(396003)(346002)(376002)(366004)(13464003)(199004)(189003)(5660300001)(478600001)(8676002)(44832011)(6496006)(186003)(59450400001)(16526019)(26005)(386003)(42882007)(33656002)(106356001)(55016002)(52116002)(486006)(446003)(105586002)(476003)(956004)(11346002)(229853002)(97736004)(76176011)(58126008)(33896004)(55236004)(72206003)(16586007)(15650500001)(68736007)(47776003)(316002)(50466002)(23726003)(25786009)(66066001)(305945005)(7736002)(8936002)(9686003)(81166006)(4326008)(81156014)(53936002)(2906002)(6246003)(3846002)(6116002)(1076002)(33716001)(6666003)(6916009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2523; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2523; 23:HHcU0Pecio/nKWMFgeZnPLi4+F4MPw9f45xmGTRgd?= =?us-ascii?Q?SN/E4QAtMlqyRTAehV7+P8XFp6sMLkpZlzUrWvDiq/auIYpDwLHA3oNEnOOu?= =?us-ascii?Q?ODowmLrxICXxZP7d5I/rOQEQfoCVdKL4EFJupXN3f5wkAP7KzqR2eMRpFiUt?= =?us-ascii?Q?Jr5/5thMBuQqGtpaXi1401LuNYhrlyZbU3nsGJ85rqMNKzy03tIPPU9vEeub?= =?us-ascii?Q?sckwlgJrCt5ogK2s/dKlKawhySA3yx+xQaXwiaep9cEwAhjybWJqtYn4iONU?= =?us-ascii?Q?phIFnLGbVhWWze1NloRVNNN+JuU/RrgdWbFJxickEMXUsSSKLCudS04TXuxO?= =?us-ascii?Q?XoxQ7/l3QD2/uSWu8GSQwCvEjV5fvIq9DIKf6+b/+0GWlXg3hesnS+fWKO/R?= =?us-ascii?Q?6QJZotUEtM3yDUSOx4lJ00DssZoz6gN238QITtVnuwil1Gb1pGH+1WLzd1qF?= =?us-ascii?Q?D4bcB4L6tTQrRu4o8Xt5xTSk1fx2AhCu0VB1oVLYgPGlCr/qv5NwpX6BdLIm?= =?us-ascii?Q?NLd+ZfWX+N7BvPS1dOOQNVqrq0hKJy+dPaqlQUwUK0C5+P5uAbGo/P1e9chJ?= =?us-ascii?Q?DxHO2+6OaCgqiPpDzy/vFKKSKE+TTPU4AEQ08/1UkC3OrIMmYeeHUsfKg4HG?= =?us-ascii?Q?Yj2n/HpIM0IE/ugfi/oO7421vq9FTLnC1GJq9FwF6dsxgJjq8Qrceq665VA/?= =?us-ascii?Q?2KnSt/eBRzdbjz46cK7onrM06G97I4ddAiAnHMk+n4SUlL+X+keAj/b/+hwZ?= =?us-ascii?Q?OQhNbPtqFdznq+Dg7D3jM5CqrPmE0c82yWkYwqYnz+osROyC6CL6LmSPWTi7?= =?us-ascii?Q?J3Nv2j1ea+TCqf02uWt67xjFSQb4faesdzRVzPH3eXxy6i1e8BcFqLyXUEMf?= =?us-ascii?Q?lYDq4cK4uXmCNf+GIy3FfNowDJOaoJGbointRxvvbpdtz/cyTqI4ac6Oen0e?= =?us-ascii?Q?gSE5ecXXKkt+BkwsopFIpjac85Q+f6BVpVA2T3wMuQ8oSN8AaA+DV/Y2rPzd?= =?us-ascii?Q?Q924OUbdzsEOwwDk3VW5iQ9RYxj5fa4fTkA8iZGQ6DJB+0ie+lzTIYexPLxs?= =?us-ascii?Q?cAH2vzYCAbtfqG/8KTY5xIQwzDmgbld+w4u1SZ1rNp1wlw7UQcm1BmdAJ8vh?= =?us-ascii?Q?hi9si1A2MET0AHAK5dkaBxZG9IPekDs0cpIFYzBAtxfnQY20EJ3X8dvbcp+b?= =?us-ascii?Q?+31IagGuFyif28LvyJBI3CYye68J7P8CYPlcsQqhTTkBefrt8Pys04GdV6K/?= =?us-ascii?Q?h8rNyYny7n+1bpotySsA7hrUIKP02QifeUNmAlgamdZLoxPPzKtnmYmfhGvP?= =?us-ascii?Q?Ywa31GyPNMaRGXr12rTAfzD26Zd9khkRu207mRzlRgL/2uIBCyyzJQBDAuz3?= =?us-ascii?Q?pqEBIu5OtM11muwU5EvnZd6jtkNaOtevkrBaw9qBPm96BDZ?= X-Microsoft-Antispam-Message-Info: h+9wwjrDPvopTp8zUSLla6ET+1Lt6IalSq6mp0jL1hyPoTIkL7Wtm5a8luF4ura5Y965sIOIOCioAAAZH9LPMRGwzMZ8TyOWPA8i2zM8WfR2zqIAiDmNRVkQaSyroefdAvkdMm+yepxBdSu5YuGr82ObddC6OUAVY1idiEn5lhrMza4cEKM2mb60c7ufmjTO X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 6:lR5I8kTkaovWgqEJeLPxy23UYJRdipjXm1WEbt9r4+9IqdcOF9j/2oYrQ0EKO0PzGKBC8fI13TfpdgrveoXBwXGVZy5yrh5WVayOZhckCjbttSmI0HxI61qkgIXJnoMmHbhQS/+T9PWiHaJdIuhirGBOacFlnXfEK+KEwvcm8HzsVmfwBxM/1EQwnptjc++5RrcG+gH2jWg2lIPzKjHXLD74CGALHJUyumMD6IiE0z1cp9ELcQgJQ63cMOm/oeV4x6PS0SxApS4phWT5A/JWn+cAOBBDRP3PIlbLV09vNNFt5x+I1JwlAFcw1UvjmLEu8+NDslWVD7YzA9rxBU6bhYzih+hp/ez40/q3IHzp+X5mwimP28DerbU8Wfxh83Odd5OHrcbNJOVZlpTtGs8iiBCjZ3K9PeT+V44c7mzYbEnTsQ1hgRRFF8j+vGxyL4dlUqYcJEcnH5omck0FIwYYig==; 5:RLmbh5L6e49urgYEfKHcZ8gXSCNb3rQOgd+AJmcTPTU3DH0dr6MYug85n/lE4LpeHUjfhPR6hfN0P8Y2OpT++n3CgAZ8eFPz7dEitKBoARmR0oyrzNRJ9QKEaYX0P4EDW5u+vq8yUiFnqpjOGydqOuzTCNPQt8SLTy5znJAXxRI=; 24:ORxIpy1r8n84+Pk6kXtSVL4TEC7tOzC3NzQ7JGjoDIhmXt72zUZKEoDrQCzAb6VqmCY+ZQkRvDHy7DYpAWaaESqoDAoE6IPwXgQI2qMhlrE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 7:uA5twQtM59aVOp5SX7fFuarOdlOybTtqM3nDW8cTP2QW+xQeVD/wkWLBhKZ2r4HxpmK30bgyKWunl7XR+oKioajLxtjXkcsykojOx5ffF4NYEh7oGUPD1mdvRp4ZSFXTz2l0X+GUrijLlRxBWqCCJ1NCgfTG1jVLcAOGLhtDFoEeHOsHJQcyxV5A6LzbnXkSN2raJYWLQdrPc7guEUcgJ79RcQIqs6L0/dj8VAEDv7RaRlZvoAxDAeLMGeHGoZV2 X-MS-Office365-Filtering-Correlation-Id: ef1fd340-14e2-434f-1fc6-08d5cf9519ee X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2018 12:16:01.4289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef1fd340-14e2-434f-1fc6-08d5cf9519ee X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2523 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix missing update to Rx adaper WRR position X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 12:16:05 -0000 -----Original Message----- > Date: Sun, 3 Jun 2018 17:11:08 +0530 > From: Nikhil Rao > To: jerin.jacob@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , stable@dpdk.org > Subject: [PATCH] eventdev: fix missing update to Rx adaper WRR position > X-Mailer: git-send-email 1.8.3.1 > > After dequeuing Rx packets and enqueueing them to the > temporary buffer towards eventdev, the packet Rx loop exits > if the temporary buffer is full but the current WRR position > is not saved. > > Save away the current value of the WRR position, so packets > are dequeued from the correct Rx queue in the next invocation. > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > Suggested-by: Gage Eads > Signed-off-by: Nikhil Rao > Cc: stable@dpdk.org Applied to dpdk-next-eventdev/master. Thanks. > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > index 6f70509..53a3788 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -517,8 +517,10 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b) > */ > if (buf->count >= BATCH_SIZE) > flush_event_buffer(rx_adapter); > - if (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count)) > + if (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count)) { > + rx_adapter->wrr_pos = wrr_pos; > break; > + } > > stats->rx_poll_count++; > n = rte_eth_rx_burst(d, qid, mbufs, BATCH_SIZE); > -- > 1.8.3.1 >