From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0046.outbound.protection.outlook.com [104.47.40.46]) by dpdk.org (Postfix) with ESMTP id D0BE41B05F; Sun, 24 Jun 2018 14:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYzsWHv2kP9N7S8GntsJPNeiN6+krUftpEzjfp9byes=; b=fq42KNpta2skGBubznOkJzO5ZTqqvkg+I+pzArkA7a/RBWDxAO15SNZp7CZwmCQgUTNiPxAtsd2OzvDSX9FZ6z1IK+9HldwhlZHmI9WU3pMCqvIlm2MFXx/iU75qNirvHZQ0WtiNaSN/PQis9UPwuvzGGbbEX7JdaECVWYiieXQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.236.178) by CY1PR07MB2523.namprd07.prod.outlook.com (2a01:111:e400:c636::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Sun, 24 Jun 2018 12:17:32 +0000 Date: Sun, 24 Jun 2018 17:47:24 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Maciej Czekaj , dev@dpdk.org, stable@dpdk.org Message-ID: <20180624121723.GA7776@jerin> References: <20180621181450.91425-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180621181450.91425-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [106.200.236.178] X-ClientProxiedBy: BYAPR02CA0071.namprd02.prod.outlook.com (2603:10b6:a03:54::48) To CY1PR07MB2523.namprd07.prod.outlook.com (2a01:111:e400:c636::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8917afc2-fbbc-48c0-5970-08d5d9cc77a6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2523; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 3:ItkSDuSZoBYhFNhElKZABI9pGd3o6Cg1tEhcl5tNo7EQuP342Cn/2/mBXD4zhZcZmT788LOX5kaWPAf6RRsmopzq7bqVyOBaXYCucqq/yPo/G2zmF3ePEuKYcL2T5ykOb3XFD8qlmeUNe8WST9eTE0UqOUaNJBl/YrtSyVjTtNp3UL9a0u/qozHjx3pFVUGcVGZtZBdso2yYXBoIF8oUwAl4igiEF/jr6YB3C1pR5airzKYd+i67V2QVCPMa14ee; 25:4S3c7ct8Ernw034FkwmcslNeNg6BdEMWmPuJHJxN8z1XpfCOimCqqX3JOL27I/8eEouAkW+xG2POviCAh+MHgjUU1/CViwHIoR6vs/aOrvpQNR2xdIklPzHvqbp2i0bqcBClFUNzBJjmHu3ckDz4XWtZf5akpNUUiVJDTb1ojfwVDei80+nG5w9PZ/rZRD66soFBOct/kUvp4nUK/58vqgwSWOZ0LkBeSgTkn3G1Sc71VOIuOI/SmjskoLSZmCdRSdORPi6NXNQWdiAAo5Rj+oBLBivnU5DU47lD/655BXWdwqoIJszPo5N7dQrkUooecqphu9ePTPtclurVmutLag==; 31:TJgrbuywvgKij/QqIBHXp8gfyIkC72av8pn8/fpSgcMe1hG0Q3Bm+SRZDuhwW5zdHdgzb4z3r/vadbxxy6lrWNcFyuUc1jVsmMmzbToVh+Rs9wBaf62AbDznBlFFaK5jzkUeI3ibKLv+cVODkp84tss0+gYi8fdbkQKyLfhsRx41shEoWFx/kI23rFFQ5LdleSlJdBLs+EjW6qzr8YCx5f6JJY5fnLcs7ENYXEvPpq4= X-MS-TrafficTypeDiagnostic: CY1PR07MB2523: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 20:sQPe8Oy7RPJa0JUXocJ0LrOiXW0oX1FbJEJeP7HJqufXwNnEtQ4TQgq5heHED0ktkloTLvyOW6tc4jW15M2mQbcNJMMtOLW0dqH69O6YxO+5o7pY1xWvahz3XKwNkht8JcHz8GQadlbUpvrvJEBCbRD9G+8O1ayenhlRh5qx4+gR2Xneh6DRGlz+xZh0VhEGoUdM0e0BnvnUNiUJtN4Vuu85IQo0MJFkhU0FetergKi8SQNTVC/1oFrD40jBamJlB+vyrrtAA6zeYm4iJinIbn9YneUq0vkA8whjHC3hush2//0dNPRK52mtOa/X+SQxhvr0g9Nk1AkqyIRlUsMbot/DL4GdEgX1+mHFMOTHnPHsYAqg8qFXz/xEJQo2eVcb2mZF7r+gs4KZuGHf3a/6Ye2iJ0l3DkRv7ZH0R1nftvF/iuOqjNDfCpgG88wX7XfYdoupiN7PuGZl0JhWinLbeInJWzQZuN+7CosWHf9Ar3BS7m5OTD0lyXWIRiUGYU7TwDIefMlcjo4p7g3lJnpGzZqoJDMhNCEAGwWSA4WRL5ZveejojtbNwQouJQFLdB1ehO197Sh6mKpnTtFeHNYRJxdLXRMnowyqs4nlzY7t3rQ=; 4:JeHVXTXfhtOm2eQcTMgu5IyM+wvTYNt5rAbPx7ITQ0VmGE0qUMpQbac7yLTqdK2fAvKjI5SJrUsREl7bcfpaUIxW3Oe7oJKnv1fJ/UZrQbGl/I7CYGaA+kBPKY7sjcFx7w4++rp4TP1+MymKbralppkZGvnCW9DacXx+Nauhroe7Pg3BtV5l3SZ5cAZY1WMePGOgYMOI3MXW/EEvNfqWPF8XFE0HPOx1Bp83V8hGfjlE9iseD5NzMSbfWd2ghpHyJpKjwsHnAp5LoJNKOVtsToNVT5TV5ZSJev46Not6U1Mjo+2h2AlILno3U3XjJhVJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231254)(944501410)(52105095)(93006095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY1PR07MB2523; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2523; X-Forefront-PRVS: 0713BC207F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39850400004)(396003)(366004)(346002)(376002)(199004)(189003)(13464003)(6246003)(33896004)(52146003)(106356001)(33656002)(6496006)(105586002)(23676004)(2486003)(2870700001)(5660300001)(6666003)(76176011)(6916009)(52116002)(478600001)(47776003)(58126008)(2906002)(316002)(33716001)(9686003)(53936002)(55016002)(8676002)(81166006)(476003)(66066001)(229853002)(5009440100003)(97736004)(4326008)(42882007)(186003)(16526019)(3846002)(1076002)(6116002)(956004)(25786009)(44832011)(486006)(7736002)(8936002)(68736007)(59450400001)(446003)(386003)(81156014)(72206003)(305945005)(11346002)(26005)(50466002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2523; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA3TUIyNTIzOzIzOk9HYkFKZzQ0cnZ3NG5iVVc1K3F4Z2JPcFlN?= =?utf-8?B?NlJBYlpDbm9MZUFWc2lHaDFYRUhaMTBYSGxuYWxtWGJFMlhsdFFQRkNmS2w1?= =?utf-8?B?UHBZT1B5aUhtU0FZV25kY293UEZGMUMwRHRydzdONjI2ZGtVUXB0cEtNeGZx?= =?utf-8?B?RTdnYUhKc1JSM2lnWkNJVXdRb3o1SERNbHBGSlhZYmR5ZnVMalZ4aitIdzhh?= =?utf-8?B?SjQvV3BMU3o4a25EelIwNzV6UWlwUER3aUJLSVBnU1BRMFBya29uV0doMlh1?= =?utf-8?B?VVpkdVJ1NmhFeWxlOGNHRkpQYmJRdlpyK2I2b0lzQ3FRM0pCeHUwWTZRQS9Y?= =?utf-8?B?WUJ0RnRHa25sT0U1N29xQ3pBSStpL3RrOFprdEJIV0RjT2crNndTOHRUME16?= =?utf-8?B?M0J4YllwSmR2d2c5VzI4ek0wZXg5RlhkUGNoZm9ZYVVvUkkwNlZoL2g2TTRq?= =?utf-8?B?dEdQdGpmRVBlQThjeGs4RVh3bFptTmpGS2RSdUpYUU85R2hjY0xLb1M0RmpL?= =?utf-8?B?anNBL2Q1dmZ3YlR6YzBMRGJlbHptdzBtVm1RMnVGQUdxbjlZOGZiZTJDbGlq?= =?utf-8?B?QVdJSHYrUVlweVJMMEtMdEdJU0V5ajZxY0d5SkhsSHJrLzg0ZExaWlhRNXVB?= =?utf-8?B?QlpjRndwUmIxbTZ2c2QvaEJZT25RYkhTNVhVSDRGT2tna3Y5TnNFK0pkWHJy?= =?utf-8?B?Rk9pR0lUU2R4OFdMOWJ2SFVPaWhYdHB3OXZVODZodE5sakx5VzJLTGFUaytZ?= =?utf-8?B?ZXQ3TlhGbW5DY01FdnlWTDd3N3h3eGFqZTNzK1hzWW5YS3VYa0ZuY2xNdXha?= =?utf-8?B?aGRJbzZLMHVDK2w5N1hSRVlqQkxxVFJLQnpnbWFaWDNQeTFoRGRiNThnRVo2?= =?utf-8?B?Y3NZeEVFd3hsR0lEZFFFcGlNU0V4dXcwSTNnaVJVdzhHMFh0NHh4Vm5jMS9F?= =?utf-8?B?MTJiZHRvMisxdVRHV1FCZTNZZ0pwQmtIbGhwZHlBeUdWMWlIRVZYZjFuSkdT?= =?utf-8?B?OTJUenlWdjlLVVZpN1dteENySWdwTTdvT3lxR3RQeE5CQTVXWTRQbWtQMWd2?= =?utf-8?B?T3hlRVRuOWNUVkpMZHRWTGZrV3MyUGdGdHc1N2hjdWtaRUZXTER1MXBYUk1S?= =?utf-8?B?cm5ncSt5TmVlWDZCMHpiT0lrOXRsai9mVi9IQlYxazRaZ0cvQW81dXM5ZmhO?= =?utf-8?B?WnhhNU1YZkErdzNneG9DT0hYelg1Vzk4YmZJQzZCS2EyajB1QUg2MlExZFhX?= =?utf-8?B?SFVPVGZ0Z3VWMGFob2prNlZTKzVFK2QrTUJtVVZ1RGY5T0tkOVpXa29mb2xL?= =?utf-8?B?V0Z0dWV4U2hrRVRVblFCc2lNM2RiaGxoN213d0RmVG5ibVprMjlnZTB2RDNP?= =?utf-8?B?UzgvbkV0TG1FaTNYcFdWeHBINzRKbEJ1cXE1Z1R5ZGtPZmoycGNFZ3p6ZFNP?= =?utf-8?B?azVWL1g5TmJVM29VUnVnMkVDSyswTjdNRTg3K2hNNzFsOVdsZ0Z6aGUvUUFZ?= =?utf-8?B?R3NpdTJJZGpOeWZWaUZCYk1EQ09KM1RaenN0WmU5Sjg4ck4ySzdpN3MyTFl1?= =?utf-8?B?QkxPMDRsUHBSZDlHNE44a0g1RUJLbG12N2E0UEY5RzMrVHkxUGVvcjhNY1I2?= =?utf-8?B?R1crYzhhelhGNHpoTjVqZWV3Mk1PcHhyc2xZVTg1QlRMK3c2bnRrTmR4Sk1q?= =?utf-8?B?bTgvUWFxUmZCVWlpR2JiZ053S0VybTdBeEtPT1ROc1d6ek4yTzFWeUh0aTN2?= =?utf-8?B?RnVFQmhBek40bVZiMm1RRlRiNEFZclZ4UFN4bXVCZmNMS3VJUVM5bDhpZWx4?= =?utf-8?B?WEk1ZlJwV3BFZTYwblo3VWRmL3dTTDRRYTY3bjNLQ29jd2RLUWVoMnZHWWkr?= =?utf-8?B?am4vWHdXenJFcmgwdm0wNTZzV1FJNk9ablNiK29SN3ZrcWEzRmJQbnBlZnBG?= =?utf-8?Q?cpQXpdB1UTRbztl6rAxBAw3jD6ekO8=3D?= X-Microsoft-Antispam-Message-Info: ZmVEP3ENcVWJFqcoQ8+iO+1kmhgydglyRou7AWj22GcVDnLU09P/fUi0/R0qOEWUm+DfRerr3ONXVNF9TzsTl31W5n4Q4xKJw5I87ZHN/g4Q86LIlPXQrPO1zsnZvDjj9hXRFkfFkan0JzaoohdsJSEmWhZLVKf3Mmj9lM/WIBskWYUtL9lq5U7xU6gIeOhDO9KW8X+gcfUxpQs6qLYahmWzMZLkRv9fZzgOByBpTLDegAmhAuthMH0njtjScifuCTwTVkWforYVBtJ77K3xERKDjlOZ2fO8Os9YPp3rKU7RuavmcY7vnpgwJUUaoRBiQ/FoH5+KFvB79O4NuuLPDppBo+a/ugt6XNpUPvbqzJU= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 6:8GWnOIRsfnkSz9PTHLcB3tTmUo1CM0fW5NJ+LqWvRfkiXu6Zze3l/bCbbDDT+nM+3WGD3FNp+AndVpO7qWkztSuXsmyJsVcSeXP6u8fC6eb48jY0YmngmwXTclVs9bdgRgkguD638hzPwKjGBxMfY0CMWvaT399e7pRZeW3Pb+li85zb2haJaSO1tcMWTIa6jOkRqGdZCQKp5/FHr7IonOYa8KsQKBfh+IGxLiNw8HshYJfBkRh4ilBR9QnDWR9IcLdo2FFS+VtOz2Q8ykdYqkIJdYGbl4M5kFieBeg94JC3KxbhOvEpOztygYL0hd0JuKFo0aNVBucc6K30ADLJkeae6TH2TmXJD4IpReWbqOwh/GPTmPvFTPUPCct84DwYFDuz8Uy+kC4xcH5zAbLEyeebQU96mynZGamAbhCkvkrgYwgZXqNODyZ8/148oGSj5oIENDwQIVKCGZMBzdjBrA==; 5:UkfoE9yhbmcIZvFK+tyADlr6ioHQbFOdef3qlyp3xAaWg2flbMHTcrP2P6tv5aFHrCtAwjc9dvqRJ+vreBCAWH1I97KD0zuljXY/42xXvy1gJXZP1al/rEWGX2Knkr5jsAASSMOMfIM+OagyQCuCLp69ywD0fGv2a8v0+kiacAk=; 24:J0PtmlZyqdV7E2ibHN/moI7ZcL8ZRVr7AbAxSryyYUfkO7KzmpXtEdPSKnEfmzQ2Q5p+8/Fi7ocj1SGvJ4i1nEgUqBWOoyTPlDkzNZGoDRs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2523; 7:akPhIvOns4C6AXyqkXFLCUw1Mg7BD/kg3bDDdhrd2TG294tHBp94A/Uddmqqy+dkOcffrSdxRrkYXeGu/+Hf00Jh+mmR9dzPmgKSW/+T66a7yIhouxxE17JGT6SShLSbufPcycTQqmoWyeynUXlmrs7aSQewszHlxyAK2XDcvMl6aDci6tmJJmMZWzGMJ3rXE/pXZkH8sushESCGa9boK507ko6epc+ZksHPCSmpAoTVu+Yfa1z5Fx7eOibyKOFP X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2018 12:17:32.4301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8917afc2-fbbc-48c0-5970-08d5d9cc77a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2523 Subject: Re: [dpdk-dev] [PATCH] net/thunderx: fix build with gcc optimization on X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2018 12:17:38 -0000 -----Original Message----- > Date: Thu, 21 Jun 2018 19:14:50 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Maciej Czekaj > > CC: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org > Subject: [PATCH] net/thunderx: fix build with gcc optimization on > X-Mailer: git-send-email 2.17.1 > > > build error gcc version 6.3.1 20161221 (Red Hat 6.3.1-1), > with EXTRA_CFLAGS="-O3": > > .../drivers/net/thunderx/nicvf_ethdev.c:907:9: > error: ‘txq’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > if (txq->pool_free == nicvf_single_pool_free_xmited_buffers) > ~~~^~~~~~~~~~~ > .../drivers/net/thunderx/nicvf_ethdev.c:886:20: > note: ‘txq’ was declared here > struct nicvf_txq *txq; > ^~~ > > Same error on function 'nicvf_eth_dev_init' and 'nicvf_dev_start', it > seems 'nicvf_set_tx_function' inlined when optimization enabled. > > Initialize the txq and add NULL check before using it to fix. > > Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") > Cc: stable@dpdk.org > > Reported-by: Richard Walsh > Signed-off-by: Ferruh Yigit Acked-by: Jerin Jacob > --- > > Btw, no compiler optimization enabled, only nicvf_rxtx.c has -Ofast, > is this intentional? Yes. At least in our setup, -Ofast turns out to be super set of -O3.