From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 514FE2BF5 for ; Mon, 25 Jun 2018 13:32:55 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id e18-v6so13305347wrs.5 for ; Mon, 25 Jun 2018 04:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yYOTz80EQPF9Ac3gXrBWm30J9xMsrN5ncTmLNPRN9FI=; b=uHkZOswlqXNtModn/ul4/YH//ScSUtgwiskzaG16HPtagc38NZN+a0YvTwH36jiz0w Baqjl2QfDTOyDoOMz6BoFZTBIZWLGtEMMsvjVk57qF5+YcpKmf5DbdioXbHn1OVIj4aE fIoqCpheqmXbQyEhm6ndRKmOAxUl73N+wdmXAvx9aPBnn7fgo+l3zfjGQpQ3i0an5JAV 6MIEuWLsP58SUpVysypdyvyrMSk6YfhMtPBHRsnQf5ts95U/A7H/Kds8P9TQgNECcNnV JWFynf5QBmI6V5MNXExGTyOphZmd6TQL4jXdrKxPg5/+bRw54wZLX/WbNoVuUwliZs7K uv6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yYOTz80EQPF9Ac3gXrBWm30J9xMsrN5ncTmLNPRN9FI=; b=pmm85wleyoKZSongX9KjyPqmfRD2qIX1QOZEjHCoqyAv+1RrM0ER4jHvZIanCh8UF3 3+BH0lj632eRVATpwCqmBrtWlycUhdKYI3foTaXX2JdMEBW1AAli0mUCoJnoWoe4wWqH 3SSFDvwge1p++zoGk9OENpwMVEONmnsQOc+BEPOxmljNm6hXKQq4F0nneNQL6JxinMfL l2Gj/1iDFT/1xky7QGp9QtmGubL83/Y+0hDG3JCU/T91SS+6NmnvgWoB8rsICuVUh+01 u2NjP5ppPp8oT+30j6UMKbn+b7u6ZKd1wCHR8rUZ64iDIC1OnKTFu1IgaE6H92YVFV+C F9ww== X-Gm-Message-State: APt69E1Q9s3h9eZQArynPxrO7fFTRAnuXc5FrHPwLPdf9ScsSa005ieY 6PVx1oAAs6uD6dX5K0cIt06i X-Google-Smtp-Source: AAOMgpcyaAQ5SqdD/P3U33L89huH4pQMlApMvkiWeTJwJjy0np094unjI43LAy+FitvJcLCULW1Bmg== X-Received: by 2002:adf:a0b3:: with SMTP id m48-v6mr9508723wrm.125.1529926375017; Mon, 25 Jun 2018 04:32:55 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l6-v6sm628743wmh.41.2018.06.25.04.32.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 04:32:54 -0700 (PDT) Date: Mon, 25 Jun 2018 13:33:17 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180625113317.rd5y5d4izhuvx4ri@laranjeiro-vm.dev.6wind.com> References: <20180624062226.11507-1-shahafs@mellanox.com> <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 11:32:55 -0000 On Mon, Jun 25, 2018 at 11:23:22AM +0000, Shahaf Shuler wrote: > Monday, June 25, 2018 9:41 AM , Nélio Laranjeiro: > > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > > standard one > > > > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > > > The generic tunnel TSO was depended in the regular one capabilities to > > > be enabled. > > > > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Shahaf Shuler > > > Acked-by: Yongseok Koh > > > --- > > > drivers/net/mlx5/mlx5_txq.c | 13 +++++++++---- > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > [...] > > > > - txq_ctrl->txq.tunnel_en = config->tunnel_en; > > > + txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp; > > > txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO | > > > DEV_TX_OFFLOAD_UDP_TNL_TSO | > > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) & > > > -- > > > 2.12.0 > > > > > > > Is not it a fix? > > Well, more like optimization. To be less strict on when to enable the > generic tunnel TSO. > I can rephrase the title if you insist. I was asking due to the CC'ed stable, which is generally used when the it is a fix. I don't know how the stable maintainers trigger such patch, that why I am asking. I am not insisting in any thing here. By the way: Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND