From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: santosh.shukla@caviumnetworks.com,
John McNamara <john.mcnamara@intel.com>
Subject: [dpdk-dev] [PATCH 1/2] eal: remove deprecated function returning mbuf pool ops name
Date: Tue, 26 Jun 2018 11:12:35 +0200 [thread overview]
Message-ID: <20180626091236.30429-1-olivier.matz@6wind.com> (raw)
rte_eal_mbuf_default_mempool_ops() is replaced by
rte_mbuf_best_mempool_ops().
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 9 ---------
lib/librte_eal/bsdapp/eal/eal.c | 10 ----------
lib/librte_eal/common/include/rte_eal.h | 11 -----------
lib/librte_eal/linuxapp/eal/eal.c | 10 ----------
lib/librte_eal/rte_eal_version.map | 2 --
5 files changed, 42 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 1ce692eac..5bf680515 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -37,15 +37,6 @@ Deprecation Notices
- ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse``
- ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp``
-* eal: a new set of mbuf mempool ops name APIs for user, platform and best
- mempool names have been defined in ``rte_mbuf`` in v18.02. The uses of
- ``rte_eal_mbuf_default_mempool_ops`` shall be replaced by
- ``rte_mbuf_best_mempool_ops``.
- The following function is deprecated since 18.05, and will be removed
- in 18.08:
-
- - ``rte_eal_mbuf_default_mempool_ops``
-
* mbuf: The opaque ``mbuf->hash.sched`` field will be updated to support generic
definition in line with the ethdev TM and MTR APIs. Currently, this field
is defined in librte_sched in a non-generic way. The new generic format
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index dc279542d..f7cced725 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -153,16 +153,6 @@ rte_eal_mbuf_user_pool_ops(void)
return internal_config.user_mbuf_pool_ops_name;
}
-/* Return mbuf pool ops name */
-const char *
-rte_eal_mbuf_default_mempool_ops(void)
-{
- if (internal_config.user_mbuf_pool_ops_name == NULL)
- return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
-
- return internal_config.user_mbuf_pool_ops_name;
-}
-
/* Return a pointer to the configuration structure */
struct rte_config *
rte_eal_get_configuration(void)
diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 8de5d69e8..0c9c3f13b 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -501,17 +501,6 @@ enum rte_iova_mode rte_eal_iova_mode(void);
const char * __rte_experimental
rte_eal_mbuf_user_pool_ops(void);
-/**
- * @deprecated
- * Get default pool ops name for mbuf
- *
- * @return
- * returns default pool ops name.
- */
-__rte_deprecated
-const char *
-rte_eal_mbuf_default_mempool_ops(void);
-
#ifdef __cplusplus
}
#endif
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 8655b8691..cf2a8082b 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -161,16 +161,6 @@ rte_eal_mbuf_user_pool_ops(void)
return internal_config.user_mbuf_pool_ops_name;
}
-/* Return mbuf pool ops name */
-const char *
-rte_eal_mbuf_default_mempool_ops(void)
-{
- if (internal_config.user_mbuf_pool_ops_name == NULL)
- return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
-
- return internal_config.user_mbuf_pool_ops_name;
-}
-
/* Return a pointer to the configuration structure */
struct rte_config *
rte_eal_get_configuration(void)
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index f7dd0e7bc..3d4a9d3bb 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -181,7 +181,6 @@ DPDK_17.11 {
rte_bus_get_iommu_class;
rte_eal_has_pci;
rte_eal_iova_mode;
- rte_eal_mbuf_default_mempool_ops;
rte_eal_using_phys_addrs;
rte_eal_vfio_intr_mode;
rte_lcore_has_role;
@@ -259,7 +258,6 @@ EXPERIMENTAL {
rte_eal_cleanup;
rte_eal_hotplug_add;
rte_eal_hotplug_remove;
- rte_eal_mbuf_user_pool_ops;
rte_fbarray_attach;
rte_fbarray_destroy;
rte_fbarray_detach;
--
2.11.0
next reply other threads:[~2018-06-26 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 9:12 Olivier Matz [this message]
2018-06-26 9:12 ` [dpdk-dev] [PATCH 2/2] eal: remove experimental tag from user mbuf pool ops func Olivier Matz
2018-06-26 9:51 ` [dpdk-dev] [PATCH 1/2] eal: remove deprecated function returning mbuf pool ops name Olivier Matz
2018-06-26 9:56 ` [dpdk-dev] [PATCH v2 " Olivier Matz
2018-06-26 9:56 ` [dpdk-dev] [PATCH v2 2/2] eal: remove experimental tag from user mbuf pool ops func Olivier Matz
2018-06-27 15:06 ` santosh
2018-06-26 12:16 ` [dpdk-dev] [PATCH v2 1/2] eal: remove deprecated function returning mbuf pool ops name Burakov, Anatoly
2018-06-27 15:08 ` santosh
2018-07-26 21:42 ` Thomas Monjalon
2018-08-05 21:45 ` Thomas Monjalon
2018-08-07 21:34 ` [dpdk-dev] [PATCH v3 " Olivier Matz
2018-08-07 21:34 ` [dpdk-dev] [PATCH v3 2/2] eal: remove experimental tag from user mbuf pool ops func Olivier Matz
2018-08-08 11:40 ` Hemant
2018-08-08 22:46 ` Thomas Monjalon
2018-08-08 11:40 ` [dpdk-dev] [PATCH v3 1/2] eal: remove deprecated function returning mbuf pool ops name Hemant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626091236.30429-1-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=john.mcnamara@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).