From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 64D1F1BE99 for ; Wed, 27 Jun 2018 10:40:17 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id w137-v6so4808748wmw.1 for ; Wed, 27 Jun 2018 01:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ck4dGFLiAZO2asHcPoRLv/2JBCO8M/OPjdlnNJze7HI=; b=L9vgzRLexMVJRzEv1wXUTPMsUH88tUlVCgPxnf/P/pAvyBdxfqxTGEownql1xC4pqu IsdCY3xvJg4Yu+LKggi0Sf3WveKtG1zdE+sNsshOIrZ6V/f/JSdjoCvNseNYDkSt4Co4 D7jWFgBrPNR4ghgaUQCciH9lKW0T3IKACJsRhtnv5jgvbc54S0cMfGKP2CYETtvpJCuH rev0ZN/UTWebSsdX7a1O5UcFd+7oqNtYrhbGzKtcd9OYSj0ZGjj6ezDlDjrqWO4swAru eaTY9D+K4AZhuhY5MzxM/DwA0pnI+wHIBgavp1gAejVWNYqcKzPYHndlBksIfj1cK2z5 2wJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ck4dGFLiAZO2asHcPoRLv/2JBCO8M/OPjdlnNJze7HI=; b=KRScd+CExeo3V5/ZTmoHT9/pSD+ApYO1DevQOIoB6V8QpzYn/wghPXJocwd52RSC0q GyNSQvk68FBSmTUK/szFembJYnZ07qfjInMat6Y4XUAVGhemhjzfgmWrrlYQw45mMsaa VPAeu2ZsLONsmqMfTstohWMdIrRR3fp0/k/99TIfVhQhmJ9YMKOjKnS4Ld/YX9I9m2sV f/FRBUXZuj+mMoo/CQ/udZ6wZ4z6agznABYmRhoCUJSpqZqztMaYfRtQfPmcK9IW62t6 cWRLb3lDCiorvj9N6hGqxm1OI71N6WPFSU983pqSE1LC4pDEcjNq/jBCgCHn7GrW1ErJ op6g== X-Gm-Message-State: APt69E0UsAmsuOLznum0H+Z0zSQShYsIcwZlTG7uC2OZZ1uhMwOtAcYe YNY+6RqLbTcdU0yBVynQOeYRWiAK X-Google-Smtp-Source: AAOMgpfu6hn29q1hOaMgm7pgRFOVer8JdjJFfra3ddQ/kMjTe9lwXlriFS35DGG7LjLWqJNRZ1jChQ== X-Received: by 2002:a1c:abc6:: with SMTP id u189-v6mr3964239wme.64.1530088817017; Wed, 27 Jun 2018 01:40:17 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r2-v6sm5757327wmb.39.2018.06.27.01.40.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 01:40:16 -0700 (PDT) Date: Wed, 27 Jun 2018 10:39:59 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: Shahaf Shuler , Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , Thomas Monjalon , "dev@dpdk.org" Message-ID: <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 08:40:17 -0000 Hi Ferruh, Pavan, sorry for the delay, On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote: > On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > > Hi Pavan, > > > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > >> args > >> > >> Currently, the only way of supplying device argument to a pci device is to > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > >> as whitelisting a device has its own side effects i.e only the whitelisted pci > >> devices are probed. > >> > >> Add a new eal command line option --pci-args to pass device args without the > >> need to whitelist the devices. > >> --pci-args 000X:00:0X.0,self_test=1 > >> > >> Signed-off-by: Pavan Nikhilesh > > > > Tested-by: Shahaf Shuler > > > > It seems to work. > > Please see small comments below > > Isn't this conflict with Gaetan's devarg work which has wider scope? > Indeed it does. Pavan, I have submitted a new version of a series adding generic kvargs to several layers (bus, class, driver). It does cover this exact use-case. However, while writing it, I wasn't able to find PCI bus specific parameters, that could showcase the functionality. It would help the development if you could provide which parameter you wanted to implement, I could add it in my own series, which would streamline all of this. Regards, -- Gaëtan Rivet 6WIND