From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0042.outbound.protection.outlook.com [104.47.41.42]) by dpdk.org (Postfix) with ESMTP id 05FA01BED9 for ; Wed, 27 Jun 2018 11:06:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wHcXi8PpOtYIkJXaSiHm5CW3M6eDDCAp02iDKsnGQzk=; b=WbFHzZwB+kEXTNuEYYs3Bdwc+8zLd6CmDURnHx1OPbBBDgePjrg+pbch2yTmR1J8yHEmD0PHiUR8uQx+smed9AnL0IE/uHswMooZmrwqtxF2S13VNB044mdz8waBakcm+ai6WopuhUtCVbrNbWGVjE0RzX4gbTL3SmVF9wL5yNE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Wed, 27 Jun 2018 08:55:52 +0000 Date: Wed, 27 Jun 2018 14:25:30 +0530 From: Pavan Nikhilesh To: =?iso-8859-1?Q?Ga=EBtan?= Rivet , Shahaf Shuler , Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20180627085529.GA14236@ltp-pvn> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0020.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::30) To CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4ed2bad-3199-48eb-fbd7-08d5dc0bcb31 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:5G5ie4mSDwZKhMXUAFGPMv1GknlKiKjdB27L7wtnI0vM5gR56tyZLlgl4x65hXK1y9DymRSsAkvvtkX/KyFCMqeELNT3jss4n1acTa0VGtxnvy/Cy24F0A0te5YTeXNElLd9mgXO4k+6L8PrzG28CUpzxhMuhvTq2Une3sCib0kzBXT7qEdo4WNCpz6zusGh7ez87wkrcYYZ7KnqlgLeoeduF7KrR9FOOLmDSQ3r7xjG6Yrx64Zctg1JjBfeNJle; 25:HJr9l4h+mHMHbBFMD1TNQRf82IqAw+hQo/IHqjF84yMLQ9wDwXI0k+ohiyWwP8iZZZcNQU26Wor3zs/VMtwxvaz1n+0kqqM5JHVrS1/T1aQgh21rceM+Ca1UyV85yaZbUy2v1w4QhXK3TdkaqRHhWZIXu4dw/1s9uJJJ7nVtDBJg3GcmHN9cMcmy3d8JT+wBQ9xEKIMl831ZAaqcoEDpXRXuhaZqK6o3yPJhRSNvYNXuZ+n9u+MP+N1z3m6OaBh/x/stCGOthF4+9M9RCMQaoienxBxl0CsnKlqn/AZaj+dLlSH/fioKwMzV4L+A25p1PQNyuxE1mSBLLm022VaQDw==; 31:rMoLvEcoi3w2KuPVc5QEeL6vVfEhXDnCNBBephwruHYsxXp6ehB1tEjrMLi4I0xj5us3o6ddqOTtyPHE0RSAoEeyXe+o0IoP2XVwFqVUBMeCSRojTjL4kViSJ0xuAys66jVFqXkT2r4A2tpaegz9vpX1YcHlOAOJw5mQLcPgxkptzG3pmz12Ep+S/SLowtOnnrz4oR02IYfriFZodqMuue6Hu+k5PM9Xop2ok9CFGtQ= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:fGR00Lo4+Y0kQUsIH7/FRkEScV/k2OH+z2KP8sOxGMuv7cO3K4vJaTsr7/jgjDkzX4Blx5G59TcqQ1mw3Wy9ft2I8AcRY9eQTkjR2mrj7/GBJF9Xc9okhKdPQZJ2IFvRHjFKQV9bDEFhdZdvYUS8e1j0hGhlWL1x69VXud6quQalCscoUS3rfTH8qnjd/tut2BlIOmgS6z9Pod/NluBxzwBipNHCP6utEaTgU5OJVVOJcW3LSH9AqqhUr5eiW1xWgynKc7ouvWLd2L7RuQS3V7pfeXjAT1A0Ar0f4147BVsnpVwNtSJ5OwpeZ2+cAuvT7WUQlrntlvMB1aDsZLvukQ6g1OrjsjDmt9ZNmUEndKVjhsY7wpcqMMCy01BnNmHW34Bh2L5MxQs9OCFaiNu0jtv4T38XSCr/f3K/gzOLdjUX7ECPt2xcIG+MZ+VKOgDSGNm4ijq8zJCEpLWh66mQEsnASFmLBVCuMeqMNDbtbQrTlKCBj4AbVwWWHfRgn6srq7YNd4qZ8RYNHzj2n+MqthrrgN9uxLMgNpyFrU9p9cPp2nrlXmRcJ/NXlpsk5KiO9CUmu2JZKGy4X8FLndYF4O/QO6w4lsBBkkKwbXKCOiA=; 4:DqAsFr8wEylnxwFFqvj9ySgWJ7Nv8ioIq4Jc2gFgN0RjnITdlxr8aTf4s5+le9wGkTiRlV+Q6yOJhY9Eo4Ti/2B2QuSLVr3UWuZRI84f0N/coo04QGnJFtjzyHgHj7Hlk1/4hEvVFOWv0uykGsCofBlTrg7uAavk56xqcRUT7zy2juJXAYVvG/+Oy7doZzFMXBrFNqGvgEFE1W3CMJuOxwgmOcIZprod8xKk6ApB01r8Tz0Lc4hNF3OhbE/vmCis6gzY8VtpFveHbFXOBGJZXg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3464; X-Forefront-PRVS: 0716E70AB6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(366004)(136003)(39860400002)(189003)(199004)(6246003)(72206003)(33656002)(956004)(476003)(2906002)(5660300001)(53936002)(4326008)(25786009)(5009440100003)(68736007)(33716001)(2870700001)(97736004)(486006)(6666003)(106356001)(105586002)(478600001)(3846002)(6116002)(1076002)(76176011)(81166006)(9686003)(26005)(6306002)(55016002)(2501003)(58126008)(8676002)(8936002)(81156014)(50466002)(316002)(93886005)(229853002)(16526019)(33896004)(186003)(23756003)(11346002)(53546011)(386003)(305945005)(446003)(47776003)(52116002)(110136005)(6496006)(42882007)(66066001)(7736002)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; CY4PR07MB3464; 23:DymJ30ocER+Iww6X1s4/hagRem+fHmpLE6sauPa?= =?iso-8859-1?Q?Wad2n0QXuYnwd+XAvt1gHM1mYGdMR8UpAzK/NNVaJsIvgDqsCCAp99EWI+?= =?iso-8859-1?Q?ZXkv6SOvlEtGwD2PsBCRVpb2gjgqV6jkaJmQuPkLtT5azdiGiXtuVi4dXA?= =?iso-8859-1?Q?vYzRDHIK50DiWwv9tRgd1LwdD/n+CydDPMhN1IcKNiGYMSvqqjb3LoOiAc?= =?iso-8859-1?Q?Mb/DgLAwAN7vrO2oPhgdV93HK+2nhjHbyaj35jMicvh+6c2/Fhf4NBxGFI?= =?iso-8859-1?Q?6joXEQULphuHcXrg9q3osMXlI+MkKp0k0j9UAV6QomzpmSSZxfv3fRcwN3?= =?iso-8859-1?Q?XQ1xxz5deswKhps9tkE6IoyZDeL9tssals3/Tz/FgmmHg0NnrTj1yVKoH+?= =?iso-8859-1?Q?SF1uziQK37zAbUzveUL3ibegE7V8nFDIO5FBFGm7PnsyQSVw++Q8LA9Lx6?= =?iso-8859-1?Q?6ZG4IyuCJL7Skq51hvDJ48jVacDyCygl6Dzq5V75/7jxfBB/tta7u3O7L0?= =?iso-8859-1?Q?nb2V3X4kSJ2n3A2djec4ZgqDPqR5ppKBxC+X7/KK+kznkpcbrgl9z7TogH?= =?iso-8859-1?Q?GTGIBUn51AN7KpK5TqreZiTZEADWASpOR43BAce4Cj3Q8k8yjYkj6PfF+6?= =?iso-8859-1?Q?bY8ppg/PRMR8smoMDTE2GoB4LWeThFs6w9UjSP2g/bfvy7JBMBj3EDnObY?= =?iso-8859-1?Q?/Lb0PxBilVtfMuxy9RCZsKz1Wp+t6r2F5KOoju4G339Y2hJVpceuKUK9Qj?= =?iso-8859-1?Q?quEwfGpybGtaPXfY2gyJdtx/a0a7VJ0PN2iD8D8ya2njwo9DsGBIU0vfca?= =?iso-8859-1?Q?C0mUTVShhNroPkcjQsTnPx5SDBixLw/LXA2WRsQFxD0QDL+KGzwK6i7361?= =?iso-8859-1?Q?ULLOyjOPHiu0qvwVNRLQ7hGGvBDEEuSI3/AKTTsJ/k2uKHUky37S7dtXyL?= =?iso-8859-1?Q?LPaueurVmST57fHbpAmkeXe93nN/rQVWNTq+NfpI1rc/0gG1Ffy9/UPL6w?= =?iso-8859-1?Q?7RM9FCnjd2IDfSsztOWhaIiiDhJo7f6jRaWEKY6Lwf//5J3CMg3BDyr//A?= =?iso-8859-1?Q?cX9cBi+xbtXG8ITm3l4imOV/n8ldvuBnIX8agypENQqeSa6b2mFae/vAFj?= =?iso-8859-1?Q?uiImeTHVDyISxf+hEjTLdiYdNspt7shoivRGqGx0z/1giRU410DM4Vkxf8?= =?iso-8859-1?Q?+AbMiQquWuThbpmMriZ5igR8oTVI+RTqRDgQ9TkTGvTtbcnGyLQ2bT8uJU?= =?iso-8859-1?Q?stXjbkz/7+wnJAQZNerY6XDhmn61rb10xQ8mQ+9qAU+DiAKOY8nlP3trxd?= =?iso-8859-1?Q?MRl1WdkqNdoTMTv3dIyu/Za03vbKJ/xQmJ2w3ZFswFPUznv23B+sbzsQLh?= =?iso-8859-1?Q?AL0ZEY7cPDs/CRk3duXTe/4wmPKowRrMGvzrnYR8vE3aeV54xVB/lpULNb?= =?iso-8859-1?Q?hA3NpzSQ2NXvys3FfFD/+LOeaFPxnRv29je0weOqKR5VYGVKGdAg1lh4mt?= =?iso-8859-1?Q?AzhXrdOdeMEVWHdup4jI=3D?= X-Microsoft-Antispam-Message-Info: nHm4IsnLO0B+z/4iTQr6V8MAOU+/zJ7r+fm4tokrdkN7IYuSQFe0BDXfEp3xBvK9fzkiP9N/AIihGf8bzeO4DMtNVdLMjdKb6TNu4cKUrbK9GYFQXZigStyr65xyyaEr00lnDEYVnGyj08J5iP5H58Wcn8ZAAUEfqcz1EsJUPrLPILqOZah8GDsoK6fhzT+wlZZfQpurQgaxx2dyVt3yPnij1QXHiATrkv+dKMsE549+kw3s1pX6w0mkJuOv56xI4Ti4aJPZmdmPWApH6Q3SKFEO9MBAxw8C49iL752uhMc0a5GsuZ9/TbcnSwyLnE79cZmKv/vrN1ER4I6QivYzWT4nqiSAgHUXrI/iPG3re7A= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:A/tiTgiMkMAR0plUlwGVlocM/xoJNex/YuXYqAJUBohMlVcw96+ZbwN1ObMjBEZPhDYTObqMk2flHxtTicbH4K8Q6uuoia5G3cin4tet/w0GOam3CjQzP9iaMTnYYpjjE2pxyKgrsCTBD0XCz+mxcl3r7Cn9UU9gkcpkrqkZxLGCjnAf9exlE93ngnBd75XmaTMRVqkJ6LU1JdH+h12XRYJsgBIBaenlQYa0nDDnzOfgazqCIDpSwcOLJ4G/MmWChLItwSedAIDWUKOhJTWSE/oh8QX+mWqbhu4NZnOBCLj/Anbin0d4awVIn6Dh3Oqi9Ulsmy+M1UBP17QryPI/kdB4dFl7wbgIMILfyrdQiUXJwvzG9RUnRZ+H/60/gpY6gsrBGad1J/4sC+K8kKLXwIAuQRrhpYDPJEmMMa0C71bmA8nutA2pdAGKL56pBZlQbYuexVi75awvW9Y3R3dpCA==; 5:goxAiM/KX+1md7uTmYVl/QxY24UeAQpNEzer4Y7EnWV8VNgDWvMX8wj9bLeWSceLUyW+jJZEgz1qXah4HWYxmzm8if/6f5B9UpJdb21xRQ40Uh5Ny4oPHsOS0OKB4SLiSJcFqhCPIGvrrVLGIW3Nh5sayPcQb7PvmKevuAyxsJA=; 24:1wXihFG7am1pl4uXIzQKL9UQhyM5DERKBjd089K3hJ8jzTK7qbpL5CyXK9+hvYM3/5gq6bcmjdB5SQKU91znRt7kefWw+ZU2acwrdUXhq2g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 7:Tz/tfUs3AOF8huCzMvkb7jq5KANHXFG271z0gi8fmaDC9NS27FFLo4qICAJrrc4cVyfhKImmeBbInhB/oT70J81hJzZ8gJgA0DNoaSB+ZGZqECEP41M6Bw6oF+Cb+9Y93rQieyDQOt7pvjuVeYc/LW7upbq+1dBMeIgSTSkx0ZEzbwKolFxjtwt2re3iMBY0bJQmnTCclGn86ZbRpf4u+srPiUUM/9EG8A98QNW1rCKVbd2zWhASdv++83CrdJn1 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2018 08:55:52.8646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e4ed2bad-3199-48eb-fbd7-08d5dc0bcb31 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 09:06:24 -0000 Hi Gaëtan, On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote: > Hi Ferruh, Pavan, > > sorry for the delay, > > On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote: > > On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > > > Hi Pavan, > > > > > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > >> args > > >> > > >> Currently, the only way of supplying device argument to a pci device is to > > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > > >> as whitelisting a device has its own side effects i.e only the whitelisted pci > > >> devices are probed. > > >> > > >> Add a new eal command line option --pci-args to pass device args without the > > >> need to whitelist the devices. > > >> --pci-args 000X:00:0X.0,self_test=1 > > >> > > >> Signed-off-by: Pavan Nikhilesh > > > > > > Tested-by: Shahaf Shuler > > > > > > It seems to work. > > > Please see small comments below > > > > Isn't this conflict with Gaetan's devarg work which has wider scope? > > > > Indeed it does. > > Pavan, I have submitted a new version of a series adding generic kvargs > to several layers (bus, class, driver). > > It does cover this exact use-case. > > However, while writing it, I wasn't able to find PCI bus specific > parameters, that could showcase the functionality. The idea of the patch is to avoid whitelising a device when we want to supply kvargs to it, I tried mapping it to devargs rework patchset but couldn't do it at a glance. For example, the following patch[1] reads kvargs through whitelisting which should be avoided. [1]http://patches.dpdk.org/patch/41223/ > > It would help the development if you could provide which parameter you > wanted to implement, I could add it in my own series, which would > streamline all of this. +1 > > Regards, > -- > Gaëtan Rivet > 6WIND Thanks, Pavan.