* [dpdk-dev] [PATCH] net/mlx5: fix invalid error check
@ 2018-06-27 9:20 Adrien Mazarguil
2018-06-27 11:55 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2018-06-27 9:20 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: dev, Nelio Laranjeiro, stable
Since its return type is unsigned, if_nametoindex() returns 0 in case of
error, never -1.
Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Cc: stable@dpdk.org
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 90488af33..ebe5cb6e3 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -192,13 +192,13 @@ int
mlx5_ifindex(const struct rte_eth_dev *dev)
{
char ifname[IF_NAMESIZE];
- int ret;
+ unsigned int ret;
ret = mlx5_get_ifname(dev, &ifname);
if (ret)
return ret;
ret = if_nametoindex(ifname);
- if (ret == -1) {
+ if (ret == 0) {
rte_errno = errno;
return -rte_errno;
}
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check
2018-06-27 9:20 [dpdk-dev] [PATCH] net/mlx5: fix invalid error check Adrien Mazarguil
@ 2018-06-27 11:55 ` Nélio Laranjeiro
2018-06-28 6:39 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2018-06-27 11:55 UTC (permalink / raw)
To: Adrien Mazarguil; +Cc: Shahaf Shuler, dev, stable
On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote:
> Since its return type is unsigned, if_nametoindex() returns 0 in case of
> error, never -1.
>
> Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses")
> Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 90488af33..ebe5cb6e3 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -192,13 +192,13 @@ int
> mlx5_ifindex(const struct rte_eth_dev *dev)
> {
> char ifname[IF_NAMESIZE];
> - int ret;
> + unsigned int ret;
>
> ret = mlx5_get_ifname(dev, &ifname);
> if (ret)
> return ret;
> ret = if_nametoindex(ifname);
> - if (ret == -1) {
> + if (ret == 0) {
> rte_errno = errno;
> return -rte_errno;
> }
> --
> 2.11.0
Thanks,
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check
2018-06-27 11:55 ` Nélio Laranjeiro
@ 2018-06-28 6:39 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-06-28 6:39 UTC (permalink / raw)
To: Nélio Laranjeiro, Adrien Mazarguil; +Cc: dev, stable
Wednesday, June 27, 2018 2:55 PM, Nélio Laranjeiro:
> Subject: Re: [PATCH] net/mlx5: fix invalid error check
>
> On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote:
> > Since its return type is unsigned, if_nametoindex() returns 0 in case
> > of error, never -1.
> >
> > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC
> > addresses")
> > Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx, thanks.
>
> > ---
> > drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> > b/drivers/net/mlx5/mlx5_ethdev.c index 90488af33..ebe5cb6e3 100644
> > --- a/drivers/net/mlx5/mlx5_ethdev.c
> > +++ b/drivers/net/mlx5/mlx5_ethdev.c
> > @@ -192,13 +192,13 @@ int
> > mlx5_ifindex(const struct rte_eth_dev *dev) {
> > char ifname[IF_NAMESIZE];
> > - int ret;
> > + unsigned int ret;
> >
> > ret = mlx5_get_ifname(dev, &ifname);
> > if (ret)
> > return ret;
> > ret = if_nametoindex(ifname);
> > - if (ret == -1) {
> > + if (ret == 0) {
> > rte_errno = errno;
> > return -rte_errno;
> > }
> > --
> > 2.11.0
>
> Thanks,
>
> --
> Nélio Laranjeiro
> 6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-28 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 9:20 [dpdk-dev] [PATCH] net/mlx5: fix invalid error check Adrien Mazarguil
2018-06-27 11:55 ` Nélio Laranjeiro
2018-06-28 6:39 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).