From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 3F4BA1BEDE for ; Wed, 27 Jun 2018 13:54:56 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id u7-v6so1733945wrn.12 for ; Wed, 27 Jun 2018 04:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xkmA/QwkC35eCdBJ+BSCgZXgbnLoIHlkdIAjv9XeeHQ=; b=tkzALoDgs8qruBg+SbGFx23/ggM8o0qm93NIZASSDUmT+xyyI6EEa32XjzADK2fRjE a8Q/L052nn54c00BWzGpkuscaROmerzt2/XNKarJ0QkXXBt4n5sm3MOshI8/iDVHJz4Z GvCciO4ElWRvmr8tB79+H7HwfczHfNj8ViExuoV91dQ1x02KLW00vsjgybre7BJScXXz mLqnMb5gxno+gYsRwRm6rCZdNqS/mc4TTd7/vFufIV179EijJzLiQTctW50HHyihoE/R V77Hj1IzovDE49SlMFzu/GwjSXaX6A4HlnUKYT141ixGydtJ/AJz/BoXHkieQPbMTfR4 3yMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xkmA/QwkC35eCdBJ+BSCgZXgbnLoIHlkdIAjv9XeeHQ=; b=fDym2NCxUNQtl+bJ1LjqAM5uOxgNcRbbXCSlae7QK8EU97zRDXgkp7tgzNoCUwH1Zk Xed/ZPG34DDLGPlcBOlweRSB8dr5zyazyRyBP5vC0ZHgcwvGfX9dwd+2IS3RF+6wrDRw aX7bU4pF5h024oof+CfwY4vo3cUDEPz8Lfigu/+FkqAhSGcC6MQRQeoOT7Yr7y0B4Cyn jcq3h4Es1d2MtpwqDajDQEclGWScWS5/h/npnvp27smRQrgS8aO8mzbAgcpjuNa2ShJp oNoVwq9FCEIc7sXTE1z28V0OZ/X+/D+BARbhJS0HI53QtHg31T3s/A/x6jIBd9F9EbCj OXyw== X-Gm-Message-State: APt69E2hbb0exzX6OOtPNAaHrB/tu24nkBQjpmRzqMKd1IBGLrb5Dxr7 GttPMuk7D0AoOMAv1IhVwIYc X-Google-Smtp-Source: AAOMgpd2cxNYgTX1X0+j8PJYqjqnMqo0STLmQyYwCENU+9tcqENZxoXnMt/wq0/3ncDnvvBb4OjD7w== X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr5125278wri.146.1530100496044; Wed, 27 Jun 2018 04:54:56 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d1-v6sm1932005wrm.9.2018.06.27.04.54.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 04:54:55 -0700 (PDT) Date: Wed, 27 Jun 2018 13:55:22 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: Shahaf Shuler , dev@dpdk.org, stable@dpdk.org Message-ID: <20180627115522.dvxqrbjugasfsmbn@laranjeiro-vm.dev.6wind.com> References: <20180627091909.22689-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180627091909.22689-1-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 11:54:56 -0000 On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote: > Since its return type is unsigned, if_nametoindex() returns 0 in case of > error, never -1. > > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Cc: Nelio Laranjeiro > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 90488af33..ebe5cb6e3 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -192,13 +192,13 @@ int > mlx5_ifindex(const struct rte_eth_dev *dev) > { > char ifname[IF_NAMESIZE]; > - int ret; > + unsigned int ret; > > ret = mlx5_get_ifname(dev, &ifname); > if (ret) > return ret; > ret = if_nametoindex(ifname); > - if (ret == -1) { > + if (ret == 0) { > rte_errno = errno; > return -rte_errno; > } > -- > 2.11.0 Thanks, -- Nélio Laranjeiro 6WIND