From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 5F8F32BF9 for ; Thu, 28 Jun 2018 18:09:44 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id p1-v6so6088578wrs.9 for ; Thu, 28 Jun 2018 09:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+knoPc5sN4j8RG6Chy24F38JTtLyRO9lAvb/cTSP+ks=; b=hRFYV2+yrzEpDe4aTcu8ViyOcSVCz5XD3jdEV9RwmmtEQUfHXKt7GJyGETQmVFpF3r KvtHVe5uMOEMpWRbgNIwVSh0Wb/xcIXBfIXvAFtD/JyqedUkm0BIGgiU2L6lV/5bNSEM l3OuYiVjSkaIZNmb/WlZVgFT6IJ13O2a7Z2h7zYxjKnOQAQirHtnEhODVcghnrO391i/ //UDjiGr/CVJGgciJ+LrWKQw0VpmJQD4cskdBolhsU3tOLxmk5qF1TDITw9qDh0GlS6e 2aZ009FAvuDnzMZ/L+OCLKvnE8rn4zz8UZESQSQWKouekXXBx/h15Tv+ZivdcuLXq8pP PLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+knoPc5sN4j8RG6Chy24F38JTtLyRO9lAvb/cTSP+ks=; b=I4r6UFaX7r9vdl2n5uF1WBqfMvI7jH9ahz7RHlN6tU3mQmD/zVKcWO3a+LQrlLNcoa 31JOvmCQ/DLwstgXnUtAeJOO7JSsdOT7S4RNaQ0DFiNN8bZY9G348QudNH0d7C7NRO7m Cfquj1a8SMWHdY7Poxa6nU5KYCwsiaUkQU+T1PLRmioUOZdG0p50IhC9h9+l8t0qUiI2 3RcFMCcLD+96q7DcM1bJm+szi7qbCuTQnZT4lcNG5QtLgB51xREMu03UFzWHT8AqH71O v2LlO2k7cnyug9dDVtQ5ubVKR7QmBEV6zS4eDOjI3j+eL/MlMey7p0aWDswQvha+giQx H3ug== X-Gm-Message-State: APt69E1WZ3L3F4cscdDQeZ9x1lMjsrnwBb288us78S5xrp+S8njxK8Eu wFvyBf9bHsAa0P5Qv1r30bwicRay X-Google-Smtp-Source: AAOMgpeJnrhnqmZt40VBO1joTD6Hj/+eg0WT9vSpCvTEZWz70+DYnZyVGVwoXyVrDxG2XzSnDe0DTQ== X-Received: by 2002:adf:b782:: with SMTP id s2-v6mr8999757wre.247.1530202184146; Thu, 28 Jun 2018 09:09:44 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s200-v6sm2130484wmb.44.2018.06.28.09.09.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 09:09:43 -0700 (PDT) Date: Thu, 28 Jun 2018 18:09:27 +0200 From: Adrien Mazarguil To: Nelio Laranjeiro Cc: dev@dpdk.org Message-ID: <20180628160927.GI4025@6wind.com> References: <20180627145525.8659-1-nelio.laranjeiro@6wind.com> <2b29e115e43f519e2cc2fa1a075849f53c7bf92a.1530201647.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b29e115e43f519e2cc2fa1a075849f53c7bf92a.1530201647.git.nelio.laranjeiro@6wind.com> Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add flow API to expand RSS flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 16:09:44 -0000 On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote: > Introduce an helper for PMD to expand easily flows items list with RSS > action into multiple flow items lists with priority information. > > For instance a user items list being "eth / end" with rss action types > "ipv4-udp ipv6-udp end" needs to be expanded into three items lists: > > - eth > - eth / ipv4 / udp > - eth / ipv6 / udp > > to match the user request. Some drivers are unable to reach such > request without this expansion, this API is there to help those. > Only PMD should use such API for their internal cooking, the application > will still handle a single flow. > > Signed-off-by: Nelio Laranjeiro > > --- > > Changes in v5: > > - Replace the struct rte_flow_expand_rss field by a flexible array, > - Address all nits. Acked-by: Adrien Mazarguil With just a couple of tiny nits, not sure they're worth a v6. See below. > +/** Node object of input graph for rte_flow_expand_rss(). */ > +struct rte_flow_expand_node { > + const int *const next; > + /**< List of next node indexes. Index 0 is interpreted as a > + * terminator. */ > + const enum rte_flow_item_type type; > + /**< Pattern item type of current node. */ > + uint64_t rss_types; > + /**< RSS types bit-field associated with this node (see ETH_RSS_* > + * definitions).*/ > +}; Multi-line comments should have opening and closing tokens on dedicated lines. > + * @param[in] graph. Extra "." -- Adrien Mazarguil 6WIND