From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A24B31BEE3 for ; Tue, 3 Jul 2018 12:07:50 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 03:07:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,303,1526367600"; d="scan'208";a="54076732" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga008.jf.intel.com with SMTP; 03 Jul 2018 03:07:47 -0700 Received: by (sSMTP sendmail emulation); Tue, 03 Jul 2018 11:07:46 +0100 Date: Tue, 3 Jul 2018 11:07:46 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20180703100745.GA1296@bricha3-MOBL.ger.corp.intel.com> References: <20180608163807.66737-1-bruce.richardson@intel.com> <20180608163807.66737-7-bruce.richardson@intel.com> <25eed419-0786-d92d-9aa5-7d8bf7c0c349@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25eed419-0786-d92d-9aa5-7d8bf7c0c349@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH 6/7] examples/kni: fix dependency check for building with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 10:07:51 -0000 On Tue, Jul 03, 2018 at 12:47:18AM +0100, Ferruh Yigit wrote: > On 6/8/2018 5:38 PM, Bruce Richardson wrote: > > Rather than hard-coding the example app to be built only when a set of > > conditions are met, we can simplify things by having the app built when > > KNI library itself is available. That saves us duplicating the same set > > of restrictions on both library and example app. > > > > Fixes: 89f0711f9ddf ("examples: build some samples with meson") > > > > Signed-off-by: Bruce Richardson > > --- > > examples/kni/meson.build | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/examples/kni/meson.build b/examples/kni/meson.build > > index 0443ab99b..41b87f8b3 100644 > > --- a/examples/kni/meson.build > > +++ b/examples/kni/meson.build > > @@ -6,9 +6,8 @@ > > # To build this example as a standalone application with an already-installed > > # DPDK instance, use 'make' > > > > -if host_machine.system() != 'linux' > > - build = false > > -endif > > +# this app can be built if-and-only-if KNI library is buildable > > +build = dpdk_conf.has('LIB_LIBRTE_KNI') > > s/LIB_LIBRTE_KNI/RTE_LIBRTE_KNI/ > > Same needs to be updated in drivers/net/kni/meson.build too > Thanks, good catch.