From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 79F775B1A for <dev@dpdk.org>; Mon, 9 Jul 2018 03:29:03 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jul 2018 18:29:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,327,1526367600"; d="scan'208";a="214388465" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by orsmga004.jf.intel.com with ESMTP; 08 Jul 2018 18:29:00 -0700 Date: Mon, 9 Jul 2018 09:28:48 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com Message-ID: <20180709012847.GA5859@debian> References: <20180706070722.2043-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180706070722.2043-1-maxime.coquelin@redhat.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v9 00/15] Vhost: add support to packed ring layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 09 Jul 2018 01:29:04 -0000 On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote: > This series is a handover from Jen's "[PATCH v4 00/20] > implement packed virtqueues", which only implements the > vhost side. Virtio PMD implementation will follow in a > next series. > > The series applies on top of previous reworks I posted > during this cycle that merges mergeable and non-mergeable > receive paths, and refactors transmit path to re-use > vector buffers. > > I haven't run performance tests for now as the Virtio PMD > side isn't ready. > > The series has been tested with Tiwei's series implementing > packed ring support to Kernel's virtio-net driver, and > with Wei series implementing the Qemu side. > > To test it, I have used testpmd on host side with a vhost > vdev and a tap vdev forwarding to each other. Transferts > of big random files have been done in both ways with > integrity verified. > > Tests have been run with Rx mrg ON/OFF and events suppression > ON/OFF. > > Tests have also been run with legacy split ring layout to > ensure no regression have been introduced. > > Changes since v8: > ================= > - Fix indents (Tiwei) > - Rename struct vring_desc_packed to vring_packed_desc (Tiwei) > > Changes since v7: > ================= > - Align structs and defines naming with Kernel header (Tiwei) > - Fix event based notifications (Tiwei) > - Fix Clang build issues caused by unused symbols (Tiwei) > > Changes since v6: > ================= > - Various style cleanups (Tiwei, Jason) > - Simplify event based notification (Jason) > - Build support with future kernels (Tiwei) > - Prevent buffer vectors overflow in map_one_desc (Tiwei) > > Changes since v5: > ================= > - Remove duplicated VHOST_USER_F_PROTOCOL_FEATURES definition (Tiwei) > - Fix vq_is_ready (Maxime) > - Fix local used index overflow in flush_shadow_used_ring_packed (Tiwei) > - Make desc_is_avail() a bool (Tiwei) > - Improve desc_is_avail() logic (Tiwei) > - Remove split rings addr NULL assignment in the right patch (Tiwei) > - Make buffer id a uint16_t (Tiwei) > > Jens Freimann (2): > vhost: add virtio packed virtqueue defines > vhost: add helpers for packed virtqueues > > Maxime Coquelin (12): > vhost: clear shadow used table index at flush time > vhost: make indirect desc table copy desc type agnostic > vhost: clear batch copy index at copy time > vhost: extract split ring handling from Rx and Tx functions > vhost: append shadow used ring function names with split > vhost: add shadow used ring support for packed rings > vhost: create descriptor mapping function > vhost: add vector filling support for packed ring > vhost: add Rx support for packed ring > vhost: add Tx support for packed ring > vhost: add notification for packed ring > vhost: advertize packed ring layout support > > Yuanhan Liu (1): > vhost: vring address setup for packed queues > > lib/librte_vhost/vhost.c | 115 ++++++- > lib/librte_vhost/vhost.h | 130 ++++++- > lib/librte_vhost/vhost_user.c | 127 +++++-- > lib/librte_vhost/virtio_net.c | 776 +++++++++++++++++++++++++++++++++--------- > 4 files changed, 939 insertions(+), 209 deletions(-) > > -- > 2.14.4 > For the series: Acked-by: Tiwei Bie <tiwei.bie@intel.com>