From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0075.outbound.protection.outlook.com [104.47.33.75]) by dpdk.org (Postfix) with ESMTP id 9E3CC1B460 for ; Tue, 10 Jul 2018 12:07:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrFyZGT/JiXuTna6n6MniVawbPnh/Q9sF/H2QUjgA3I=; b=QvzdzeCZ2Izefoup6VoAnpJnUywDuazECp7xfMhmEQpS1jbZTVGixuTNO5Act2Gbe5mPKybg5Cl3VvvGA1BP5OiSVCFRmedqcibDR6prNBlBxV/jDzSaSihjQ0h9+6EofFXz6Yea5DmgyDzgV40X5uHpT1rxr8kKB66EgdyG+aY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by BN6PR07MB3460.namprd07.prod.outlook.com (2603:10b6:405:64::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Tue, 10 Jul 2018 10:07:45 +0000 Date: Tue, 10 Jul 2018 15:37:27 +0530 From: Pavan Nikhilesh To: Shahaf Shuler , "jerin.jacob@caviumnetworks.com" , "gaetan.rivet@6wind.com" , Thomas Monjalon , ferruh.yigit@intel.com Cc: dev@dpdk.org Message-ID: <20180710100726.GA30393@ltp-pvn> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0001.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::11) To BN6PR07MB3460.namprd07.prod.outlook.com (2603:10b6:405:64::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e897f5cc-70ad-4573-03ff-08d5e64cfc87 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN6PR07MB3460; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 3:eAzPsCheiOz5ZnJnnM5Rtb6CNGRcOwserJqPDPApIbneCOHQfBpemGgasQCYVn4ZWc3FPhM/2UXPAM7+D0jjiD7R0UeDwaIy7nCW64YlCFj4aMCu9NmW9eogBVg+q8HhqDZFgRbK4TkiF2T6fn9+rzy/CxBFlVBxAq6RnSEtCp2DB5pCiFGTLxe9LwzYSYuIBKR3eRmv2A5vRXQz525QPWahZW0+okyWSJPFmN41y7EzQFYVzX/2AnVM7hjZRNuT; 25:F/fxn+oynCmCTM0VEh/fnybXKvcY1y2j9O6QCdPiNzTabhUcNJkjPa5KustAK7cov46Mzhosytzy72ogXakB42fikL7Zrf5QUwNnbIfFbW4rQpfEaann/zrvcZjZZvfllrwV6PDbf2U5+YtIbPj/DuqUM1nGZbOtVMVExlJ7DAlCUBEKFjM0fVozgdN9Ra6FT9PvbBml8ahSMvQpO2S4iGyEq465q/kmtNHVlydpaYME+NTBiX1v1vY5UoBI6aFsmlPYh5Rxm1VvC/Ek5tmqREp7s7QIa4J2TAtJp9XCUJO9TDq1JtgVryYr9+LijX6z99RFNYpI0+9h+Ypx1BI9yA==; 31:dZDUYWa70DvGeNbUtrIeO2iuHRoBLz23jrxl0ubCSWYJgmoi+RJBWaAUJib/EmCjUctUBcsmVinz/Ug5YqzEUWPxS50NimCjW1/pfCYRG/rnV+XrFqyN0Us4vwxlxj+kj7i2ecSiXZpw1OOV128ArXS7oHd8YCDdcMuO0gV/D3I+vgkNtENqczuvA2PbNcNIpTZkI5zL4ijH+ys/VRu95eUsAISBl317cLED551P1Oo= X-MS-TrafficTypeDiagnostic: BN6PR07MB3460: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 20:U7xsqbZSzUUULpUVJ7ZpS/3xMwOxTD1BkEFmHG8CVvV64Sk/L8jgbvzrIS1ry6c9bOrQsdfovwlh+TouebH4pm8SCqdZthVeud6WJ3gKtyHglazt9u7pRJj5FDQuDyQzjav21iw4cIwVdK0Ob/vcEf8dZhRdNtOKObNsm8N7lJJER4L2IC3CaxbIOVPvNWrWO8Gc25nhDbNjv19UKHqNLQqamgi89Pq5D6C9rjFJ6wt8p8Y8QbLFRr+BPGi43MLYz7/y4a2V5QjrExBHgwpGskZm6srNo2FPtGNEebx/3IKWGaGWD34FDhUymAQxQjMApcRq+ce+OvtJI5BXYMEnndPJfljZy6Di66FcWNPTXHxLj8DTK2QdQnqaSSr2XqUdY+z58j6Z18fab97uOQz5lmz15guOgXcvc08GSg4zUSeJL0rGTNvX4hbB3OQjPmQLVQyOjGJUrsWYGuhgyTgh08hKyUfLjOONZK1H3yLWnQJkeHkE6jUWLe/i3T0I81GpSkIO5whzmpzHy1z3+hO8/RFFWENr+2MV+ypcyBWJsuFx3F1st6ZZH400d1q8Kp/MIU5ZffhTSaw+XI4DcWo8pSiW/cq8m61bmBuNzSZqtKM=; 4:NP+l1HOd+KCHMvhGPve2pTZgv6w4jkHUWx8jU6OredHTjzG6FaLn4MrDLasB8ZVP4rpzhoP1n3fV4xga1ZJwlLUcYw9xCoBWJXgJ5JG6hTFclVRqDkfTcH1sOFujrwpShWDkY9eHWX2ePHJHZ0hCh7uD8RE91qzuVt5PI1oHog0+SHf1aXqSXACW+6RSSlDa+hhevCo9u0/yGyVNWH4tGQ9tRlZPp2w9OPHnlO48ezEtGGbIT/2p7ZfDb7mbEs3v/iJ8CVeDhWkMpOwG6uerUw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(93006095)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN6PR07MB3460; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB3460; X-Forefront-PRVS: 0729050452 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(376002)(136003)(366004)(39860400002)(346002)(189003)(199004)(76176011)(66066001)(47776003)(8676002)(6666003)(16586007)(478600001)(105586002)(186003)(5660300001)(316002)(33896004)(50466002)(97736004)(55016002)(110136005)(72206003)(14444005)(4326008)(16526019)(58126008)(9686003)(5009440100003)(6496006)(68736007)(2906002)(52116002)(33716001)(386003)(3846002)(33656002)(229853002)(106356001)(26005)(11346002)(23726003)(81166006)(956004)(81156014)(1076002)(53936002)(476003)(25786009)(6116002)(6246003)(8936002)(2201001)(7736002)(486006)(2501003)(446003)(42882007)(305945005)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3460; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3460; 23:t5oZI0bk2FnuH4wf7ScDVSIZwBhxypfOO/edD4d+G?= =?us-ascii?Q?j7UWeI8lGjKEbvObLjVbVp3+1kU5ATlCwsbE6hsh7bGZl/fW1cVUQpTyJWyp?= =?us-ascii?Q?JBLQufOj8l4/Fn4XqvVoq0GGHrQG/8I2RqbgYhAnlyjcQViy3+lm5TJMAHVG?= =?us-ascii?Q?DXxSFE8BKaLYyiELslaPc0L8KdcbyEs41vi9FPV1+KHVzfEhExxg0YEj7haR?= =?us-ascii?Q?kSsEzSMOPfwJ/vzyvMBi687znv1x13ofkoN1+u0h877634pWs0IxO4p3mg1I?= =?us-ascii?Q?+xneBS+Ej+n2eHO2FkxUZ8vI0v7/gmlup4GwGaD4jj2wCbvRRIRgRtRjdrUS?= =?us-ascii?Q?fwQLqivtqmI8SYcwDTIBgzZxIps/cjv0oStJnCqWVvPERuSnPHOXw0Ys8Fzb?= =?us-ascii?Q?F2V78QTGy2Qd3gzqet5tddyWutPwd5uob9BgpuIz4ULq9wdS0XQR/x7lD/D/?= =?us-ascii?Q?xpMzhAgYL5etI+gx3FVZLAY0HknmLmGgn5flo8tqXi2XgC0fupI8PFwCBOgR?= =?us-ascii?Q?T8YnFNvPsf4NwzrBsYRlEAE7OEAc81m8rDZcJcpljPPlpY7DDIxobybn5Upt?= =?us-ascii?Q?dZGq2PVYNUl0BTWg0sJBE3rjMpf0vwNl/vd2OJbWofMqT8m47wlQx6DNWFKB?= =?us-ascii?Q?wnLh6AHMzPNUF67w26Hiz9OBuD3/+0YDXh7jO5yuFHaDSpjG//T5KEA0jyhd?= =?us-ascii?Q?fpvCrvlBCXRNhSxEVWH6fpA9h+oHLtmTvW5T90SkHPWYrcK5XeExCd2F08wY?= =?us-ascii?Q?E4fv4ol6ZjGtIf8j5KS9h2RQ26s1lOFxq7HVczA3eso976slLw9teIPyb8H6?= =?us-ascii?Q?VhNHd5tV9BGLq4rjCepxAoSEFwG1JZS/R3St9j1IOwq8U/0/yEq51k1DqIX8?= =?us-ascii?Q?KlgtoM6C332L6pkLyFg9CfJlA5BVxbmQCTijl6KlYC5qQBaSAGtKoGKQgVX7?= =?us-ascii?Q?frqwx9trDEYXbIfG7lmRRpa/WyDbjQh0yYU0HzSEEzzenbGvVHDUgSyor0LB?= =?us-ascii?Q?edVTjXLpehdFsIAA9Mme98ex3scL1Wckcl+s83qBhY6jfWPmK2Haikk3WEI/?= =?us-ascii?Q?M40qMsc9dAO8pFMkh9anLyQda3PhLNf4upbPzR95qty2Uj9u07vtxuXN54bt?= =?us-ascii?Q?hIac/O6S/OSgsQX7rVvD9lVPLgsG5uTyvwRBJLC7XOejPD7PUyQlN50mACBz?= =?us-ascii?Q?d01mgoqH8OkCr16PWDm6+yKFhjYHdz3L8SZekWXzEIieKCSHQ0+hDXbCnfwa?= =?us-ascii?Q?lxF7Q8bQqR2rnB5HB2mKSmGH1k7N8aF6n6bP3oMaN2JucPtug2Sy3c/nMSVt?= =?us-ascii?Q?/cV+kaJvKvs8hTfQj76DDv9zGWMGL2UV6J0yrv99nq2UV730nJRvA/B4J0Pw?= =?us-ascii?Q?RKQjI2+51x2+g4xLre3hVfUldFpE19TIuD5w0Mf80KJ11paHUbm+9YxWu2e9?= =?us-ascii?Q?890MBfGJQ=3D=3D?= X-Microsoft-Antispam-Message-Info: V3OdUqZw/1Et6qu5YG6821s90wRK3v+04tmpNMzzEN1Egovul64/zLLuhPY/KDLcuaqJOedVdRKofx8RsaCXjH8lYeo08By4Sq0cHg2wHzG0LWBF572BkVA7bF4H6nER4x2pF4Zo48DL4WC9alGTu6h99F8tdl5jN12wOaE7KeiRvVFuZZcOSYmF+QRZRiFLlzV21jzkm1BNhBy+cjGzhUo0tPj6mcWswmcALFNCcSEV0kI/HK8VGCsPH+WC/E/EUhdwnIpRnET3GBF+xF3V04u5JO6gkIrkkpcN9CZOsPRmiqrGAwoTRA8YRZnrVlLMBwYW4eINSpevvLZ/wM2K8gGkvrZj+jhdSI8nrQJPba0= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 6:Kibi8rQXkPheMFsJlfLdzoOkEhRcqkoC0JnU9TwbrhJrMJD/ht1C1aOrIEv9LaaFywN7cFcOm/KrSTdFX7oeYM24Rwk62JJx04B+pQc6lfoBc1gN0ncDOdJFJ/QScJfCvzqI8fIWKWG5DKjHHnno/C+oqbTuno6PJvjv7TNSGcZghxXkW25nWSrHM5lq3vv0UZrZxGx5RqRvttm1Mx1fqMKnoOUYuZSrvXxyyXPBwO8YNX3yy33fPW2DwAHfGIjYc18szQlcGcv/+CH0k7p4Xoe2aUlZAFNynyv65str4q9zbMEBL22zCzZQvvldXEUJhFE2K5DBDQgaKun4BuKd6yrZ0mZ4450LL8Jmswb4P9Nz7Oekg/d+v6Wbbf4lEY9tNrYHceHjnu26XZZXnE2xyCzWeQeoVP8q6srRDXAuaPEBD7IpEZbQLa+32sn+avepi0mZnqjLz6qOuOzDc1bRog==; 5:mp8qqBvvRFwCQygJo1xMitp+YHWCviyVmOX6txaUVEQqC/Xl+s/BC438Ov2TzuOABcz0/0e5lEzPwJ8uG7S/NQ9tAd3Lvnm8j/0nClH2LPWMdXRz+bMIOM9LYwmLFphLD1Bf6Qk66F0jKCJcPV68pLP26so/gXj7BdogTkzLqOM=; 24:SkQx8TkjK7UCJw3bEeMSxN4O3raoR/dsg2W6KDDMuCHaCqDqiMfoBSAWibV2Ugvk1xjp2lQL9dDLMvAR802qiKdU0AT3tHZxnyLjz6SLAfg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3460; 7:S/GSNPFr/N8oiP1eThlfECeptFhRou/1EPWkezVCnbo8unTzTEgSAZEMEHr72CxnrxEW3qUVSdo/dorvBwUIjgnkcQoHlV2W9ctEhKtL/QVUuM5kSTNPrVvYce2OU12ipvXXUgLxb0aJJ9Lgx1nJFDxYgmo+mLMRZmvojdC78fAVate1mneBOvVAbIUYGMPHWLHrbdtdx7KEEDM7X4CzrfrODbCxL7yrtyJKxaxVZVXhuTQlbScL6dVJeaPi4uWA X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2018 10:07:45.2860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e897f5cc-70ad-4573-03ff-08d5e64cfc87 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3460 Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 10:07:50 -0000 Hi Shahaf, On Tue, Jun 26, 2018 at 12:48:49PM +0000, Shahaf Shuler wrote: > Hi Pavan, > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > args > > > > Currently, the only way of supplying device argument to a pci device is to > > whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > > as whitelisting a device has its own side effects i.e only the whitelisted pci > > devices are probed. > > > > Add a new eal command line option --pci-args to pass device args without the > > need to whitelist the devices. > > --pci-args 000X:00:0X.0,self_test=1 > > > > Signed-off-by: Pavan Nikhilesh > > Tested-by: Shahaf Shuler > > It seems to work. > Please see small comments below > > > --- > > v2 Changes: > > - Document the option usage in eal_common_usage. > > - Update commit log to be more informative. > > > > lib/librte_eal/common/eal_common_devargs.c | 3 +++ > > lib/librte_eal/common/eal_common_options.c | 9 +++++++++ > > lib/librte_eal/common/eal_options.h | 2 ++ > > lib/librte_eal/common/include/rte_dev.h | 1 + > > lib/librte_eal/common/include/rte_devargs.h | 1 + > > 5 files changed, 16 insertions(+) > > Should we also update the manual of testpmd (doc/guides/testpmd_app_ug/run_app.rst ) for the new eal arg? I was wondering where exactly this has to be documented, Thanks for pointing it out I will add it in the next version. > > > > > }; > > diff --git a/lib/librte_eal/common/include/rte_devargs.h > > b/lib/librte_eal/common/include/rte_devargs.h > > index 58fbd90a2..78c600bf2 100644 > > --- a/lib/librte_eal/common/include/rte_devargs.h > > +++ b/lib/librte_eal/common/include/rte_devargs.h > > @@ -29,6 +29,7 @@ extern "C" { > > * Type of generic device > > */ > > enum rte_devtype { > > + RTE_DEVTYPE_NORMAL, /* Normal dev with special pci args */ > > What is "Normal" device? Can we find a better name? Maybe something like RTE_DEVTYPE_PCI would fit in?. Let me know if you have any suggestions. > > > RTE_DEVTYPE_WHITELISTED_PCI, > > RTE_DEVTYPE_BLACKLISTED_PCI, > > RTE_DEVTYPE_VIRTUAL, > > -- > > 2.17.1 > Thanks, Pavan.