From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Pavan.Bhagavatula@cavium.com> Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0046.outbound.protection.outlook.com [104.47.33.46]) by dpdk.org (Postfix) with ESMTP id B64BD5F3B for <dev@dpdk.org>; Tue, 10 Jul 2018 12:20:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Hze5mEQf4sgb/MlYnOPWp/Ki4uXmJ+kBvMHoXS14JE=; b=UrfrTWBP9zP0hY5zHXiVeRcaYBA1GoFQMdk2fKinr3bfC2Egs/3YQTHHlh3d2uWw0viYWjRwPQpbpbRO3L6D/jSTQqwTC2Qt2t9Scw3UiVX1aFBtSeJStJ8As77+lIo1Q7MgIy1jBXV9+5ywbfsEa+xAbRk/z8xgbR5gTbpft/Q= Received: from ltp-pvn (111.93.218.67) by CY4PR07MB3463.namprd07.prod.outlook.com (2603:10b6:910:75::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Tue, 10 Jul 2018 10:20:02 +0000 Date: Tue, 10 Jul 2018 15:49:47 +0530 From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> To: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>, Shahaf Shuler <shahafs@mellanox.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org Message-ID: <20180710101946.GB30393@ltp-pvn> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> <DB7PR05MB44263B4166F9091A0719B7B3C3490@DB7PR05MB4426.eurprd05.prod.outlook.com> <cd4dd9fe-d5d5-ebbf-0738-bb3dfcbd2da9@intel.com> <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com> <20180627085529.GA14236@ltp-pvn> <20180627095736.jty7lbqesxufwiby@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180627095736.jty7lbqesxufwiby@bidouze.vm.6wind.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0063.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::25) To CY4PR07MB3463.namprd07.prod.outlook.com (2603:10b6:910:75::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a3b7adc-be47-40d5-35ff-08d5e64eb443 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3463; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 3:vdifZbn/8iZ6cJxcPjUkihv2GtclaEcPa0AzCobKwMIq1ieRkzFhXHQdNmDH0LBAAs70tAbXsCLDSHCHmFvSVJWeK3bL63bVsXe78mdnnB7fKsfJsEHmA4kGlejQadi0XuPgiuqEg6Am7AI64eEUiz6ZwKmDgfk+hQ/W30gsRGbP49yAre7l6IUmMCIW3wk3UEqEwVix1kqhQ6kg97tvTF8gtjhrlVy9/qFHN52EnYnDaW4Pi4B/ovAsj1cxpS+u; 25:8h7y/DyDiaXLRxwaV88/1rGbxQY+/wjPWOsMbZPtrs0ybPLDocZNSn+6afF+LRasTSLopyF84C3BnIdfXyrIHvgEEKfqESn0wbA19toLklqSJ75qTILr1XOCGYbPP1uiC7ptS4i/8xthZPQ8MyjfSJ+l+sR94QCdvQyelvgSHzQHtK+d6SqPUsTZO8Sk4GevokpA5octZww9S47ZXvyuDwuqyvXEW9FLcESffNrUIDcQ2+jxqc9dwGrZlqPYCIryqLDGChpgU2OKPdZilNVHJe+yM16cvG9AbgXMll8+m4VgaI+Rg0xtQjnTtUlMToVqHOpJEeTPRnnz3k7oR5bflA==; 31:pcSTIAmnCepi+MqnbxA95vUPl0zvC1eLS5vtYtqEtSmOmg2zN9tSq2OQOnG/XiGTVbBJgoXXbVQZ7dZHmaePL79ho1ycYsgDOj+NYM0eoFpoMVpiP1hqNvK77xc+JS5nE91xMwhoyy6ToH3X9wPY4s86ZznuTlJkG+t/FaILbpbPF+BeJh8aDYf6VHR3gpdkZiuJgxVtZQHCnbt3JC4wvdkraJyaD0jQlhOr8NACe9o= X-MS-TrafficTypeDiagnostic: CY4PR07MB3463: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 20:jM6lYMlQ+1Nq9BLGR/IH3b9tTR0Kdwh3IwoA25ka+oYHI93grkAr0vew4JAY2Z35B/mvRlLJUu3KDEJSjwgjVeH053beGjzQHsCj416n+pdI0WR+Yiq8hNkKDOj97fghSdRqNwAN2dUldkQwEGtVPxleuXGcOqJOM+0VeZ7H/PMZJ7ooCFU9ZPbzreFVgamUygUHSm+V8kfv8ZUNvONdRBC6Riy93uHy6R12Ijak1v0bo3vXXEQqRgouYKGb9a21QIkvAuKQlIAO/36W0UhljKHQJLVL4AFbt9tmaSuB3R0C8IX8vXD1jkbUKwfVoa7/yUHeHzzv/o2x811L9KY6TyDuaQOWfCioqUC0T9PFJaq8E+GIE8bY9Wgmv/B8gqWrb0Bc/iLhtlIcxtL395IsFNz42UGcncHHCJ623eL/HhxWPMIGBI9QxVhfcVgl2TnvSqCaitw3PdLi802rlwtPLSyfi2vARlbWUfpq92RJnolRtUvrhJ7fBztoSXv34u1XFdZwul+s7p9UGpMOLB7NWDqxp4n7ZNE1UjFaxWthaBoVRb+vWBALVtp4uTpm1mRtVzYcu8jo75C63+nZIfhHom6OalobX1ivF+4Z3oDXpU4=; 4:8D1bL5OVTqk4JvsqgdbuOZdn5v27JWT8dnqMKlLsJqLmNtK00hkhAieKAOfWSbkh3l1Hji3F+E8ORMPRKVgS9fJ4UmIPMahpWdmhvryQbhrF49K4a4SovuJ+WVWg/Uz8n4qZ6HuakGD94b2SHxjAx4ew29d95Q/AX89yWYsKegshQpt4YxEIQrZNYsdufw5JeMcjwmlOApJD+f7K8yhbH3v64rRMRBn66V3seGabDAnwz9tsI9fEZ94MOmHIyEqX21Z5zKdU4SuTtw79SC42gA== X-Microsoft-Antispam-PRVS: <CY4PR07MB3463A5BEFD11656770766AB2805B0@CY4PR07MB3463.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3231311)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:CY4PR07MB3463; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3463; X-Forefront-PRVS: 0729050452 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(376002)(39850400004)(396003)(199004)(189003)(33656002)(110136005)(486006)(58126008)(55016002)(97736004)(956004)(72206003)(476003)(81156014)(186003)(446003)(11346002)(33716001)(25786009)(16526019)(42882007)(93886005)(4326008)(478600001)(68736007)(6306002)(316002)(9686003)(6116002)(5009440100003)(5660300001)(2870700001)(2501003)(76176011)(105586002)(47776003)(53546011)(305945005)(50466002)(2906002)(7736002)(52116002)(386003)(6496006)(6666003)(26005)(1076002)(33896004)(66066001)(8936002)(106356001)(229853002)(3846002)(53936002)(23756003)(81166006)(8676002)(6246003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3463; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; CY4PR07MB3463; 23:0ism8IRYUQ9f4wP1YRKK83R57CfU515iTxNWyxk?= =?iso-8859-1?Q?YwrCghnKeSPcDFDuZeqyldZ76yQu7xfHVKFjftP21tUWscgKBPnPSmWFOr?= =?iso-8859-1?Q?orNqzY0phYrjKa0rp/N0F4uidhMa/Ywj4qccTmlT+Xzqg8n0tRb9NRAQ8g?= =?iso-8859-1?Q?yoFL+VWTo/DFgSEU77onsMbgUB2kC1Dmitr0fph50MdfPxy8hdwDPrZWi0?= =?iso-8859-1?Q?PgQHkDoEOJzDQR2ezBAwQg2yJKc2FFnAQWTlflkVV1+/0CQ9N1pyrwV6Cq?= =?iso-8859-1?Q?1uMHS0JWyvOY3ZKIQoVJHNHnNzUOA9IxgtXPIOcqn1aVT0uRIrLph71ISz?= =?iso-8859-1?Q?BlRZwA/wum2iv2H+DcuVNxTHWEU/4iAhj4O5zZiDo+gtCH8x4KjhpG5xxC?= =?iso-8859-1?Q?/vX6fRRoYlhDWy7UOB7KtYzIv35wLyXRGTud51fyAKYgzSpL1dQuxRUnKn?= =?iso-8859-1?Q?UXK1k3Nqtbr1TxGBVu2PIPkr3Rj3M26hlrv/6JqZ6qIMN32RJ7Pz6DUQ69?= =?iso-8859-1?Q?NdWr3ivtT20AD6G3v1nmVuvjLERzyaaaafHotrr50A4huXCJ2R8uElu3GA?= =?iso-8859-1?Q?8nmkXkyelpgV5cCHj4JYUsgAZ9+Wf/SnMJVYgAKKwXOw/s68ufITk5YslN?= =?iso-8859-1?Q?0R1djV7fm6hKfsm1jVcWb56DuZcUBoXPfxFShHD2I+eP5D9icrY2vJn35l?= =?iso-8859-1?Q?t6Zmr0Pq7oMKT8U+UKpQ7V/DSMlOCpr0WP1SidLgxDmZdKKDy7uNff3/p9?= =?iso-8859-1?Q?+lpplDnRKtLgfgyHgvjO8lVVqslso+ZlxPldAYCWlp0lLZJotjlqiMEi5M?= =?iso-8859-1?Q?KLYVwLczXfaa7MZe4GYfhGccEXV4b323VozGF8ARCCNDOLz2jbwZel0MHG?= =?iso-8859-1?Q?noAOjZ6qs/uXOrWynPO+saWnsrBSAZARvqHNwIC2rzmCGq8g/bGMr/m2WW?= =?iso-8859-1?Q?S83HMCNcVNBaeHJDjsBc1s6S0FJdpyTLavN7JngGFZOXCDdIddRPdSuKcA?= =?iso-8859-1?Q?zUXxEAXE9ag4EXfT5kkFkHPDEde4tWpEXKtpUxPmInPe2NW5OO8WgmHhM/?= =?iso-8859-1?Q?GiTkLSdAe6Yp/QU6ZcFUVR+cQoNLFO4JYITQWMeM1y+f+2bSqWQBpRSZPg?= =?iso-8859-1?Q?E8q8qUPR8A2r/yzTVd5x/gLNlASLZm5Iy1/EuCjx9yFMiBe2RYfqMDB/8w?= =?iso-8859-1?Q?WK0hKfkrgPnmJzsHrezLnvEsGyp60aBLgsnZ6tBmj0aFh0QTihBkkhCPy6?= =?iso-8859-1?Q?dRMWGseE3D/4FrkA1lztv1ILk8Kjld5yVbSkOyob/PRqOjZuStgqNWwtBZ?= =?iso-8859-1?Q?SyX8G8sBBMD+f66nR/fFy4uJ26fd7NblAnP5q/IScBoAzZqfOCZQ8n2ALR?= =?iso-8859-1?Q?d0wAp3yzU6s/H0xpDwxhYAYfoOhdAQAvhAkoB+pt9iyyTZAln63eFxyfso?= =?iso-8859-1?Q?ulIXPx+Sf5344GZALy1w2p9QwlgSHVgz+vK7v3khzduURq6oo2g/hF5E8c?= =?iso-8859-1?Q?1NAWdGz3Mi+v+a04ojxM=3D?= X-Microsoft-Antispam-Message-Info: Om+PTYjBr0P68hBJ4q+F6HOTQLSch4i3q3HrfkaLmAf8M64N7fqAv8+uUc9fqAQdtLqsx8OCWBV4HHfzSLowokdTLZQZq6NonZ6l0YSTEBPA2QKM92fNYIobEvRrljIYDwL3Dnc0iR/j48leVh+z/bCDRRD7s7M7kifRq/9ttbqQmKdDW47kITgp0Kw+eToLurmcuDwrotFg/p77O+pOcc5VfxnSg1l+oMGgXNBvwEtSoR6V45xEEbBj4+TzIM8lyKfPiSys2+fmWZEr7FwG/t1hwHYwaqh3rcrf7RV/X4DarLy8Y77KmWbp1osLvMymMu0fpxP9iSIYjSt4sprawNm4Wk2m2lAHnI44w2tEj+Q= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 6:a1tVHff0jPcit+5/98RDtbVM+FS3vj+hjhJtJrtpDsmU4EQ7dt10JwE+3ACbC857lkrxPXXup80xPuL/lSpSUsWCZ/LkQWegBvNjMhhnHXgdWl1lYZfh7P6hnFse4Y4vjFFxjfCcUvwi8/Oj46KaGme0WNBkzM5Mq1Aw+XNETmul9WAL66UyKRDtJtGRE0vkyRRLLjGk1+Ttutq8n9N9L4/EZ4LiuY243GBKHpqWUrApGmQmK5S+349yKTQyibslCbHmqjVblPHTfCJw7dZY3Y6KmdqT8pFXtzUZy6Ajb2gVNnZtKcX2yvDlY6bdAoVAns76yj9VCayuTpqQTeRWDwZLV9miAKrkiKpnERUA/wb6QFiKu6GGp82QdR/GIPnUdi5PiPSlUfXlQ+9vkGeDSxvISGgsleSq9g56BPSWPYBmjaDCWlOFXj1Fx+2WWdbj6hP2+5Arj5c1vGUFWATKfw==; 5:LVyZ+dPgvrjz+X/EMBYQKSp18YAjC4AOLCEFp9UT583Co+cpK7gCHHvGx0fwTBIbV2Bg7UkaSJyCwHL51T+NwFUeJtcjEhcct0bF78Rp1rtJxDtV43Z4qgd+jAZjK8EH1909DaFE00AcNxPQURYRXNjo9CRX5hQvODGx8HTFYjk=; 24:NU5UX0ETDX2fjFVh/0esIIQ6qgU0rNlq2mMcNY2PrSy7q3rEckUlMMLwbB0VvqVcKqsLwlr7k35+dFzUk/e3fz1Kg5jndeVHI6amwlo1HC8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3463; 7:gmUOzsSsnGo+yeJRoMTqFm10V1x2334z2RGnk8bwelDR+Q3VQRCQp82YVw4isEBpKkWT96admah8fCHNrB0ykArqGcxKcVD2RR7YlDwrEkb9QdKaap3fQPI+0OjMPajRm372inmtnM+zO6c01B1g4O/YqhtExYtUw31jNgKiMVxfcnztWgn5jmTAKGsbQPwPXW0fM4sDn9V2FMjvdDI/SNfNHdwyUhmiUJxYTA52DFrUzMkdA6eEWOrOcYtmtNnn X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2018 10:20:02.5618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3b7adc-be47-40d5-35ff-08d5e64eb443 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3463 Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 10 Jul 2018 10:20:08 -0000 Hi Gaëtan,Ferruh, On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > On Wed, Jun 27, 2018 at 02:25:30PM +0530, Pavan Nikhilesh wrote: > > Hi Gaëtan, > > > > On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote: > > > Hi Ferruh, Pavan, > > > > > > sorry for the delay, > > > > > > On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote: > > > > On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > > > > > Hi Pavan, > > > > > > > > > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > > > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > > > >> args > > > > >> > > > > >> Currently, the only way of supplying device argument to a pci device is to > > > > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > > > > >> as whitelisting a device has its own side effects i.e only the whitelisted pci > > > > >> devices are probed. > > > > >> > > > > >> Add a new eal command line option --pci-args to pass device args without the > > > > >> need to whitelist the devices. > > > > >> --pci-args 000X:00:0X.0,self_test=1 > > > > >> > > > > >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> > > > > > > > > > > Tested-by: Shahaf Shuler <shahafs@mellanox.com> > > > > > > > > > > It seems to work. > > > > > Please see small comments below > > > > > > > > Isn't this conflict with Gaetan's devarg work which has wider scope? > > > > > > > > > > Indeed it does. > > > > > > Pavan, I have submitted a new version of a series adding generic kvargs > > > to several layers (bus, class, driver). > > > > > > It does cover this exact use-case. > > > > > > However, while writing it, I wasn't able to find PCI bus specific > > > parameters, that could showcase the functionality. > > > > The idea of the patch is to avoid whitelising a device when we want to > > supply kvargs to it, I tried mapping it to devargs rework patchset but couldn't > > do it at a glance. For example, the following patch[1] reads kvargs through > > whitelisting which should be avoided. > > > > [1]http://patches.dpdk.org/patch/41223/ > > > > I see. > > Actually, your use-case won't be covered by the devargs rework. > > I am still dumbfounded by how this blacklist/whitelist mode stuff is > kept against all odds. But that's not the time to deal with it. > > The issue is that the two features "declaring a device" and > "configuring a bus" are currently awkwardly merged. You are piling stuff > on the "declaring a device" part to enhance the "configuring a bus" > feature. The feature is very much needed to avoid polluting the cmdline args when we are trying to configure a device at probe (for now). > > Instead of going this way, I would advise to separate the two features. > > If buses could be configured with a generic EAL option > "--blacklist=pci,vdev" for example, then you could provide devargs as > much as you want, the buses themselves would stay properly configured. > > This means removing devargs policy, device types and rewriting bus logic > about it. I think this can be done as a future work and is not in the scope of this patch. @Ferruh, As Gaëtan mentioned this patch is not related to devargs rework can we make some forward progress. > > Regards, > -- > Gaëtan Rivet > 6WIND Thanks, Pavan.