From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 0C0E65A6E for ; Tue, 10 Jul 2018 23:55:34 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id k3-v6so2337293pgq.5 for ; Tue, 10 Jul 2018 14:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FSg6ToVrtqvGSMeqVUjxWf9CdDuoLy/Q95/3BN/x26M=; b=EpbXegJsIW4P3DYeS48+SKmnneFYA0BufpDQjH1s39ULPCYHDUCQNuJ6FnT8OoQ2z7 VUubrt5AtGM714ArcAf+sYby6m3Cx8vO4NFJ68XO4GRbFR58T0KdYxax6dst8p8qA7U+ LjfBXMtkbFjBDTyRL0b7dgkBXFKJI/7F+mfqLWncXU9eNuid0LwHv/gV9cRQw+zsB0iM +dvX9gaWf9JmwXl8rYWovY2v4gowPMz9taNkltqXQb3FWuguinnOfWfU5PvOcG/WVSFM GjIQWhy34mNLD7CTaYatzDRGXwHHgcWWKiMTS9Ft2+bBQF912aoWalK8jC8RAvHXLLG8 dwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FSg6ToVrtqvGSMeqVUjxWf9CdDuoLy/Q95/3BN/x26M=; b=qg5ObQlmb0YHnUkDzzZBcRDVP22UWC8aPs4LlsAidJnM733dGJe5sPFpExPPV9r4xZ l8KKqhDgW6ieVqp6lLoytkRjzJmgq1re5e821rpQWo5OSMnh2AxEDJDiLulxBfbPAtuu c9XSJtoFTMHGmjUGb95Ns+nLXO/AreOTyh4nzLwZUvu+cri/17dfO/0l019Pv4w/m5Fi s7nUy/F5vTyhCsc/Z15gxfXMt66tsxv3ZJjbDe5gofWNewHukQkK5wCrBALhUY7zFelm 4Ce4npY0XBY9M2DXujVbwDR3J47QG/HJbCPFIKKELh0g6zVYUHKZi9Pscj/XC9aXHfB1 iooQ== X-Gm-Message-State: APt69E2iswpPHo4D6YcPdk2NOCBwt0FyJF38F+N7RCER/cf2hpsm/oua aOeJXfDrnNizLUmL6cDQo/wOyA== X-Google-Smtp-Source: AAOMgpd8arrKLQlMWaYfXNEi2VYnEi95YDOvwFCHiqnXKvcWYCttWv4ESdz6EMIGHKlUslcDX1PEug== X-Received: by 2002:a63:1315:: with SMTP id i21-v6mr24251233pgl.147.1531259733217; Tue, 10 Jul 2018 14:55:33 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x6-v6sm36192454pfe.30.2018.07.10.14.55.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jul 2018 14:55:33 -0700 (PDT) Date: Tue, 10 Jul 2018 14:55:31 -0700 From: Stephen Hemminger To: Jeff Guo Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com Message-ID: <20180710145531.7fbd3366@xeon-e3> In-Reply-To: <1530268248-7328-4-git-send-email-jia.guo@intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1530268248-7328-1-git-send-email-jia.guo@intel.com> <1530268248-7328-4-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V4 3/9] bus: introduce sigbus handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 21:55:34 -0000 On Fri, 29 Jun 2018 18:30:42 +0800 Jeff Guo wrote: > When device be hotplug, if data path still read/write device, the sigbus > error will occur, this error need to be handled. So a handler need to be > here to capture the signal and handle it correspondingly. > > To handle sigbus error is a bus-specific behavior, this patch introduces > a bus ops so that each kind of bus can implement its own logic. > > Signed-off-by: Jeff Guo > --- > v4->v3: > split patches to be small and clear. > --- > lib/librte_eal/common/include/rte_bus.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > index 3642aeb..231bd3d 100644 > --- a/lib/librte_eal/common/include/rte_bus.h > +++ b/lib/librte_eal/common/include/rte_bus.h > @@ -181,6 +181,20 @@ typedef int (*rte_bus_parse_t)(const char *name, void *addr); > typedef int (*rte_bus_hotplug_handler_t)(struct rte_device *dev); > > /** > + * Implementation a specific sigbus handler, which is responsible > + * for handle the sigbus error which is original memory error, or specific > + * memory error that caused of hot unplug. > + * @param failure_addr > + * Pointer of the fault address of the sigbus error. > + * > + * @return > + * 0 for success handle the sigbus. > + * 1 for no handle the sigbus. > + * -1 for failed to handle the sigbus > + */ > +typedef int (*rte_bus_sigbus_handler_t)(const void *failure_addr); > + > +/** > * Bus scan policies > */ > enum rte_bus_scan_mode { > @@ -226,6 +240,8 @@ struct rte_bus { > rte_bus_get_iommu_class_t get_iommu_class; /**< Get iommu class */ > rte_bus_hotplug_handler_t hotplug_handler; > /**< handle hot plug on bus */ > + rte_bus_sigbus_handler_t sigbus_handler; /**< handle sigbus error */ > + > }; > > /** One issue with handling sigbus is that you are going to trap program errors as well as hotplug. How can you distinguish between removed device and a buggy userspace program (or worse comprimised program)?