From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1CB001B596 for ; Thu, 12 Jul 2018 12:47:04 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2018 03:47:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,342,1526367600"; d="scan'208";a="53828478" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga007.fm.intel.com with SMTP; 12 Jul 2018 03:47:01 -0700 Received: by (sSMTP sendmail emulation); Thu, 12 Jul 2018 11:46:57 +0100 Date: Thu, 12 Jul 2018 11:46:56 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20180712104656.GA19824@bricha3-MOBL.ger.corp.intel.com> References: <20180329140457.93034-1-bruce.richardson@intel.com> <20180329140457.93034-2-bruce.richardson@intel.com> <2985926.zg23VzBKoQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2985926.zg23VzBKoQ@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: add to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 10:47:06 -0000 On Thu, Jul 12, 2018 at 09:54:32AM +0200, Thomas Monjalon wrote: > 29/03/2018 16:04, Bruce Richardson: > > Add the ethtool example to the meson build. This example is more > > complicated than the previously added ones as it has files in two > > subdirectories. An ethtool "wrapper lib" in one, used by the actual > > example "ethtool app" in the other. > > > > Rather than using recursive operation, like is done with the makefiles, > > we instead can just special-case the building of the library from the > > single .c file, and then use that as a dependency when building the app > > proper. > > > > Signed-off-by: Bruce Richardson > > It does not compile because of experimental function: > examples/ethtool/lib/rte_ethtool.c:186:2: error: > ‘rte_eth_dev_get_module_info’ is deprecated: Symbol is not yet part of stable ABI > Ok. This set is fairly old, and I think I've found other issues with it since. I suggest we drop this set for 18.08 consideration.