Re: [dpdk-dev] [PATCH v3 3/9] examples/vm_power: add oob monitoring functions

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 12 Jul 2018 21:13:26 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 26/06/2018 11:23, David Hunt:
> > +#include <unistd.h>
> > +#include <stdio.h>
> > +#include <stdlib.h>
> > +#include <stdint.h>
> > +#include <signal.h>
> > +#include <errno.h>
> > +#include <string.h>
> > +#include <sys/types.h>
> > +#include <sys/epoll.h>
> > +#include <sys/queue.h>
> > +#include <sys/time.h>
> > +#include <fcntl.h>
> > +
> > +#include <rte_log.h>
> > +#include <rte_memory.h>
> > +#include <rte_malloc.h>
> > +#include <rte_atomic.h>
> > +#include <rte_cycles.h>
> > +#include <rte_ethdev.h>
> > +#include <rte_pmd_i40e.h>
> > +
> > +#include <libvirt/libvirt.h>
> > +#include "oob_monitor.h"
> > +#include "power_manager.h"
> > +#include "channel_manager.h"
> > +
> > +#include <rte_log.h>
> > +#define RTE_LOGTYPE_CHANNEL_MONITOR RTE_LOGTYPE_USER1  
> 
> I'm sure you don't need all these headers.
> rte_log.h is included twice.
> rte_pmd_i40e is more than suspicious...
> 
> This is a hint that the whole file was probably written too fast :)
> 

This tool can help
  https://include-what-you-use.org/