From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2855A1B057 for <dev@dpdk.org>; Fri, 13 Jul 2018 11:11:03 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 02:11:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,347,1526367600"; d="scan'208";a="57368017" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by orsmga006.jf.intel.com with ESMTP; 13 Jul 2018 02:10:56 -0700 Date: Fri, 13 Jul 2018 17:10:43 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: David Marchand <david.marchand@6wind.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, qi.z.zhang@intel.com, Stephen Hemminger <stephen@networkplumber.org>, Olivier Matz <olivier.matz@6wind.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com> Message-ID: <20180713091042.GA21549@debian> References: <cover.1530009564.git.anatoly.burakov@intel.com> <5f6bc60bf193daf4eb07f4484c52878bb1b751de.1530009564.git.anatoly.burakov@intel.com> <5431396.k1M6VaMcRs@xps> <CALwxeUvx2UXSQLTQrSiBZvOEEqmgz9NBUxnEPxJndLcdb_2w3Q@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <CALwxeUvx2UXSQLTQrSiBZvOEEqmgz9NBUxnEPxJndLcdb_2w3Q@mail.gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal: bring forward init of interrupt handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 13 Jul 2018 09:11:03 -0000 On Fri, Jul 13, 2018 at 10:09:42AM +0200, David Marchand wrote: [...] > Well, there was an issue vith virtio at one time (interrupt handler > did not have the right iopl for virtio callback). > http://git.dpdk.org/dpdk/commit/lib/librte_eal/linuxapp/eal/eal.c?id=fd6949c55c9a48e81c625138679159829d51ac51 > > Now... time has passed since then. > It is worth checking the issue is still here, and if it is the case, > revisit this. Now rte_virtio_pmd_init() which calls rte_eal_iopl_init() is called as a constructor [1], so the issue isn't there any more. [1] http://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtio_ethdev.c?id=1d406458db47#n1789 Best regards, Tiwei Bie > I suppose virtio pmd should deal with this itself. > > > -- > David Marchand