From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by dpdk.org (Postfix) with ESMTP id 89872DE3 for ; Sat, 14 Jul 2018 07:12:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=820; q=dns/txt; s=iport; t=1531545134; x=1532754734; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Pv1F51y8cswsnlM3CmUDQtsMdpwNws5e6m581FDZx+s=; b=LxgwWXWj69BQFLin9pdcEffp+lEvb+yxFzwUGz34DvrME9iAjPfD1Anx J/2oUl4B6K85vANjeCbFHvvW2TO5WRhXIW07PZwl7sD2cyhAhZGG2jFsA CF8AbUG018M0jt0QJALVEcLN02WHrF0xbwSKaNmSUw3fsDGMZStTHM8Ez o=; X-IronPort-AV: E=Sophos;i="5.51,350,1526342400"; d="scan'208";a="426783389" Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jul 2018 05:12:13 +0000 Received: from HYONKIM-7R0DR.cisco.com ([10.24.58.58]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id w6E5C92D012832 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 14 Jul 2018 05:12:12 GMT Date: Sat, 14 Jul 2018 14:12:09 +0900 From: Hyong Youb Kim To: John Daley Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180714051207.GA10152@HYONKIM-7R0DR.cisco.com> References: <20180714005452.28195-1-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180714005452.28195-1-johndale@cisco.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH] net/enic: pick the right Rx handler after changing MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2018 05:12:14 -0000 Hi Ferruh, Please ignore this patch, as it never assigns the default handler to rx_pkt_burst. We will send a v2. Sorry about that. On Fri, Jul 13, 2018 at 05:54:52PM -0700, John Daley wrote: > From: Hyong Youb Kim > > enic_set_mtu always reverts to the default Rx handler after changing > MTU. Try to use the simpler, non-scatter handler in this case as well. [...] > + /* Use the non-scatter, simplified RX handler if possible. */ > + if (enic->rq_count > 0 && enic->rq[0].data_queue_enable == 0) { > + PMD_INIT_LOG(DEBUG, " use the non-scatter Rx handler"); > + eth_dev = enic->rte_dev; > + eth_dev->rx_pkt_burst = &enic_noscatter_recv_pkts; > + } else { > + PMD_INIT_LOG(DEBUG, " use the normal Rx handler"); Here, we should set rx_pkt_burst = enic_recv_pkts -Hyong