From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
by dpdk.org (Postfix) with ESMTP id CB82A201
for <dev@dpdk.org>; Mon, 16 Jul 2018 09:15:33 +0200 (CEST)
Received: from rsa59-2-82-233-193-189.fbx.proxad.net ([82.233.193.189]
helo=droids-corp.org)
by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
(Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
id 1fexjv-0007BJ-C6; Mon, 16 Jul 2018 09:16:12 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
Mon, 16 Jul 2018 09:15:30 +0200
Date: Mon, 16 Jul 2018 09:15:30 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Andy Green <andy@warmcat.com>
Cc: dev@dpdk.org
Message-ID: <20180716071530.5gelmvk3htows3uj@platinum>
References: <152749815575.44120.3090426090234773551.stgit@localhost.localdomain>
<152749821848.44120.9534717185541492433.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <152749821848.44120.9534717185541492433.stgit@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 07:15:34 -0000
On Mon, May 28, 2018 at 05:03:38PM +0800, Andy Green wrote:
> On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:
>
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_prod_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:69:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> const uint32_t cons_tail = r->cons.tail;
> ^
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_cons_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:136:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> const uint32_t prod_tail = r->prod.tail;
> ^
>
> Signed-off-by: Andy Green <andy@warmcat.com>
> Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
Acked-by: Olivier Matz <olivier.matz@6wind.com>