Re: [dpdk-dev] [PATCH] devargs: fix devargs truncation when format string is used

["Gaëtan Rivet" <gaetan.rivet@6wind.com>]

Hi,

On Wed, Jul 18, 2018 at 08:23:30AM +0100, Andrew Rybchenko wrote:
> Space for string terminating NUL character should be provided to
> snprintf() to avoid the last symbol truncation.
> 
> Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
> 
> Reported-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  lib/librte_eal/common/eal_common_devargs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
> index a22a2002e..5ec688aab 100644
> --- a/lib/librte_eal/common/eal_common_devargs.c
> +++ b/lib/librte_eal/common/eal_common_devargs.c
> @@ -285,7 +285,7 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
>  	}
>  
>  	va_start(ap, format);
> -	vsnprintf(dev, len, format, ap);
> +	vsnprintf(dev, len + 1, format, ap);

Indeed, thanks for reporting and fixing.

>  	va_end(ap);
>  
>  	return rte_devargs_parse(da, dev);
> -- 
> 2.17.1
> 

-- 
Gaëtan Rivet
6WIND