* [dpdk-dev] [PATCH] build: simplify logic for default library dependencies
@ 2018-07-19 14:37 Bruce Richardson
2018-07-26 13:55 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2018-07-19 14:37 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
EAL is a standard dependency of all libraries, except for those built
before it. We can therefore simplify the logic by just checking if EAL
has been processed, and make it a standard dependency if so.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/meson.build | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/meson.build b/lib/meson.build
index 1cc7e111f..4384813f8 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -45,12 +45,10 @@ foreach l:libraries
# use "deps" for internal DPDK dependencies, and "ext_deps" for
# external package/library requirements
ext_deps = []
- deps = ['eal'] # eal is standard dependency except for itself
- if l == 'kvargs'
- deps = []
- endif
- if l == 'eal'
- deps = ['kvargs']
+ deps = []
+ # eal is standard dependency once built
+ if dpdk_conf.has('RTE_LIBRTE_EAL')
+ deps += ['eal']
endif
dir_name = 'librte_' + l
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] build: simplify logic for default library dependencies
2018-07-19 14:37 [dpdk-dev] [PATCH] build: simplify logic for default library dependencies Bruce Richardson
@ 2018-07-26 13:55 ` Thomas Monjalon
2018-08-08 15:58 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-07-26 13:55 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
19/07/2018 16:37, Bruce Richardson:
> EAL is a standard dependency of all libraries, except for those built
> before it. We can therefore simplify the logic by just checking if EAL
> has been processed, and make it a standard dependency if so.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
I guess there is no specific benefit for 18.08.
It is deferred to 18.11 to avoid any risk.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] build: simplify logic for default library dependencies
2018-07-26 13:55 ` Thomas Monjalon
@ 2018-08-08 15:58 ` Bruce Richardson
2018-09-17 11:53 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2018-08-08 15:58 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On Thu, Jul 26, 2018 at 03:55:56PM +0200, Thomas Monjalon wrote:
> 19/07/2018 16:37, Bruce Richardson:
> > EAL is a standard dependency of all libraries, except for those built
> > before it. We can therefore simplify the logic by just checking if EAL
> > has been processed, and make it a standard dependency if so.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> I guess there is no specific benefit for 18.08.
> It is deferred to 18.11 to avoid any risk.
>
Sure, no problem.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] build: simplify logic for default library dependencies
2018-08-08 15:58 ` Bruce Richardson
@ 2018-09-17 11:53 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-09-17 11:53 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
08/08/2018 17:58, Bruce Richardson:
> On Thu, Jul 26, 2018 at 03:55:56PM +0200, Thomas Monjalon wrote:
> > 19/07/2018 16:37, Bruce Richardson:
> > > EAL is a standard dependency of all libraries, except for those built
> > > before it. We can therefore simplify the logic by just checking if EAL
> > > has been processed, and make it a standard dependency if so.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > I guess there is no specific benefit for 18.08.
> > It is deferred to 18.11 to avoid any risk.
> >
> Sure, no problem.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-17 11:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 14:37 [dpdk-dev] [PATCH] build: simplify logic for default library dependencies Bruce Richardson
2018-07-26 13:55 ` Thomas Monjalon
2018-08-08 15:58 ` Bruce Richardson
2018-09-17 11:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).