From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 4756A4C99
 for <dev@dpdk.org>; Thu, 19 Jul 2018 17:38:12 +0200 (CEST)
Received: from cpe-2606-a000-111b-6075-6b03-d099-2fb0-21be.dyn6.twc.com
 ([2606:a000:111b:6075:6b03:d099:2fb0:21be] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1fgB0B-0005hD-LQ; Thu, 19 Jul 2018 11:38:09 -0400
Date: Thu, 19 Jul 2018 11:37:26 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Message-ID: <20180719153726.GB20362@hmswarspite.think-freely.org>
References: <20180718210609.32547-1-thomas@monjalon.net>
 <20180718212658.24756-1-thomas@monjalon.net>
 <20180719111427.GA20362@hmswarspite.think-freely.org>
 <1556161.F30VP9S7cZ@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1556161.F30VP9S7cZ@xps>
User-Agent: Mutt/1.10.0 (2018-05-17)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix symbol check for filename
	with space
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 15:38:12 -0000

On Thu, Jul 19, 2018 at 02:09:47PM +0200, Thomas Monjalon wrote:
> 19/07/2018 13:14, Neil Horman:
> > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote:
> > > If the patch filename or the temporary file path have a space
> > > in their name, the script check-symbol-change.sh does not work.
> > > The variables for the filenames must be enclosed in quotes
> > > in order to preserve spaces.
> > > 
> > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> > > Cc: nhorman@tuxdriver.com
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > > v2: one occurence of "$mapfile" was missed in v1
> > I don't have any issue with this change, but the only way I see to introduce a
> > space into the tempfile name is to set $TMPDIR to '/path/with silly spaces' or
> > something simmilar.  I think we discussed this before, but it would alsmot make
> > sense to, instead of quoting everything, instead specify -p ./ to ensure the
> > tempfile has no spaces.
> 
> When I save patches from my inbox, the filename has some spaces.
> 
> I think quoting variables is mandatory.
> 
> 
> 
> 
Sure, it doesn't hurt anything really

Acked-by: Neil Horman <nhorman@tuxdriver.com>