From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by dpdk.org (Postfix) with ESMTP id 5215A235 for ; Mon, 23 Jul 2018 19:36:01 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id x5-v6so875897pgp.7 for ; Mon, 23 Jul 2018 10:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZBfyUT16bKN5LLXgydP9MuEWrUoDn25ULO0uIGmfjHk=; b=VP/XnU1rjqet79HTBAPGHkb7Xpy3JuK8e7J0aGZrkPmVJz3zWTWiXf7mSjkA1/JEvF 4m4rhZboqZLcPsqJYvlFez9LqIRXb8BU3vX5Tq0wY8qgItAh7uQqW7u8hFxL4iLbdTU+ 6VnlkZM2lJOeFlRyG0Kjd1W/5HSJaGYi3MBiWqYgjicIrEGNF+t3vMaG+yFdMjYWD0h5 a/6NVCHRbxYNwVSU6jW+dyboOaldGVtTxybfUuEhJQVlYlf1u/VGtl6+8iqEgFaLSArK AEjJuIu+hBFIAAnXET1fs+Ex1EQTnOnR4EaoUcm2ntetZTFZ2hbWsUC7a1RuEo0lofkd M7gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZBfyUT16bKN5LLXgydP9MuEWrUoDn25ULO0uIGmfjHk=; b=PRZ54lAh64judyjzIQN6xdUCBd/B9UanymBNUljmtIFYp2RxRNy3hHlIW6rGvVy/qt 8m7crWpYnB4b+W4oMw8YU8EKdfiKqYIvOa150MBpMNv1lIBCshHnNFKIF9c0d0cohvEO WIyxIuMVyOeTIELkAU539YMKnC6HY+BTZqNE7NHq6JplufdS9gUMv7TNI0MNOYZCeswG l7QXL6Itu98396trbCGNs+4FoLGu60uhEIDzR1vxnlbS1KBJIX965GGKFx7q3WcFN8ZX WtH/UV9Rok9RpLL64kSSOXdUQZgn5OpYJWf0Jkk4myD7rXsKyJgw4hy4dyKI1mfZi0xt tWrQ== X-Gm-Message-State: AOUpUlHUivt+EE5/I5ib45vJ77ptyO44xxLzCLOWegVPhilLRpC4QC22 /3+AWDaAnHdUxLq4wlzQI1iDIw== X-Google-Smtp-Source: AAOMgpeS6EQNe+LnZHwpgfYHafAYp2BG2QksWEaM0jOiRSGQ9Lb7IPo873ZFeL6DUnOVWrcLtk4K1A== X-Received: by 2002:a63:920c:: with SMTP id o12-v6mr13152881pgd.141.1532367360357; Mon, 23 Jul 2018 10:36:00 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c1-v6sm13206063pfi.142.2018.07.23.10.35.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 10:36:00 -0700 (PDT) Date: Mon, 23 Jul 2018 10:35:57 -0700 From: Stephen Hemminger To: "Verma, Shally" Cc: "pablo.de.lara.guarch@intel.com" , "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Challa, Mahipal" , "Gupta, Ashish" , "Sahu, Sunila" Message-ID: <20180723103557.0c94c4a5@xeon-e3> In-Reply-To: References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com> <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com> <20180723095357.5a85b206@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:36:01 -0000 On Mon, 23 Jul 2018 17:14:26 +0000 "Verma, Shally" wrote: > >-----Original Message----- > >From: Stephen Hemminger > >Sent: 23 July 2018 22:24 > >To: Verma, Shally > >Cc: pablo.de.lara.guarch@intel.com; dev@dpdk.org; Athreya, Narayana Prasad ; Challa, > >Mahipal ; Gupta, Ashish ; Sahu, Sunila ; > >Sahu, Sunila > >Subject: Re: [dpdk-dev] [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue > > > >External Email > > > >On Sat, 21 Jul 2018 23:47:48 +0530 > >Shally Verma wrote: > > > >> -/** Parse comp xform and set private xform/stream parameters */ > >> +/** Compute next mbuf in the list, assign data buffer and length, > >> + * returns 0 if mbuf is NULL > >> + */ > >> +#define COMPUTE_BUF(mbuf, data, len) \ > >> + ((mbuf = mbuf->next) ? \ > >> + (data = rte_pktmbuf_mtod(mbuf, uint8_t *)), \ > >> + (len = rte_pktmbuf_data_len(mbuf)) : 0) > >> + > > > >Could this be an inline not a macro? > [Shally] Again what goes in favour of inline here? Just curious to know if DPDK has any preferred guidelines regarding this? > > Thanks > Shally Macros have no type checking and are harder to debug. They should only be used when doing generic code (ie template like).