DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Olivier Matz" <olivier.matz@6wind.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely()
Date: Mon, 23 Jul 2018 10:37:57 -0700	[thread overview]
Message-ID: <20180723103757.47e4c26b@xeon-e3> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B421EE@smartserver.smartshare.dk>

On Mon, 23 Jul 2018 15:53:42 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:

> Hi Olivier,
> 
>  
> 
> I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went through the entire library. Here are my suggested modifications.
> 
>  
> 
>  
> 
> diff -bu rte_mbuf.c.orig rte_mbuf.c
> 
> --- rte_mbuf.c.orig     2018-07-23 15:13:22.000000000 +0200
> 
> +++ rte_mbuf.c  2018-07-23 15:32:53.000000000 +0200
> 
> @@ -173,19 +173,19 @@
> 
> {
> 
>         unsigned int nb_segs, pkt_len;
> 
>  
> 
> -       if (m == NULL)
> 
> +       if (unlikely(m == NULL))
> 
>                 rte_panic("mbuf is NULL\n");
> 
>  

Adding is unlikely is not necessary since rte_panic is marked with cold attribute
which has the same effect.

  reply	other threads:[~2018-07-23 17:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 13:53 Morten Brørup
2018-07-23 17:37 ` Stephen Hemminger [this message]
2018-07-23 18:59   ` Morten Brørup
2018-07-23 19:45     ` Stephen Hemminger
2018-07-23 17:51 ` Honnappa Nagarahalli
2018-07-23 19:09   ` Morten Brørup
2018-07-23 22:40     ` Wiles, Keith
2018-07-24  7:29       ` Olivier Matz
2018-07-24  8:13         ` Morten Brørup
2018-07-24 11:31           ` Van Haaren, Harry
2018-07-24 13:02             ` Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723103757.47e4c26b@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).