DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: yskoh@mellanox.com
Cc: dev@dpdk.org, Yaroslav Brustinov <ybrustin@cisco.com>,
	stable@dpdk.org, nelio.laranjeiro@6wind.com,
	adrien.mazarguil@6wind.com
Subject: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib
Date: Tue, 24 Jul 2018 11:54:45 +0300	[thread overview]
Message-ID: <20180724085445.52206-1-shahafs@mellanox.com> (raw)

From: Yaroslav Brustinov <ybrustin@cisco.com>

Compiling with gcc 4.7.2 introduced the linkage error

"bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in
src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in
src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o"

Fix it be forcing the alignment of the glue lib.

Fixes: 0e83b8e536c1 ("net/mlx5: move rdma-core calls to separate file")
Cc: stable@dpdk.org
Cc: nelio.laranjeiro@6wind.com
Cc: adrien.mazarguil@6wind.com

Signed-off-by: Yaroslav Brustinov <ybrustin@cisco.com>
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_glue.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
index c7965e51fe..c56c69bb13 100644
--- a/drivers/net/mlx5/mlx5_glue.c
+++ b/drivers/net/mlx5/mlx5_glue.c
@@ -343,7 +343,9 @@ mlx5_glue_dv_create_qp(struct ibv_context *context,
 #endif
 }
 
-const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){
+const struct mlx5_glue *mlx5_glue __attribute__((__aligned__(64))) =
+						&(const struct mlx5_glue)
+{
 	.version = MLX5_GLUE_VERSION,
 	.fork_init = mlx5_glue_fork_init,
 	.alloc_pd = mlx5_glue_alloc_pd,
-- 
2.12.0

             reply	other threads:[~2018-07-24  8:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:54 Shahaf Shuler [this message]
2018-07-24 12:00 ` Adrien Mazarguil
2018-07-24 12:05   ` Adrien Mazarguil
2018-07-24 13:51     ` Shahaf Shuler
2018-07-24 14:24       ` Yaroslav Brustinov (ybrustin)
2018-07-24 16:03         ` Adrien Mazarguil
2018-07-25  7:38           ` Yaroslav Brustinov (ybrustin)
2018-07-25  9:24             ` Adrien Mazarguil
2018-07-25 10:02               ` Yaroslav Brustinov (ybrustin)
2018-07-25 13:18 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-07-25 13:22   ` Adrien Mazarguil
2018-07-26  5:44     ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724085445.52206-1-shahafs@mellanox.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=ybrustin@cisco.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).