From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Pavan.Bhagavatula@cavium.com>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam01on0065.outbound.protection.outlook.com [104.47.32.65])
by dpdk.org (Postfix) with ESMTP id CD40C239
for <dev@dpdk.org>; Tue, 24 Jul 2018 12:44:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=AYhBsa5P+0FN5eg6Yu01MCqx+JBO6rT0iOc7aYY2vCs=;
b=nERrh6P/ffIH7sTJONJ98d7jAzE3hA0kEUOtwYrH/tVTgnf2fGYXFUpBEWztsXRvDmaWk1WAlI7ZJ2EGSycpke6biIu7wyMdKi6N0GvkppQ4EMyMy+M7DFeKIc1eRDYNZqK6LukOHpuxq7YRbObBTmYWaeJi4YgszY4YhM1wxI0=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Pavan.Bhagavatula@cavium.com;
Received: from ltp-pvn.caveonetworks.com (111.93.218.67) by
CY4PR07MB3462.namprd07.prod.outlook.com (2603:10b6:910:75::15) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.973.20; Tue, 24 Jul 2018 10:44:11 +0000
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
ferruh.yigit@intel.com
Cc: dev@dpdk.org,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Date: Tue, 24 Jul 2018 16:13:50 +0530
Message-Id: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com>
X-Mailer: git-send-email 2.18.0
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: BN6PR11CA0046.namprd11.prod.outlook.com
(2603:10b6:404:4b::32) To CY4PR07MB3462.namprd07.prod.outlook.com
(2603:10b6:910:75::15)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b72cea62-f81a-4cd6-9068-08d5f152657e
X-Microsoft-Antispam: BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(2017052603328)(7153060)(7193020);
SRVR:CY4PR07MB3462;
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
3:YOVSUHoIhe6XFwF5slPDbADf5FgiOfFe4nX/WE64bA8juV8/+bq6pP5nH5foSovt7UKhVGnI+awFBYBaf4kkPzw6E+pZ28IKqaCKOAmeQiA39ZSteKW9UyfgBP43JLmRI0OzZ3gSigePanY+rfNAmMSr/JEmNu+N0TsxBxRdmpC2kWC6All2MZFnHr8R+alvYHZyh8c7W9jBXXq5tfFfmhcnHG4R47MuWfrMjsZoJkUf0vRcGGzO4GQipFiZCVdV;
25:szc1j1Meb3rg17EioHoS7PdE7kmc9FeF5ar3cbnQaYVNdIZs4VnOrlnag8aWjefz8EgEQTuJqGOtLAFb3tYO6z0IUErWwD/pjQ6UVBPHI0wb0LsXLOkPOm8c3zITRf2QNrZmSR7QO94+fUxozhjFA7qKRPn7tq3u4ALKRdtcFCKk62Qr5Hfy/Dit9xpBtBK728dCGXujCpp7uqqXClAOj6Ry+0ApesEzCb3KNMYqmHuoU26DVkH+EuZ9kTiQNSvuYNjYXDqRuntvzioXqVvTSrTCClnSQz3AA9eulAJVD4T4L8BnJH0SFQpGlboP5XrfIo8RHykCJvDMHcN4SbtOtA==;
31:fC/790qWg3ZzGi/ib+g9W0/TOWePIWecnotNkBi17TW/Zl0IxxIZKCY9jWkvNeG4vkVMgn7Jt23juuck2z473XqAQHkt6l/Q6CvweigXZeU0+tfcaeEPM59M1laPBW4LjGxibZQYQoHhQpUsZ0MgrtC400JI3JqYucBuIRbOv+OWEUDsj4uy27dysSVwWSXDE3UrzUD26yWolLPrrpEaRPhaKJCdd/eZSj+auzzjPRg=
X-MS-TrafficTypeDiagnostic: CY4PR07MB3462:
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
20:huePyJFd+SsQE8XE54HKFOoJ0t0plRbLALt4NSUbkywa8RgouYNxKGFWVF1gRhdbIRCnGIDqUAa/rtyYGZIXqmmsBMU0Yqjd7XbgwJjKJgKJlzYw2ZrEK8skowJ9mxjKwFBO8V2m8YWm5laPUFBOwuz5bepC07J/4jbCAzn1S6sEiy0KQ9GHk5PDtUUDJUHZPn1AUtYQ6jJKUOHxFyVH8F2KWdwTjn/QszP5QmkF8NVZZca7epOAoxezckXvAlk2CYWUfGZJdM/UUGY5W5Cm18ZBn172vQoYSV9wpv5qGhbC5g2zOtFarpRsgxgFfEhDnBhUx9JrNbBkuVqhXZF6cUvkmYIrXSA/eCqAKsVTcd28kABTSTcOMtIvHprXW+u3GXSGYeoO4yk70mGFcnAM1jGRznAUGFP7/Vx7vuT8aQ1avH7ff6o4b8Wl3/R6Sl6faxEG7Bqd5UfgHRRH8Vrd5Zd4ByvuOSLJ5FYRexgY5E5ca1ZOK51T9FHX6gO7tmLOHXrUi2d8z3HLKj10oNpQmXHe5TXAKl6MAl9e/71dhRxltd32gTwQdq1gf52lGCr5JsBAn681UJ8CRBQJ+UDqWlcqBWG2bc7dHKgiCA1+aLw=;
4:Sk9vaGFLxyJhknDsb6xb6mcFlWjKUXeVhmD5XYnsZue+WB1tjtHdiBK1biB9TyzYYNCCZe2s6KyPm1S1U0RKe6XtlA6cuznGiKbyT+AtHJ85RRLiXVMS/Y+84hYZOFReFnJ7uMx6O+DhXvFJcQ0HjHcbqbMYmreDW1eJSSBQHBxa/b/jtZoLyAzb1hADvhfVTbWf9366CVic1hBCNUcfCqwQTRVQvmYDDExRLQAAuxlasNrtuqgQnLoI2CtZS8iEQlzSqvxR9kJD6jMMKsikvw==
X-Microsoft-Antispam-PRVS: <CY4PR07MB3462FF78AD4B96BB42CE41BF80550@CY4PR07MB3462.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(93006095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011)(7699016);
SRVR:CY4PR07MB3462; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3462;
X-Forefront-PRVS: 0743E8D0A6
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(136003)(39860400002)(346002)(376002)(366004)(396003)(189003)(199004)(26005)(16526019)(81156014)(81166006)(8676002)(8936002)(3846002)(50226002)(386003)(6506007)(68736007)(7736002)(52116002)(51416003)(42882007)(97736004)(1076002)(53936002)(6512007)(956004)(1857600001)(6486002)(486006)(107886003)(4326008)(25786009)(69596002)(6116002)(2906002)(5009440100003)(47776003)(66066001)(53416004)(106356001)(105586002)(478600001)(72206003)(476003)(2616005)(14444005)(36756003)(305945005)(5660300001)(316002)(6666003)(50466002)(16586007)(48376002)(42262002);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3462; H:ltp-pvn.caveonetworks.com;
FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3462;
23:UaVOHz/kF9AEqzq7m6qoySfzqLGRpLR+/5QLAXrm9?=
=?us-ascii?Q?Jbq8CG54OwicCW3R1zsh0xLrBXJCU5xeOQYVs/cmdurFDRXQBFQWjjKinbDY?=
=?us-ascii?Q?eyypx9rq2pCeHhAmZi5xGUY6Lwh+rsMtUiVMfxWNiQzrS4ABeVfHZnBghG85?=
=?us-ascii?Q?o3qTLmOzqK0CSzs6hX/HcCftDZLA/lB8OqjGwKphPRx/CCOiTQ1Jq7KE1khv?=
=?us-ascii?Q?oeZ7IDcV7UXq9rsA7BDQyKFesmW8uia5Tzy7TSOBGAQV8x5qt/VOq30gkgs1?=
=?us-ascii?Q?OBe8B2o5puO/D+pvq+lUFs3268pLAzku//mAwUg7wktK9KV8jL2ArwaX9rET?=
=?us-ascii?Q?Msm7fcBQR6zaQCUR0QCcTA/4U/mzeVBfmieNy1DQTcGlIWlDOhRAjgG2d0vU?=
=?us-ascii?Q?g9izMEA7gQ3PSzxOHgSbIgxfRh3iDuc3oy6OL/4QjzAJfzsBkoYzXA4DEj5x?=
=?us-ascii?Q?CyL1cMnqMwQLyER1jlisgJUqeFwulgTw+gySPCZhWdkHitFbhGpkpSXkuMzA?=
=?us-ascii?Q?9X1mesK3ZgG8mUolU2b7VwPgfkRsrEiDVmEQtunl+sImUOVVN7CImuduhyF+?=
=?us-ascii?Q?yrbr7TfvG/WMLl7+RVdxps7TVL4DYMaLJjx++a6L+oSj6Cmb0467HUIgLeod?=
=?us-ascii?Q?y4ZCAXoHVO23JeX8A0t1cS2K19RvDDfBN7iJRxrFzxmO1IZOhTbTkNU57YM8?=
=?us-ascii?Q?f6/1HMPTImYqk/7LwY2oh1k/cZomvFtrlvLJS3MubV98LB9jlK0A//A3c3y6?=
=?us-ascii?Q?mHO/aiBTviYJP9qXO9c4s1NwWEtFcFF0ATIa6wocMVachFPtPxY7y3W1boT3?=
=?us-ascii?Q?hD+MiQ0PjkN6LP7nFRD1HVKsLlwGITG1HgAV5bVlAfRLV6xvZ4dkWnUEzr44?=
=?us-ascii?Q?J0VaAznP1d6BxVk9RwvnR5shlZlBCMRhVdVYfMJrs9qyjUEoUjePnf957WCS?=
=?us-ascii?Q?cu4D1l1TDX5dOe4uaOjDasjzanWIlOasNV1HwgCLl/OSzW7yWST2IOvNKafU?=
=?us-ascii?Q?bii6sImOy0faVWyQC00WlqB2+SX7x4rPlkkojUhBXPfLuEJaEEiS7kYNbLvk?=
=?us-ascii?Q?bBXDESwTEvcxEh+aTw6gwXybJzF8/aT+W+e3KZfprKC+BozDO07W8K3tfD2Y?=
=?us-ascii?Q?mHNUS1y5eON9BCYqsFEMS1q3vAbHSMWSfEOipyi7h6TmOxruwsbpX7RxJTt4?=
=?us-ascii?Q?+JKLBRYOGZuwBYSqV1CdFOEUqTDu3vySSYsiJDxkggYPyZTDWZyWrN3VQEfP?=
=?us-ascii?Q?GgN/1cFt6tP+Zk6dP2i5wQs5ncNaetPnnhbfGaq?=
X-Microsoft-Antispam-Message-Info: OnCTJsCrfudvyHYoCpuZrPJoc91YfSwmKRz3S00IKY3+sNX/9b501EXy/lFSCtCwg5TsKHMf2SZ+GxnbmZQEVSCTvWxjYagaoFErGM1soIuII+H21VX01BMyHIZAIu9Tx3g+DpZOHYHQwh7ISBmxrBJbkdA4gRh/BqClz93C3noG9ApNJhlyAS1XuWLcRP3CyG4kMxyjtS0eZJD+mx5AfiqrX9RndEd+Igae8DLSUBZBMTCjaK+X5O6lflLub9pjxPe91toaBNkmCTEU2Wr52ikHMn2YpTMPnjfxsJE0J86CaAnCHE8tkVib+ZWkZ0+aOpba49GD4ndP+YmhI9RXnbCy0nFnRZc+AXxx3GhWGZE=
X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3462;
6:IAPeuf5o64w9GQMqhOIWey2VCCfFYr46O5zV0oGVqzBimidm0oPAM07FwuRIlefREloqQXIx8Kb5pO1hnpuZRBbWS6VcyLx3UaYBrz3ASYzLjOgi5mFX2uR14S+oYB9hLhk/ZSNg4m9/F5A0o2ISn7VT8q1IdV/D3NWIfS4zOl9z3dbLqq42tthf6GrHrpK8NvAORlQ+Wx85yNPfLRgigj4hdr5FujjkTf+ngJlyme7X9e1/gTCDoouKvoKNy3JKDMdeZlcAPBkEJDC2XEe1sxV7oi/kC5T3v/MFk5lIwtITGj4t1nPXy+eN7x1ATRnX736WBj7atoSitGmN60PPdOAFiNS9K1yLpV3Sel9on37Hk8SkXlZro3NQtuBgYI1c+93LaRQclaOUGcQw4mZOwLXQoH3Cfk/unZFoj2UcLQmo24Yz0Ex2dUJNlaVZu9j7+1CL7N5/7Lt5YTth0NrXtg==;
5:PsWsQA4qMEBDVJkiEOkDxkAGAsBC1VOVk0qgxoLuQFA3zRd/56D98qUO5Zvvc5U3oMWATnn0zqweWZ39hhJkan+dgDfb9L26qpHvkOlPYbqcKj4C0qPWaSj2FENQVaSyZHfimR2qiqKZ2LeMbIzSKrMVPbc0XDHxFHx+wtCARvc=;
7:hjnZT1X2Ga4dbPBzRQ7l63SEBxOo+9NMQguMGitWtlGGMrior+NvU5BAZW4hXu8wWlx5ECe7Omv+dwyiBFz5AIxzSEwojy37hVEDNztHFeyAWTjsxPhGFOsPFnixiCwoFTzw1/BNJ4ykzV/Z7jNKQckwB/CBJ0+QHjx/+bwP1Rzesan+yNaLqfRIH/A/ovmTnZLWMlApHSuN/NjcnrjXZ2ubE0OW0dFY+c9yt/+SnniiFEgHwzY2aprxX0dVSPg2
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 10:44:11.5134 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b72cea62-f81a-4cd6-9068-08d5f152657e
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3462
Subject: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath
functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 10:44:16 -0000
On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes
a SEGFAULT in cases where control path calls stop and a paket is still
being processed by a worker.
Instead clear the fastpath functions in dev_close.
Fixes: da6c687471a3 ("net/octeontx: add start and stop support")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 1eb453b21..8fe868678 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -352,6 +352,9 @@ octeontx_dev_close(struct rte_eth_dev *dev)
rte_free(txq);
}
+
+ dev->tx_pkt_burst = NULL;
+ dev->rx_pkt_burst = NULL;
}
static int
@@ -445,9 +448,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev)
ret);
return;
}
-
- dev->tx_pkt_burst = NULL;
- dev->rx_pkt_burst = NULL;
}
static void
--
2.18.0