From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 14D7F235
for <dev@dpdk.org>; Tue, 24 Jul 2018 13:44:56 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id v14-v6so3831149wro.5
for <dev@dpdk.org>; Tue, 24 Jul 2018 04:44:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to:openpgp
:user-agent; bh=J5BPe+xKvBBSaek5bfPZ05DzWVzohJJ55twjHBBFaS0=;
b=0wJ4eT8U97EOyn2VYwlj5rS2gF3cdIfhQitla5LfQ9dbId+0IiSEhxBP0o85IclePP
OdB9rdG2R/q87PrG4uGNBv2hI8wmQaAmg/EfONMZmqOLvMKFcwvnQI1HQvvik+3al7LV
Qt0o7KC2WJGQ8u6Dg+N6Tl0In/F4eORgs/D/lBrCubxCzRA+Vl/77r8qOimh6j7Po5C2
VZcwfXqs5D+NWK28ztBinq0za+eoAx7qbt5Uzv9vZ2gSZ0foFpAH9JXc6oBqJaqUPmSl
ZDAoLV1ERecexonB89pLtEMMkpDqo8FWfUkcEAJ9zGFMN+xH9rB49a3bXWhZgV2biInr
ynAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:openpgp:user-agent;
bh=J5BPe+xKvBBSaek5bfPZ05DzWVzohJJ55twjHBBFaS0=;
b=WrYK/HcOLAPgQZK9KopOzlar/dTTvnNMk2zJzsMCFNAG8HCUZyhY6ixpli57JIkJ1P
aV4hrjS/R72/Y4DP/Kip52UYOKxXQv+lhsrTQXfA+fBLFMgP/8ILdEtEpW/jx9Fvp1Uv
5ZNPkPd5gpcMLmaBSOl3vgjkm2Lk8X8c+3vAFYWUceyakP6DGpMUAcabqZAFIl2jpXpx
TgmwuwgUVanibbAg6hnoS6QM1KDTBU5qAhuQdV8V8kwgqgUIrS958WEPkMKpn4fwsKNa
M+B6ubEp02+gm8lP0n4KCqdUw+1BKnPWRyRJUVhk68s7WlpzAcG9JjHn+xe66RABdCrB
ba0Q==
X-Gm-Message-State: AOUpUlGrtL/X29rEq3739PmY6Y7jLUJ32+kCZ8ye6rnTYOy9nO3MnyNG
d6irDtzyFhC+ojmRE8exMRJ0
X-Google-Smtp-Source: AAOMgpc+2hS32LTTY6PtL21lGUu/nlhOixBFBGJJgVZQOKQrGzWo/VgWX3EjMSRzmDs+dIr12S0HoA==
X-Received: by 2002:a5d:48c7:: with SMTP id p7-v6mr12166774wrs.0.1532432695846;
Tue, 24 Jul 2018 04:44:55 -0700 (PDT)
Received: from laranjeiro-vm.dev.6wind.com
(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id p3-v6sm12890598wrg.47.2018.07.24.04.44.55
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 24 Jul 2018 04:44:55 -0700 (PDT)
Date: Tue, 24 Jul 2018 13:44:50 +0200
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Message-ID: <20180724114450.5mrrdkye7elwpka5@laranjeiro-vm.dev.6wind.com>
References: <14690e825609ee181e3cd522302d4788ef436f35.1532424524.git.nelio.laranjeiro@6wind.com>
<DB7PR05MB44268F70B4DC8FA96C3EF5EDC3550@DB7PR05MB4426.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DB7PR05MB44268F70B4DC8FA96C3EF5EDC3550@DB7PR05MB4426.eurprd05.prod.outlook.com>
OpenPGP: id=A0075DA8F66A5949 preference=signencrypt
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl
and mlx5
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 11:44:56 -0000
On Tue, Jul 24, 2018 at 11:21:52AM +0000, Shahaf Shuler wrote:
> Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro:
> > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5
> >
> > When Mellanox MLX5 PMD is compiled with
> > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=y, the external dependency on
> > libmln is missing.
> >
> > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads")
> > Cc: adrien.mazarguil@6wind.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> > mk/rte.app.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index f4d28c2da..ff39d37aa
> > 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -149,7 +149,7 @@ else
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4 -
> > libverbs -lmlx4
> > endif
> > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
> > -_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -ldl
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -ldl -
> > lmnl
>
> This issue raise some more basic question.
> The DLOPEN mode was introduced to run in systems which don't have
> verbs/mlx5 libs installed, because those were the only dependencies
> for the PMD back then.
> Now we have the libmnl, which is external dependency just like
> rdma-core, and following your fix, hard linked also in case of DLOPEN
> option.
> It means the whole DPDK binary/lib will be depended on libmnl and this
> is not what we want with DLOPEN.
>
> Can we consider different options:
> 1. always statically link libmnl
This will force users to re-compile their application to have the missing
features disabled because some calls are not available, see the list of
HAVE_RDMA_NLDEV_* elements in the MLX5 makefile due to the issues this
Netlink stuff brings.
> 2. dlopen libmnl just like we do for verbs/mlx5
You want another glue library. It won't be for this release in this
case, I don't have time to write such glue.
> > else
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -
> > libverbs -lmlx5 -lmnl
> > endif
> > --
> > 2.18.0
>
[1] https://mails.dpdk.org/archives/dev/2018-March/092876.html
--
Nélio Laranjeiro
6WIND