* [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter
@ 2018-07-19 11:47 Pavan Nikhilesh
2018-07-24 15:38 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh @ 2018-07-19 11:47 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev, Pavan Nikhilesh, stable
Modifying port state is not necessary when starting/stopping Rx adapter
as it is same as starting/stopping ethdev.
Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
Cc: stable@dpdk.org
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
drivers/event/octeontx/ssovf_evdev.c | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
index 2df70b52a..f98296f18 100644
--- a/drivers/event/octeontx/ssovf_evdev.c
+++ b/drivers/event/octeontx/ssovf_evdev.c
@@ -476,14 +476,9 @@ static int
ssovf_eth_rx_adapter_start(const struct rte_eventdev *dev,
const struct rte_eth_dev *eth_dev)
{
- int ret;
- const struct octeontx_nic *nic = eth_dev->data->dev_private;
RTE_SET_USED(dev);
+ RTE_SET_USED(eth_dev);
- ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
- if (ret)
- return 0;
- octeontx_pki_port_start(nic->port_id);
return 0;
}
@@ -492,14 +487,9 @@ static int
ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
const struct rte_eth_dev *eth_dev)
{
- int ret;
- const struct octeontx_nic *nic = eth_dev->data->dev_private;
RTE_SET_USED(dev);
+ RTE_SET_USED(eth_dev);
- ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
- if (ret)
- return 0;
- octeontx_pki_port_stop(nic->port_id);
return 0;
}
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter
2018-07-19 11:47 [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter Pavan Nikhilesh
@ 2018-07-24 15:38 ` Jerin Jacob
2018-07-25 13:14 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2018-07-24 15:38 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, stable
-----Original Message-----
> Date: Thu, 19 Jul 2018 17:17:47 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start
> and stop in Rx adapter
> X-Mailer: git-send-email 2.18.0
>
> Modifying port state is not necessary when starting/stopping Rx adapter
> as it is same as starting/stopping ethdev.
>
> Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/event/octeontx/ssovf_evdev.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index 2df70b52a..f98296f18 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -476,14 +476,9 @@ static int
> ssovf_eth_rx_adapter_start(const struct rte_eventdev *dev,
> const struct rte_eth_dev *eth_dev)
> {
> - int ret;
> - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> RTE_SET_USED(dev);
> + RTE_SET_USED(eth_dev);
>
> - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> - if (ret)
> - return 0;
> - octeontx_pki_port_start(nic->port_id);
> return 0;
> }
>
> @@ -492,14 +487,9 @@ static int
> ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
> const struct rte_eth_dev *eth_dev)
> {
> - int ret;
> - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> RTE_SET_USED(dev);
> + RTE_SET_USED(eth_dev);
>
> - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> - if (ret)
> - return 0;
> - octeontx_pki_port_stop(nic->port_id);
> return 0;
> }
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter
2018-07-24 15:38 ` Jerin Jacob
@ 2018-07-25 13:14 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2018-07-25 13:14 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, stable
-----Original Message-----
> Date: Tue, 24 Jul 2018 21:08:04 +0530
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Cc: dev@dpdk.org, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port
> start and stop in Rx adapter
> User-Agent: Mutt/1.10.1 (2018-07-13)
>
> -----Original Message-----
> > Date: Thu, 19 Jul 2018 17:17:47 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start
> > and stop in Rx adapter
> > X-Mailer: git-send-email 2.18.0
> >
> > Modifying port state is not necessary when starting/stopping Rx adapter
> > as it is same as starting/stopping ethdev.
> >
> > Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Fixed check-git-log.sh issues.
Applied to dpdk-next-eventdev/master. Thanks.
>
> > ---
> > drivers/event/octeontx/ssovf_evdev.c | 14 ++------------
> > 1 file changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> > index 2df70b52a..f98296f18 100644
> > --- a/drivers/event/octeontx/ssovf_evdev.c
> > +++ b/drivers/event/octeontx/ssovf_evdev.c
> > @@ -476,14 +476,9 @@ static int
> > ssovf_eth_rx_adapter_start(const struct rte_eventdev *dev,
> > const struct rte_eth_dev *eth_dev)
> > {
> > - int ret;
> > - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> > RTE_SET_USED(dev);
> > + RTE_SET_USED(eth_dev);
> >
> > - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> > - if (ret)
> > - return 0;
> > - octeontx_pki_port_start(nic->port_id);
> > return 0;
> > }
> >
> > @@ -492,14 +487,9 @@ static int
> > ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
> > const struct rte_eth_dev *eth_dev)
> > {
> > - int ret;
> > - const struct octeontx_nic *nic = eth_dev->data->dev_private;
> > RTE_SET_USED(dev);
> > + RTE_SET_USED(eth_dev);
> >
> > - ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> > - if (ret)
> > - return 0;
> > - octeontx_pki_port_stop(nic->port_id);
> > return 0;
> > }
> >
> > --
> > 2.18.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-25 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 11:47 [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter Pavan Nikhilesh
2018-07-24 15:38 ` Jerin Jacob
2018-07-25 13:14 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).