From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Jerin.JacobKollanukkaran@cavium.com>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0042.outbound.protection.outlook.com [104.47.32.42])
 by dpdk.org (Postfix) with ESMTP id F118D3237;
 Tue, 24 Jul 2018 17:39:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qqblQaU3znGby+rhM46PCxrZFNBpRUJod2ihvFP+gTs=;
 b=J2NfRKqUAs7z+KjPGXLpWZCI2SG05q/DroBZJK+sGRQHDmezDoKPeikGAXD51VA3kAb5rbgBoPFTtbiYIlycUm/xVKibTMUSG9tH7tYlAusyZBjgjMG6PdID/zVx/mh+QZ0/KTNAdgg/4VuL7t9Rf3Gb/s976WGkrkKyFbaZtmM=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; 
Received: from jerin (50.233.148.155) by
 BYAPR07MB5000.namprd07.prod.outlook.com (2603:10b6:a03:5b::25) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.973.16; Tue, 24 Jul 2018 15:38:11 +0000
Date: Tue, 24 Jul 2018 21:08:05 +0530
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org, stable@dpdk.org
Message-ID: <20180724153804.GB11073@jerin>
References: <20180719114747.25430-1-pbhagavatula@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180719114747.25430-1-pbhagavatula@caviumnetworks.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Originating-IP: [50.233.148.155]
X-ClientProxiedBy: BYAPR03CA0006.namprd03.prod.outlook.com
 (2603:10b6:a02:a8::19) To BYAPR07MB5000.namprd07.prod.outlook.com
 (2603:10b6:a03:5b::25)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f9ccf79a-1c69-495f-ba6f-08d5f17b77bf
X-Microsoft-Antispam: BCL:0; PCL:0;
 RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(2017052603328)(7153060)(7193020);
 SRVR:BYAPR07MB5000; 
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000;
 3:ENGru9T5wVXskdjjjz1OOoZ7EYPrxqg/U9sghKWk4yJeKh1AyYAAJ3RblS5+q38NjMGHn0+FY+rajGOqFCuQwDbE1SWC7PssQQ6/VF0hZ/i0WNpN1m2uKKAfDWS8Oa2nE4MEDmsSVpUK+mSq/dhvNsjbzUFeUmu/Cr5QfEZvHNGNDgxjywQT3i48WnMUKEIFEwiX7XLlP67+jWTi3E+auz+6VgX0bHOIdVfS9Js/zC0a2Pqzi6mfOBrGZcyJMaHC;
 25:ADPbCuSJ3MFu+osVEtFcr5Ofh089lq7oQ/9urkqCtZjjs133SHSl+x4EbSIpKwiDbdAUHUs93YGZB8FSYMeM2PwTrEQY1UWNHmcf58Sxy6bN1RIgnFfMxZ7ytKFxUuW7L4chVYkwF6vv62FdLngmlJ+7LksmLnqhLiidFUqDh9fSXAC28ShOm2G1QNpRG+FbnGRAIHEhAtD7gYMWGh/qp9I6CapgmBXaN+mjy4WwhyPQnRZIud0lDXr0hkSphDec8bUu/MxjTm1b6ptqIrMEQXKFw4UdnVt6CP2Pu7ZiCIAk/EUpnGJ5ILqHzQWaZiPPNXKOmowN1keJv3nPE6uTIw==;
 31:siI4VHBh9TXws2jBp4FBlDu72aFBw6zaTz44VBEowwN76PNxPOI72HRT7kPQ5td1rCvrsNfS5fheEbXNYZHhgYUFFkK17rtMTwaHsjSkZpx7LbX/r2450ndue9BfjFd3hRp/l+nRXZctGSFDVxB+L4eDPT0PieUI0+4YcNunamkwG9vRLonVZmehJdoJr52z+G8k1OU8ffCoWiPmw33Uhw8TwTujx3Ha23SoyJj5TBk=
X-MS-TrafficTypeDiagnostic: BYAPR07MB5000:
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000;
 20:ie2yjigXWivz0VWt8Qp13WUmBJUq4isg+4JVARGevalxhCPy9Md+n5Wh8GwO+bi4Z2GyuCtijBeezbJIT76oa6szWfUoba1vSzc2zJmJV52IoCmguc11hM+gV4DwN1U53N3q+wgcSrRzUU+a7RetkCHJnd/hZhdPO08NrQMDjHTRFSguPUQsieIlY5uDUBLidzWfKGuh3+oMraQ6CklbMnzCXU1ftOVbkhjVgTZB3ULOZRJFvEbce/4B45Shm97qu3IqfUbK2SQ2uIsCYuMTjEg7em/ZVZLgeWHsffS2kJQG+MA7G4RN4SEB1WKP+ZVeFskSukSq2zZ8xBhvUjNsrLAiAC35i7S0upqj4xmX5Pp8IvuSykVOe9kmEv6iPveng8+uGD/22qf49+8yQdovt2fyI5BsfrbD/w1p5aBs72WLSOGmAFjciPXuvIIKPtr3X0M//AR6xjpDqGK1VlUnXvMLTE4ZpL39vFb/XR9e8FgLDIe3iRhGEdDbA5gAzBGnAzqzWiVXrEJb8NGLmCQL0MdzutWVm31cHuID+ABqFGpm7ImMimZ6tWFMp+Wv72DkQzCrY09X7seSvB2AOjJu5F+wYbmHuFsgY6Ea6++nTBE=;
 4:ASBDheB8Jnw9lk+5G4HYsE34l7cLPwc/7o+JiH1uyqXh4Y/p0OjzZAqKbr/G/hoQyRVjLiuar2eP17yFjbW4zLCSdcS5QbDkxvMPSjWl0WA5KBRYOu44RzShZvjhnzCxQXVJMjTXuNjx0HiAjS2MyynYsgyWxtJqUAFbAewrT6PQVqF4g5hl/LG5oSSY6halVTF9CvAWNRge7NUHlffQz+ro9TDGGf7N4DTtypnE7MG/8S1rFFc9MkXsFF41LNE4PNcJUjCsW755wwpKI6v4Wg==
X-Microsoft-Antispam-PRVS: <BYAPR07MB5000864A66498CA487D4760DE3550@BYAPR07MB5000.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(3002001)(93006095)(10201501046)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);
 SRVR:BYAPR07MB5000; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5000; 
X-Forefront-PRVS: 0743E8D0A6
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(136003)(376002)(39860400002)(346002)(396003)(366004)(13464003)(189003)(199004)(316002)(33896004)(476003)(9686003)(33656002)(4326008)(956004)(450100002)(229853002)(44832011)(58126008)(11346002)(486006)(6636002)(6666003)(25786009)(16586007)(6496006)(446003)(305945005)(106356001)(386003)(6862004)(42882007)(105586002)(478600001)(53936002)(5660300001)(6246003)(81156014)(72206003)(81166006)(8936002)(33716001)(1076002)(7736002)(55016002)(23726003)(76176011)(16526019)(6116002)(3846002)(52116002)(97736004)(26005)(50466002)(66066001)(68736007)(2906002)(8676002)(47776003)(18370500001);
 DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5000; H:jerin; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB5000;
 23:/qQNxj5CyCO9kmclp4W2Pj6etY9b0BXw2SecK6+C4?=
 =?us-ascii?Q?2lkgInfOGgcgWR+xhagmOvaLBCp6PYZ7vJGtOxgDIxkW7q6iQ8pJwaHBo5b8?=
 =?us-ascii?Q?ck3WLmVlSG8vy/6QtrNtbWn764wI2Ebb8fTzdtjclv+G0TlNjoRVu0ozj/tj?=
 =?us-ascii?Q?B8oGvCSVsu8vS5fMBYNpNFtTQeB+Hmp/l+aWXHu4sicyPtwaby4aJbVnVLk6?=
 =?us-ascii?Q?llT4aaDc1iCUlyJZWGyQ+GEP+I5MSwY4HXDXOEOh26y2mggIsAEn4udhXaxr?=
 =?us-ascii?Q?tG8F1Bs04QZcZgiDVor3LWvhv8liy65f2+b8Xm7dgR9wpiI5IhYjPwlnLx4Y?=
 =?us-ascii?Q?kSqahli2p4/E2qRZATfQ88oteEZc/kLAZdb/u9jdfNVnPGWAf2T9bQjIlnjc?=
 =?us-ascii?Q?UIAuJDtlsBflHt1kJoxNtQ84mpvdVnsDzohR3XzYXSOWeMpQwYBbVobTqxHW?=
 =?us-ascii?Q?9sqCiA1FK0tqhNPLYXD5YlR20kAen1gulnj3zXN0i1H7NPanAF3PEzjsGyml?=
 =?us-ascii?Q?4QVJVxeD1lS9ZHC8cMTkk/vbeoIrxx/vqAC2FI9aTUfsJgXSSi2hCJrwvN48?=
 =?us-ascii?Q?XdGuTrXrjITZDXJ4S4xUXZwJwZGHXFWoUKr+3XpuJtYVk33lV+gWb4/kp0cD?=
 =?us-ascii?Q?BxuedxG0Kar7N3M97GzLXonJWGiafezJ1qDKJRGWCCFZ1/V221Q10qAs6gjk?=
 =?us-ascii?Q?LkfQkPWQdQ3/ZFGNaYw+HHJ/DrcXEN6jvqrMhFYtTwqosP4NZ5XLmM8liT33?=
 =?us-ascii?Q?nShSHZwn8+9s7hI360RxAQwR6o32VyriDEj9uLr2z4R4zpY4pI1yX0Zzb/Kd?=
 =?us-ascii?Q?mum7Fa99AqddwfjZ2KEaS9LQyS9CcgyDY+Y5CvzgO9CythX7Z25viuN3DAID?=
 =?us-ascii?Q?exR7jNP8YmxizbTi4tYWW737pGj8LE/C7j19IroCOWJCQnPxb0LGUW0o4cm0?=
 =?us-ascii?Q?clu1EVLYc8h6hruRJbBVtMpMlXopMSoTOOF0W5KNI6S+AlqmFT4Te6wYEvqi?=
 =?us-ascii?Q?YBowXHb4IRSkgbOUt6Nfzb1+5VGRMNR8w5B6HKOeuO/Lj8y6ySFPpz1QGMyC?=
 =?us-ascii?Q?I5d0//etrYLm2CN4Gbch4zvxkbXwMQlEk98lAAywH+K1/2RD8bopMHawx5fX?=
 =?us-ascii?Q?NH24QRaw1pCfBWpYjeIOhe58NQRH9tF44jgoPfIP5bev+1lPeRPLhZCvfDgU?=
 =?us-ascii?Q?b6K2f0Hsd4qnH/oNJIoKNt3xUziQcCxQNebBCafbqiqbsCp9R4rD8bLRjsT2?=
 =?us-ascii?Q?AVDh8LIVe3OeV1VkAiGNttz3Yavhf0gQmaLrlii6q42U8bushZwVSEsA68Uu?=
 =?us-ascii?Q?/TLQVjzYfXbraIWZ+hpOtkKHVAnXx8VwNDUODClNVSE21GnTSft6gRXvhvfF?=
 =?us-ascii?Q?xNg1w=3D=3D?=
X-Microsoft-Antispam-Message-Info: rXcqNTk+Q+M+6UlpBZ6WQqsnKhUeys8pLnJ647JSG0wc2vbT7B29rnP9S7lZDexANLykbMgee+5d4fCBb2c4k+0ZM90w5N1t/B9zSyPJObQDYsyD1OmP67vEeVbWOhmDANj6nIIg7LBrhPIRfVRGmTXID/byFus0WG0iqoIm8/yEuMDmiyOve0mn4jcVY6uQ0rmMLguGjN+N2sgQkAqlIb80BFPy6wTR0S0/P/fQFKc1NRwMtiD5lzkJufk/NlTHBbUISKBrowuvl+RryqainsVdqHuR8yy9BAFIT28/sqTq/EfpuLtrFfJeZow/6IPVVjMYCxn+LPhA6qXQKGjmdAori7WwIkWIMoEaaxuppe4=
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000;
 6:qt/6gWCUpS/1iKOxLeqBQT0EriMlBXctQghk+077/x1qGg+RdAcCdLi6vXgZr2eXd7VGQjulb8OCWHnxJfbE6bHaPrAJwL0jXBCBAOzFUTvjJGPSJow7b3GqmehEqEblILXuMkbw31YjePEV3p6rBbJAAbziI8BbRFB+8Nw5zBTjKtOyVRID1FIxpB/XtE9/TD6hJlJgOkvqc0WmcMj85hwIa1qskSaXrliXe0FamtZ+fT+1MXaHaEJsYHkSKsGhA1c7zr/Ipjzd15xJ2qYjNIPjxvch6gkjp+5WiOlg3wIGl4Ak22gjhhNFxjCQD/UsnYoKw1I5FpOPtli9X+18wAbfT0dgj1lSngkWGzdNZvZj9cunhh86IAwiXd57FXtS94jHtm2QEk1iqun66Xatj1aOvWrN/YWhPEGIIcNEIakbi6NJ2iVG4c4+EINMbg8nF1pA26v/6sHgVPZHhPtagA==;
 5:u8U4FtlCerxvsUHMod4s1ZRPo7PU+cQ6I6ElI6I5mEnoqjHcQZCEJ3Io+70HFXD56ND85UxZpXFpuqz7GYIIvPVDvY9p6e/rTnfoCjUaaKsUG5pjQw9kR3kW4w2M98AU9fowUAkEUygGroRyFatX3EZD+5DaM0I4ugGGOgItkxw=;
 7:ablj693R5BVakTiX3FEf4wgJltlRvC47dEJLESj1ZD8+F3SLqHa7v+vdb/9TP51nddXFyICnYBE60XWGW7F5HaOgUwJEL5FC3UH06baRXYC3uIrGgIgsEjMOE/g70NLOgF5KT7xpzXNbdGp30ZinjWhv9zyUCbzrcAHjK6sgmlv78R8u1ZksBDuWaMJygbUao80dEr95t0hUe0cUfGKlDhfSMomOyJodebMCycv2CVdICmZybONzsXfadLwtJamr
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 15:38:11.9337 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f9ccf79a-1c69-495f-ba6f-08d5f17b77bf
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5000
Subject: Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port
 start and stop in Rx adapter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2018 15:39:31 -0000

-----Original Message-----
> Date: Thu, 19 Jul 2018 17:17:47 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
>  stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start
>  and stop in Rx adapter
> X-Mailer: git-send-email 2.18.0
> 
> Modifying port state is not necessary when starting/stopping Rx adapter
> as it is same as starting/stopping ethdev.
> 
> Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/event/octeontx/ssovf_evdev.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
> index 2df70b52a..f98296f18 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -476,14 +476,9 @@ static int
>  ssovf_eth_rx_adapter_start(const struct rte_eventdev *dev,
>  					const struct rte_eth_dev *eth_dev)
>  {
> -	int ret;
> -	const struct octeontx_nic *nic = eth_dev->data->dev_private;
>  	RTE_SET_USED(dev);
> +	RTE_SET_USED(eth_dev);
>  
> -	ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> -	if (ret)
> -		return 0;
> -	octeontx_pki_port_start(nic->port_id);
>  	return 0;
>  }
>  
> @@ -492,14 +487,9 @@ static int
>  ssovf_eth_rx_adapter_stop(const struct rte_eventdev *dev,
>  		const struct rte_eth_dev *eth_dev)
>  {
> -	int ret;
> -	const struct octeontx_nic *nic = eth_dev->data->dev_private;
>  	RTE_SET_USED(dev);
> +	RTE_SET_USED(eth_dev);
>  
> -	ret = strncmp(eth_dev->data->name, "eth_octeontx", 12);
> -	if (ret)
> -		return 0;
> -	octeontx_pki_port_stop(nic->port_id);
>  	return 0;
>  }
>  
> -- 
> 2.18.0
>