From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 3DB733772 for ; Wed, 25 Jul 2018 15:23:10 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id n11-v6so6001163wmc.2 for ; Wed, 25 Jul 2018 06:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B58v3LklaLY3zeoBPo/724WHD9DLWo8qiGOK/cgTRSM=; b=RXcQl0/xJXlBcPV2kJd38A5FGICuN8n5o58yz9CN2gL4TBcMxpT+a7UQ7N5TR+ZS7G jzKD4yhwbNARLai48UotKwJvehhW6POWJKtE9ASRKfWHYItpg3HdCkwKiV0PypBMmNVD IQjke/rUqKjlWqv3NoWMGLcF8FUvMVvhSPNcpMZ9qoouHyr4v/B/ro4CVNVWBhcew9Pi vwLh+QCBpo8mRIlQBqkYhiGq8aul7Kpp5EJA7dz5avEzcpCfo7+fNtHavc30EbFveDrE t58yO/ZWuPxiKY8TmOfPcAQ1eCpcaviQ4T3Ezg4Nft6+SKLjcquiUDxvO3KWac5BW3Fh 9HnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B58v3LklaLY3zeoBPo/724WHD9DLWo8qiGOK/cgTRSM=; b=A8Dt+7nfI0ENMw9voFkLcRYyhTVFW6dks1mwlZVMYqHn8jvCkZA0t0CT/+C4X4vTdX uXiTaIYcKkCD7R64atAkXNKyTLgCu71ajnV7n2TRs87b1B8Ei3k9EGfVrEafEO2QXG/j McicpPJjbCnEPI6oDPJTrUokfxSCfV4WmA9gVqAr3EZaslBjzNVEiz4uw8owMCsJohp1 /XBF6crsyYTL1D3p0J9f3NdhbIQutnJtVbzS6X2LmiGCWrOX7jDSo2NJwNNtjs5qWjv3 g3C8tJhYBK4ne+WfPIa1ZMBB/wL0SGm1sL80ZzMJRUqROVyRngsD+K6KD4VpSTwHd7Gl XuZg== X-Gm-Message-State: AOUpUlFAaKa3/8TpkhP+Nzm2YfeWuIvwVrQc9Ivu9UBj76wb+GW+yTzW Rf5glWGyGtrY7zAtp3amB7kN0A== X-Google-Smtp-Source: AAOMgpf4mYllcUqonfe/f1fvpHKwMeIEfmqnShRtsmU0Ogj3IMCq6YYas4qL+cR4l1ufOvcEh9buUA== X-Received: by 2002:a1c:6a0b:: with SMTP id f11-v6mr4562902wmc.107.1532524990001; Wed, 25 Jul 2018 06:23:10 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a9-v6sm10775341wrp.55.2018.07.25.06.23.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 06:23:09 -0700 (PDT) Date: Wed, 25 Jul 2018 15:22:52 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: yskoh@mellanox.com, dev@dpdk.org, Yaroslav Brustinov , stable@dpdk.org, nelio.laranjeiro@6wind.com Message-ID: <20180725132252.GX5211@6wind.com> References: <20180724085445.52206-1-shahafs@mellanox.com> <20180725131854.51881-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725131854.51881-1-shahafs@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 13:23:10 -0000 On Wed, Jul 25, 2018 at 04:18:54PM +0300, Shahaf Shuler wrote: > From: Yaroslav Brustinov > > addressing a gcc 4.7.2 bug that cannot be reproduced with latter > versions: > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in > src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o" > > Fix it be forcing the alignment of the glue lib. > > Fixes: 0e83b8e536c1 ("net/mlx5: move rdma-core calls to separate file") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com > Cc: adrien.mazarguil@6wind.com > > Signed-off-by: Yaroslav Brustinov > Signed-off-by: Shahaf Shuler Except for a couple of minor nits below, Acked-by: Adrien Mazarguil > --- > On v2: > - Forced alignment using alignas to the size of the cacheline. > > --- > drivers/net/mlx5/mlx5_glue.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c > index c7965e51fe..705232f614 100644 > --- a/drivers/net/mlx5/mlx5_glue.c > +++ b/drivers/net/mlx5/mlx5_glue.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include You should keep alphabetical order. > > /* > * Not needed by this file; included to work around the lack of off_t > @@ -23,6 +24,8 @@ > #pragma GCC diagnostic error "-Wpedantic" > #endif > > +#include > + > #include "mlx5_autoconf.h" > #include "mlx5_glue.h" > > @@ -343,7 +346,8 @@ mlx5_glue_dv_create_qp(struct ibv_context *context, > #endif > } > > -const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue){ > +alignas(RTE_CACHE_LINE_SIZE) > +const struct mlx5_glue *mlx5_glue = &(const struct mlx5_glue) { Extra space added before opening brace :) > .version = MLX5_GLUE_VERSION, > .fork_init = mlx5_glue_fork_init, > .alloc_pd = mlx5_glue_alloc_pd, > -- > 2.12.0 > -- Adrien Mazarguil 6WIND