From: Jens Freimann <jfreimann@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org,
lei.a.yao@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] vhost: fix overflow on shadow used ring
Date: Thu, 26 Jul 2018 09:33:42 +0200 [thread overview]
Message-ID: <20180726073342.vp2m5hqrbhu4rma7@jenstp.localdomain> (raw)
In-Reply-To: <20180726013721.30200-1-tiwei.bie@intel.com>
On Thu, Jul 26, 2018 at 09:37:20AM +0800, Tiwei Bie wrote:
>The shadow used ring's size is the same as the vq's size,
>so we shouldn't try more than "vq size" times. Besides,
>the element pointed by avail->idx isn't available to the
>device, so we will return error when try "vq size" times.
>
>Fixes: 24e4844048e1 ("vhost: unify Rx mergeable and non-mergeable paths")
>Fixes: a922401f35cc ("vhost: add Rx support for packed ring")
>
>Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>---
> lib/librte_vhost/virtio_net.c | 37 ++++++++++++++++-------------------
> 1 file changed, 17 insertions(+), 20 deletions(-)
>
Reviewed-by: Jens Freimann <jfreiman@redhat.com>
next prev parent reply other threads:[~2018-07-26 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 1:37 Tiwei Bie
2018-07-26 1:37 ` [dpdk-dev] [PATCH 2/2] vhost: release the locks when failed to make RARP packet Tiwei Bie
2018-07-26 7:22 ` Jens Freimann
2018-07-26 7:33 ` Jens Freimann [this message]
2018-07-26 9:00 ` [dpdk-dev] [PATCH 1/2] vhost: fix overflow on shadow used ring Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726073342.vp2m5hqrbhu4rma7@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).