From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0083.outbound.protection.outlook.com [104.47.41.83]) by dpdk.org (Postfix) with ESMTP id 2890F5592 for ; Mon, 30 Jul 2018 13:18:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UKvlyh1yn+zdieENtfH7UQj7labca3VYM/nGixRkXEE=; b=gVTYoduY1zNZX1wFFLa7FfaxGn6Af8+Uh2TphpOCRIzSUDgP2F9XQH/aQoLgBfNM95FKueX1WqyBNW1mbixvbxg8NrEeJhZjH2IBQ6YxiSESSeeZnnoPcelUS3156dioNOkVEFAYKaT1aBG+LTCyMebnMyq62lIVZ9UVEEOHyxI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (50.233.148.155) by DM6PR07MB5001.namprd07.prod.outlook.com (2603:10b6:5:25::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Mon, 30 Jul 2018 11:18:32 +0000 Date: Mon, 30 Jul 2018 16:48:25 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" Cc: Thomas Monjalon , "dev@dpdk.org" , "Yigit, Ferruh" , "shahafs@mellanox.com" Message-ID: <20180730111823.GA30059@jerin> References: <20180729124409.3669-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB977258DF51F641@irsmsx105.ger.corp.intel.com> <20180730093555.GA22823@jerin> <1687236.JLa48GYJ5r@xps> <2601191342CEEE43887BDE71AB977258DF51F702@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51F702@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [50.233.148.155] X-ClientProxiedBy: BYAPR07CA0013.namprd07.prod.outlook.com (2603:10b6:a02:bc::26) To DM6PR07MB5001.namprd07.prod.outlook.com (2603:10b6:5:25::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7072c32-70e2-434a-cb32-08d5f60e306c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5001; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5001; 3:jct1Jw2Hp4zMoOlsOmdtYYL2ltqw+d/X5129sSIB/FBHKFHHMTilXJHyI8aeKNl9ovU4pksagcxcNd7K0uLp0aJFxIzGSuXwCm6wkY0NFkZQ+0Iu9Gz0bp9ep1b9UO4O3r1oOXWjXFEcdNji9J6iAqWOh02nOhSAqjvwDIMiH5Po/2hgZ1+9tKYZvtE6uB6HYv7hCa0sIXNH038YHl/K3wOCfvpEMn2z2lu5D2iErxKgNp40NpulOG5amoOHIdmr; 25:T8Q/O98KYZhm+6nRlYd0mVWqisfAsvJm80KEsxW8MHqaTIW3JUa02owD55u7R25iioNkXBJMn5eXKxgmYGgbAuQEcask13fbozdMic6KFKiCp2xqjjOCVbF7D4Y+K9bfy9fBP69B3HjKXC6B8bGlpD3nAZZn4aDBeC1T92BFxqFUnwZKmbCazD55XyneRFAyXqJbeQ9kMq0OFMmiLCf3MeY7HqxivtruN/LeFHrPSTh9RAvZRwAiZS+rxCmpnzlg+1svmY9F7kyOoOIJcc+k2cCmeWwg7NUsJ+LuaQjHhXi5ZQWnBup3joY6FVIzTR+aqy563gC9TzjVbb1nTwlPVg==; 31:T3ELCs2OeTdB4pRH12nuhanFUot0jgw16+mQpe3HKfTgqbuct2V2bscd5JJVeW7Af5g96rHw/8ClG3cC+iuzbheMywupcxguz4SmO4l4WCJkyio5Nec26m2uYzQwCVZ8rjb2FhzszP5G1QDTsIO1t8SBuwRA0hVuOP3jiFp53DEkaEPYpI8ZfBM+0iNEvlMnnv4CfyPyEXEkBj/7HoXcm6j2Cdq/5sTe/W/HjD2ggd4= X-MS-TrafficTypeDiagnostic: DM6PR07MB5001: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5001; 20:ugfeA06F1bLwGJE3l6bNODtiz0lb3KarhiqTSPAymX3kYMSbCRHc/2y1zfU5IhcuvWtM0ybI02Z55GNr2DkR3XidNY1xkB21q5Sc4ATDpl0ww3twKYDYiH6dHXECyw57OZ5EYQWttUE13YZxnUs87PUAneRZPHhtsozknEYBGa4wIHZZQtJVxugGWM2eGOug0vgqdE0nni3j61FDa2rHCWXSWHIDg3pgMXgg2eqaV5W5xLX5DbuEbepom8dkMANTjPpKgdZRcYkuwn206vG8iochYcIAtLkBLEaYfGgVmrGSIQbbaizu4/DuE3B/QvOXeQrT8XeocxibUr74y4JLfjKZSdpQnLyk8imMhOqQF5MQIZEOTQUd05f6/krRvYEUVJ2QJwSVExjL8rp4ri8F+eEiEM/+PXBrLdnaDg2qwVeO7rRvWQz3hnt2DKA5MyAWoCDREFfR/DVQ5N4vINSXor86cXpNLbL/Cwdpi3QZGR/4Fz5pxGdUvNmwQiLYCwiq6ZDdpRxFAPHZKH+iQwsXVQ4wV0q1+gjI0c+BEbNOzOVnzzTJzMRm6+G7122aBzNXYyCZBz9LLBgERhFIlP32LqEV7MwEDaAcRYDWKsMK3Ww= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(17755550239193); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM6PR07MB5001; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5001; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5001; 4:Cqzux4DlvL9JZTuaubeRKn42cJzMtuULVU8yVk6sYuo2qTjdTY9584zlcYGZGqxk/0PJyd8RrHViJgmJLkLuE5eFnwTllwlseHpQoP+LVhf93Tlewq6YucJUFAqkta/F995kBLTAETeFHF0IstWgMkKGMLjbyGR2+xspZb8mzRi7Qhw2PynhWb4P+f1YnuRlH+y2asCmtWWtMGJ5rX3YsnloKqSVvVPw4Bbh7UP+C3/3w58uVoN5PIDI6Js+DTOk5/+a0WfxGI1y34ouW0vKpkpom2pay1+6BXZ460U5glyteUs4HJtyt/zqdgqKoTY5fEUKRUBpUJ9g76E9jZ63up45H0UXV0GwTuytS8xU19A= X-Forefront-PRVS: 0749DC2CE6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39860400002)(396003)(136003)(346002)(199004)(189003)(13464003)(8676002)(72206003)(76176011)(5660300001)(6246003)(8936002)(53936002)(52116002)(476003)(81166006)(106356001)(81156014)(33896004)(58126008)(16586007)(316002)(305945005)(956004)(105586002)(6666003)(33656002)(229853002)(42882007)(7736002)(50466002)(6116002)(446003)(54906003)(6496006)(26005)(97736004)(486006)(2906002)(44832011)(386003)(53546011)(478600001)(6916009)(9686003)(68736007)(186003)(66066001)(47776003)(14444005)(16526019)(93886005)(55016002)(11346002)(25786009)(1076002)(4326008)(33716001)(3846002)(23726003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5001; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5001; 23:CD2TdfVWigHxUYY7UKuX1uK6trRa3JWHLlSwg4drR?= =?us-ascii?Q?hfRwYmfDyIJLAuLxmwXRlMo3A7DZZBacM1GZyRK12fKlRmRLm8bpSf2hynWV?= =?us-ascii?Q?UK8DxinrEugClLSM/TuGiar5mILRvbYcrYUZBnhhcGrwbMrzB0fckE1gqUvH?= =?us-ascii?Q?hMW9Zvl+hgQXRzjII3e7IdP/2ca/HDiEhc1gRhEcenrpAvM64AhBqNPExYTK?= =?us-ascii?Q?Ny2+sFEnHbfXM4SEXtvu92Eup+E6WeMC5RkWl5bBhYgewMljVHgbiFxs7bJR?= =?us-ascii?Q?dKjK7KjoQsZWCGKJPXxSCp/NfET9nJdii0ECRqxRot1rwNA7qx4JZ3m1lVGE?= =?us-ascii?Q?BWyyYqK0c7Iise+kqJlrborcjlJmYg9MRDGB/lzS/fV4HO0xm6e8XbHd0Jt0?= =?us-ascii?Q?0DmtQCUOwkqYpF/03MFuwdHhNiNVC4alE2ANpTA/7AeKn0r5ylNFahSOF/CE?= =?us-ascii?Q?stJs9FxQsmVcV9vvvaQU+n+ggzdq93GpR2UYyI7wrQSk3Pn1f+Pwejwzv4x0?= =?us-ascii?Q?D5FTuXGHPljyfyf2rhWP4TYI5J44siPCc9bGhT/fUkLn8SJ9uPq34EtC+xas?= =?us-ascii?Q?e9zEQ7IsKSS07WAdWt6p/B4GRlX7H0fHX11v0TAg9EXOiuoliXX7ZMO+bodH?= =?us-ascii?Q?sT//+11Dx7oxtujCfdGXZvS0DAmkDGnVyJprf0a5e+Du0+tTi5pbk0LF3rgx?= =?us-ascii?Q?AXFp9Uhw/4s3FFTqS8S8oMXCEQl8hkQ1zUb1TUVWy6w+mH9cAhjNJsy0A6p+?= =?us-ascii?Q?rheqrj63EpgwaOZz91XeZDZZEYnQSLt/KpFCRFZs/bQ727wHlnmffU4M2RIg?= =?us-ascii?Q?C+GHFJa0/UwyeQnFSxJsLDTfW4ZZEZuNUbjAo/YtzFIqzTBUDGBGixG8gRZ3?= =?us-ascii?Q?8CnyY23BxGMhecjnHM5RWpQJ7Ldm20YPxX0amK+QJ/CLJ5OOP1v7NzIq5vyE?= =?us-ascii?Q?SXJbWKDSA4fXp11F6eRxj7Pp/gN19Jq20C8xtyAYYVUOqi3i0UV7sOyfRZzP?= =?us-ascii?Q?Jp3vdfuvPr07XH16asHho4AsXk2YcFL6vyXu2pPPLjTSn5Peo3HUnMrlXuDo?= =?us-ascii?Q?i++qsaddTQxfYfJWv6fp5DpKfgpySfY9pqPR62wNaAgUI2r/G19nCwsLHixY?= =?us-ascii?Q?aSpT3pop7DjY71XyHN0nRmxxJ14nU2YQ2L9LQ11eu9yEgogASuoJSFbScxzz?= =?us-ascii?Q?AzgVtkPqIzgBI85wOZhOZ1GaIWBw3YXtBLESRVqdnSGXUBB8AC/GF+0zUR1G?= =?us-ascii?Q?KVwFU1aZgV4orzsx4GQnxdMw68HdmoPV+83F2lBhxqtUORrLUDELD65aZCya?= =?us-ascii?Q?lrGQT7uWdsgHmW6E2SCLdv9l3zsOWJQJOC9m6WbkC5+8XemfZbBHsgzR1m8E?= =?us-ascii?Q?807bb4BqFk62uBJlKj50bDvkiOY2u6y72SwHV+lxjKmZQY0?= X-Microsoft-Antispam-Message-Info: RUqGw9UASgd3iIH+5/WtFsvKvr1NGjb9O4xdOdgQ6a9le1Qc1vNV/uLRs9whhd5TD0PvHbOd/z9MQN40dhr1KZaUBa88A114pqzJRS1kUR51rAitBnDxgIDsDmMgfyMb07bdYH+iX/TbCYGX2s0ohKrsqy3TiBDHiENtBLFhhCiRepPgaSX++iMOG6X3HAORjrHpSX3d0yY4xdPr3meBcE0TZ9Px9bemCSw+yPWCbbpGCIt/6Blzb26/AXBlSGasp2gskwTABCACJrUBbHGXlUpEQtVECm+Ep82YymsyC3b4uD8I8CABr+WuxF0YArqx+uofHE0d3PR04C9hutTsshbKqK7H0/K1AxGYf0p8mr4= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5001; 6:G6tGJ0BCikapLmC4XMhlngQxKBJyhQockRez2QJxvg/y2B+OpF2ibLrPBouztgMdC+eevuqYmpk2qeRXnIyo7u1LgDP16TkOC9RjZRNRntXrGN60hYNWY4gu94goDtwLRiRwQNuW+xywbFfltjpPTiRj/0FvUVSBAO2U7nCIL0rf2FdzXv5VuXxYvcFVgg0fBo38WZJBgPCHQf9Q2twnEnoT18SOElGKDAmg/PeokESWKh7FrHn1ARaSMWZ7QSnMQbghOy6mi3h/lbI60V4DS5KTxtcnKiHuI4xWIuK38CaJJYMiek7jX3n5uBtEzZ2gFdtfSSvj393juxaYfQyjTxcLBVdHMD6Ta5y00NSNTb9VXos+5IlwCP5FCsWYMgC3yYxsj1NUWiPZ0bDBhYRA+bXkdaXXCPuwNKBltTyKXPLj/TX+1HvnLCuxIXqshRqNBDaRY9eUaG4RWO5J5ejGIg==; 5:H4/8P14pN3smUl5is1vw0irdUjx6VaTa7JFQvP+0uW9hhk3EGDHVsg0IbFvMB+9aF0SfvJCOkYrzv5wjipW5Re/YBYQfcVkJj1P/IhIFeGGlHXfDWAFCWP1rOkNI1EHNewBR14WKwbhQcrsGdNdPZazxEwd/2liThwfBChoTfQQ=; 7:bbQv/YZEDUvypZCmOuXtXEzHFN6dBnWepA+/7eI5GTIAPpV+FtGKLtDdm5XygDFPlYiUqWI6mUnhK844nwOJBmej7Qy2+hFqA5XV6QVcv3ZiJXkmiW5wEFph3ordvFGzrPqblyREGD5vuncS5IGnFRNW0Z0eiutxurvLzMaQPhILrhfNcehsEDqj0D93YNpJMs331AnYdzoyHEmdifw13htARnfDgGvPC5jM554eicYrDOHPPyfEsPzhRlzsD07I SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2018 11:18:32.0676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7072c32-70e2-434a-cb32-08d5f60e306c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5001 Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 11:18:36 -0000 -----Original Message----- > Date: Mon, 30 Jul 2018 11:00:02 +0000 > From: "Ananyev, Konstantin" > To: Thomas Monjalon , Jerin Jacob > > CC: "dev@dpdk.org" , "Yigit, Ferruh" > , "shahafs@mellanox.com" > Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > External Email > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Monday, July 30, 2018 10:51 AM > > To: Jerin Jacob ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Yigit, Ferruh ; shahafs@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > > > 30/07/2018 11:35, Jerin Jacob: > > > From: "Ananyev, Konstantin" > > > > > > > > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > > > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > > > > > > > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few > > > > > cycles if possible. > > > > > > > > Personally, I'd move in other direction: keep RX checksum offload and add > > > > checks inside sample apps to handle (drop) packets with invalid checksum. > > > > > > OK. Till someones add the DROP logic in application, Can we take > > > this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM > > > without DROP or any meaning full action in application. > > Probably, but at least it gives users a right estimation how long the proper > RX/TX routine would take. For estimation, application can add any flag they want in local setup. It does not need to be upstream with out feature complete. > From other side what the point to disable these flags now, if we know that At least nicvf Rx routines are crafted based DEV_RX_OFFLOAD_CHECKSUM flags. If driver Rx routine crafted such case it will be useful. > we are doing wrong thing and will have to re-enable them again in future? But it is not correct now either. Right? > > > > > If there is no patch sent to use this offload on August 1st, > > then I will apply this patch to remove the offload request. > > > > Isn't it too late to do such things right now? > We are in RC3 stage and doesn't look like a critical issue. Yes. We can add it when have we proper fix. Currently, it signaling a wrong interpretation to application. > Konstantin > >