DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API
Date: Thu, 2 Aug 2018 08:14:44 -0700	[thread overview]
Message-ID: <20180802081444.1211cf79@xeon-e3> (raw)
In-Reply-To: <1533213223-24028-1-git-send-email-ktraynor@redhat.com>

On Thu,  2 Aug 2018 13:33:43 +0100
Kevin Traynor <ktraynor@redhat.com> wrote:

> Change log level of messages from ERR back to DEBUG where
> existing API indicates that the condition is a success.
> 
> This means applications using the API in its current form will
> not get new ERR logs.
> 
> Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

The expectations about level come from syslog:

       LOG_ERR        error conditions

       LOG_WARNING    warning conditions

       LOG_NOTICE     normal, but significant, condition

       LOG_INFO       informational message

       LOG_DEBUG      debug-level message

Therefore messages where an API did something wrong should be NOTICE
and messages where an API's normal action was successful should be
INFO or DEBUG.

All the "already XXX" messages should be NOTICE.

  parent reply	other threads:[~2018-08-02 15:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 12:33 Kevin Traynor
2018-08-02 12:59 ` Andrew Rybchenko
2018-08-02 13:35   ` Kevin Traynor
2018-08-02 13:52     ` Andrew Rybchenko
2018-08-02 14:09       ` Kevin Traynor
2018-08-02 14:41         ` Andrew Rybchenko
2018-08-02 14:52           ` Kevin Traynor
2018-08-02 16:14             ` Thomas Monjalon
2018-08-02 18:01               ` Andrew Rybchenko
2018-08-02 18:27                 ` Kevin Traynor
2018-08-02 12:59 ` Andrew Rybchenko
2018-08-02 15:14 ` Stephen Hemminger [this message]
2018-08-02 18:33 ` Kevin Traynor
2018-08-02 18:39   ` Kevin Traynor
2018-08-02 18:39 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
2018-08-03  8:04   ` Andrew Rybchenko
2018-08-05 13:29     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802081444.1211cf79@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).