From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id B7A721B5C4 for ; Sat, 4 Aug 2018 00:17:23 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id k21-v6so3920822pff.11 for ; Fri, 03 Aug 2018 15:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZDX7Lt7tM3eGnsHHHxArDAIPCTYLnSWvDTkt2ObNw10=; b=DEDphUyJP5sJF98jve8n7qb/V7RpUqwXRiZhxrZyRThMCrNpI6R61TUm5Q8m/9dIXe GJqu7kg/bbkp8jy7g+4XeEK1Ad46Ylmo5Mz0UygV9u0zkKjoCUNYIGvC08Zz/Wplni5I u3mGGGQowq1B1oPe6aTIUA2ailTw0yLZjlg5re84FvDSpDiIBeNXefYwUtLOSx8PNTDi LmqOD0h+XO+z2l34ULqIqQR9VtRUlXar9y2CD8uUy7gUU7Xb9FDRYrqQTA8pcJjBPky1 LzEIqjQoCIkiSWXuz16QfkaiNpf/zs3+qMMRRPkzsli9CGOZyASgZAdRKIbVSRv3R8QW rcYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZDX7Lt7tM3eGnsHHHxArDAIPCTYLnSWvDTkt2ObNw10=; b=PV3qndXULzifyxHOa6YmJiEA1q+hksnyM+Uo+/UZgePZzRtDqUL9xOu97yBdeW+/6B rwNa+/vuinPdeV3OK7ABzwUrG5B3ten7WrWvhCjTjB5gk1sQXIpb0A7PbUrQPKqc9lzh pcxLrbSx5iOoax3W3jt/WxJqxnTig/SvYXecJeyhph+EhyL7KC8viy42VstTWPDttgi9 xeZm99jB0kYz2Yd6IgJ0DnHOzNIfzKJraj6EMMcDw0s/8g4tn90mFVUhPExj4AAt7+m9 vcNUNZKPG3PVtxFz609zb1uD008Zr96yTcqXIiAyGeY432fm7syUEiOX+04kvYdG+Ha5 INsg== X-Gm-Message-State: AOUpUlF8ajTc/9689LzMbFwGiLmQcT8fcv9Jaz5304NBMsFh90pSi/BH dypjNwxbpL7sqlFDtiUu5Hxd5yFZ5Xw= X-Google-Smtp-Source: AAOMgpcLN4w1Ma3StnRhLa+U0WyW/xl2S6BkF1YLxIvuRjOBG88X+2jE+qGBO0UBk/P9rrUQQwiNvw== X-Received: by 2002:a63:c742:: with SMTP id v2-v6mr5372393pgg.331.1533334642678; Fri, 03 Aug 2018 15:17:22 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e8-v6sm10114441pgi.24.2018.08.03.15.17.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Aug 2018 15:17:22 -0700 (PDT) Date: Fri, 3 Aug 2018 15:17:15 -0700 From: Stephen Hemminger To: Gavin Hu Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com, stable@dpdk.org Message-ID: <20180803151715.4197d43d@xeon-e3> In-Reply-To: <20180801052257.14869-1-gavin.hu@arm.com> References: <20180801052257.14869-1-gavin.hu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devtools: trap SIGINT is not recognizable to dash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 22:17:24 -0000 On Wed, 1 Aug 2018 13:22:57 +0800 Gavin Hu wrote: > When running checkpatch.sh, it generates the following error > on some linux distributions(like Debian) with Dash as the > default shell interpreter. > trap: SIGINT: bad trap > > The fix is to replace SIGINT with INT signal, it works for > both bash and dash. > > Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index 2509269df..ba795ad1d 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -29,7 +29,7 @@ clean_tmp_files() { > fi > } > > -trap "clean_tmp_files" SIGINT > +trap "clean_tmp_files" INT > > print_usage () { > cat <<- END_OF_HELP This patch alone is not sufficient to make checkpatch run successfully ./devtools/checkpatches.sh: 52: read: Illegal option -d It looks like the -d flag to read is also a bash extension. I recommend changing both checkpatches.sh and check-symbol-changes to have #!/bin/bash