From: Thomas Monjalon <thomas@monjalon.net>
To: nhorman@tuxdriver.com
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: [dpdk-dev] [PATCH] devtools: fix symbol check for dash
Date: Sun, 5 Aug 2018 11:38:47 +0200 [thread overview]
Message-ID: <20180805093847.12935-1-thomas@monjalon.net> (raw)
In-Reply-To: <1801169.BELgHmehf5@xps>
The script check-symbol-change.sh was not running when
/bin/sh redirects to dash.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhorman@tuxdriver.com
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/check-symbol-change.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 40b72073a..daaf45e14 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -4,8 +4,8 @@
build_map_changes()
{
- local fname=$1
- local mapdb=$2
+ local fname="$1"
+ local mapdb="$2"
cat "$fname" | awk '
# Initialize our variables
@@ -80,7 +80,7 @@ build_map_changes()
check_for_rule_violations()
{
- local mapdb=$1
+ local mapdb="$1"
local mname
local symname
local secname
@@ -89,10 +89,10 @@ check_for_rule_violations()
while read mname symname secname ar
do
- if [ "$ar" == "add" ]
+ if [ "$ar" = "add" ]
then
- if [ "$secname" == "unknown" ]
+ if [ "$secname" = "unknown" ]
then
# Just inform the user of this occurrence, but
# don't flag it as an error
--
2.17.1
next prev parent reply other threads:[~2018-08-05 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 15:14 [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash Stephen Hemminger
2018-07-31 16:01 ` Mcnamara, John
2018-07-31 16:31 ` Stephen Hemminger
2018-08-01 16:06 ` Thomas Monjalon
2018-08-05 9:38 ` Thomas Monjalon [this message]
2018-08-09 12:14 ` [dpdk-dev] [PATCH] devtools: fix symbol check for dash Ferruh Yigit
2018-08-09 15:14 ` Neil Horman
2018-08-09 16:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805093847.12935-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).