From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1A6DD1B5B3 for ; Sun, 5 Aug 2018 11:39:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 64C3320F12; Sun, 5 Aug 2018 05:39:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 Aug 2018 05:39:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=45BPyDxcg4d5rt HFIFDNRMnKtBudxaQYo0S1E5lM5VI=; b=QmCVSP6ZnCRhIbdIucbbVLXlBvXlbe SML0CKwxtfZ8ux3+tv3t1RYUZIoT1EwYJCtZ04yfKPdogoTIlQE16QOQeP18PoRC dWD9zaCHxvmRF+mw8nY2SYGobXNB0aun1SFA2QM93ytshyIrj60CsdtLRPMWmIvM 8/R73y+4jtrVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=45BPyDxcg4d5rtHFIFDNRMnKtBudxaQYo0S1E5lM5VI=; b=NTFns6he EF2zBJSXp87qLq8657IxBxUjehRQOXfXyxvVLuzzkClhf5c00jNFPMBZDIApyHQ8 s3FzHFymhZpcWXAuMlU8kf8r7Onm9StucFjLRx7ONkLblkWKz81C9UQSS1Lbclaq 9TVFzSEFv8Rb6HdeF9/vH2C8hf61N3BvZWggK6cCOycr6znbpzYst0p7XBm3IFmN WRohGlGgdG0ykE5i27IVxd669c9l+KVl/vCAeN6eqRNgLcvVhl2Tb/qbMVEOSlDr y3VPbQSZ8j39EiCKqKYvDuzTQv4GffJnCun3/sIC7cZCr4Fpg0Bi3IoCcMU3fLYD vb8dbghLVDQVxA== X-ME-Proxy: X-ME-Sender: Received: from xps.monjalon.net (247.15.136.77.rev.sfr.net [77.136.15.247]) by mail.messagingengine.com (Postfix) with ESMTPA id 95A30E4636; Sun, 5 Aug 2018 05:39:02 -0400 (EDT) From: Thomas Monjalon To: nhorman@tuxdriver.com Cc: dev@dpdk.org, stephen@networkplumber.org Date: Sun, 5 Aug 2018 11:38:47 +0200 Message-Id: <20180805093847.12935-1-thomas@monjalon.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <1801169.BELgHmehf5@xps> References: <1801169.BELgHmehf5@xps> Subject: [dpdk-dev] [PATCH] devtools: fix symbol check for dash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2018 09:39:08 -0000 The script check-symbol-change.sh was not running when /bin/sh redirects to dash. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: nhorman@tuxdriver.com Reported-by: Stephen Hemminger Signed-off-by: Thomas Monjalon --- devtools/check-symbol-change.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 40b72073a..daaf45e14 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -4,8 +4,8 @@ build_map_changes() { - local fname=$1 - local mapdb=$2 + local fname="$1" + local mapdb="$2" cat "$fname" | awk ' # Initialize our variables @@ -80,7 +80,7 @@ build_map_changes() check_for_rule_violations() { - local mapdb=$1 + local mapdb="$1" local mname local symname local secname @@ -89,10 +89,10 @@ check_for_rule_violations() while read mname symname secname ar do - if [ "$ar" == "add" ] + if [ "$ar" = "add" ] then - if [ "$secname" == "unknown" ] + if [ "$secname" = "unknown" ] then # Just inform the user of this occurrence, but # don't flag it as an error -- 2.17.1