From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id AC4DE1B4DA for ; Mon, 6 Aug 2018 15:16:44 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id o11-v6so13721773wmh.2 for ; Mon, 06 Aug 2018 06:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8hKb/sZ3OQzbOaMzJbin+wHpOBb6rnfLzEUC3lc1hZY=; b=rsxRTUlgJ2QjT+VBrW1zsya0L++scfcv0104yI5HLwD3+8HkhfpMGvJr/NWlWCL8Yo OKe/lqNHeorxaeEa4Gq56j+9jX9uDydwupe7ndRTx+s5mweEznmXzaJa76ndIlpVvCsx +MMvJI2AWHv0fxUqgjF82xtuH+emsCWblD7+8D8Ec9TDsN5q3jsu30OlPVmDUUtCBuOi Yz8+86yPXkAMN1OfgTS6okOZBg2Oc949Dut9dU+B7UhlIBjuGk22VEoR0lPoAFkXS9DD Mru+2FoDcEcof5mK5FePVMn+vWOFgrcIAbVcor+c7cymOBVCjLrSTUani6bxxVnTqPnf 8RcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8hKb/sZ3OQzbOaMzJbin+wHpOBb6rnfLzEUC3lc1hZY=; b=D7yq8oqQkBdleibS6TdcaeiYirOz7+Pb50Kl7kTts+V2qGb7ntZxzzTwMc3v98U0Gq Tu9ikZB786qf6KZ7C+WfPVmIFu9DyoYcWIl/fVrZMMxxCsDIsdAeldUMu+SHFxEn4dnF c4DhAHDfjkPO3pqYtMTeFuivQ6SYUnZdPfxhMQ4ElF676mjbo4+DZyZoOxsR0dolKVt7 7/uCj1cEsrO90bDomUpO0B3C85ANpBwR60Ht4vZc/7Qr+qTRT73MJuHvJRdaUAb+EVkE tqEAqOohJ4ul9C0Sx6EMPsFtizSXvjUxYgNT9jK0Q8MAp9dWxW70NcjYi/KQmPvxvoc4 sTAQ== X-Gm-Message-State: AOUpUlFZdnBPyaKvsNDuZijKTJn0oIJCZfEvkAf4jmJ0fwj9QrcFDDaS Irnk3Gd+gfC7s48ul2lfazDZ+A== X-Google-Smtp-Source: AAOMgpeKHTlqcsJjJbYxQtdka7t6ICIQRWusCuIGednOsBir4kOJfp5u66aJbbkoS1g/bamuu85ceg== X-Received: by 2002:a1c:9d0b:: with SMTP id g11-v6mr11815797wme.78.1533561404318; Mon, 06 Aug 2018 06:16:44 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k12-v6sm11151491wru.38.2018.08.06.06.16.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Aug 2018 06:16:43 -0700 (PDT) Date: Mon, 6 Aug 2018 15:16:26 +0200 From: Adrien Mazarguil To: Matan Azrad Cc: Keith Wiles , Ophir Munk , dev@dpdk.org, stable@dpdk.org Message-ID: <20180806131626.GW5211@6wind.com> References: <1533205980-7874-1-git-send-email-matan@mellanox.com> <1533553127-18664-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533553127-18664-1-git-send-email-matan@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix zeroed flow mask configurations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 13:16:44 -0000 On Mon, Aug 06, 2018 at 10:58:47AM +0000, Matan Azrad wrote: > The rte_flow meaning of zero flow mask configuration is to match all > the range of the item value. > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > should much all the ipv4 traffic from the rte_flow API perspective. > > From some kernel perspectives the above rule means to ignore all the > ipv4 traffic (e.g. Ubuntu 16.04, 4.15.10). > > Due to the fact that the tap PMD should provide the rte_flow meaning, > it is necessary to ignore the spec in case the mask is zero when it > forwards such like flows to the kernel. > So, the above rule should be translated to eth / ipv4 to get the > correct meaning. > > Ignore spec configurations when the mask is zero. > > Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad > --- > drivers/net/tap/tap_flow.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > V2: > Address Adrien comments to fix also the spec=0 check. Thanks, Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND