From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 3A440F72 for ; Fri, 10 Aug 2018 09:23:38 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180810072337euoutp011c706eedacd141133c97b180b0920252~JdQZEVBjT0977809778euoutp013 for ; Fri, 10 Aug 2018 07:23:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180810072337euoutp011c706eedacd141133c97b180b0920252~JdQZEVBjT0977809778euoutp013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1533885817; bh=ijchsqb37BMSkuIXEwjn+zkLDLVYUThnA/HcG2MelV0=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=Ol1HjFXHArQDW3n2FIS3JF0cfY3wRHeSMLvuR68jhgMlf4We+6p89s/BWeNZpLvs5 ayYePSWqwI0hZKKuLr4z4m8Je1tHFeHtsjVjdrWnicByaKe1Ci/EZlxIXzDjwUItll UwsLGVRsum6tHpVoUEqhJEtqkaLml5hx6YagDabo= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180810072337eucas1p2f45007a268938858761dc202f907e0af~JdQYivzZh1914019140eucas1p2y; Fri, 10 Aug 2018 07:23:37 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id DF.DD.04441.87D3D6B5; Fri, 10 Aug 2018 08:23:37 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180810072336eucas1p27b000aea0d5adbcb0a9849444bb67e87~JdQXy_oIN1914019140eucas1p2x; Fri, 10 Aug 2018 07:23:36 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20180810072336eusmtrp2c8e679e166b1a780b9810c040a744514~JdQXjGG7x0715107151eusmtrp2g; Fri, 10 Aug 2018 07:23:36 +0000 (GMT) X-AuditID: cbfec7f2-5e3ff70000001159-25-5b6d3d78d9c1 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 0B.5D.04128.87D3D6B5; Fri, 10 Aug 2018 08:23:36 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180810072335eusmtip2a81a74d2c08aa5524836202a68951689~JdQXL_qq11961619616eusmtip2R; Fri, 10 Aug 2018 07:23:35 +0000 (GMT) To: Tiwei Bie Cc: dev@dpdk.org, Maxime Coquelin , Zhihong Wang From: Ilya Maximets Date: Fri, 10 Aug 2018 10:24:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180810030326.GA88853@debian.sh.intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWy7djPc7qVtrnRBi8uMlq8+7SdyeJK+092 i2Ode1gstjb8Z7LYfHESkwOrx68FS1k9Fu95yeTxft9VNo++LasYA1iiuGxSUnMyy1KL9O0S uDL+9F5nLLjMXdHw+BJ7A+N0zi5GDg4JAROJs6uCuxi5OIQEVjBKPLlzl6WLkRPI+cIocXZv KkTiM6PE5P1z2EESIA3L/h9jhkgsZ5RoatvMCOF8ZJTY2f6MEaRKWMBZYtPTC0wgtoiAssS3 MzNZQWxmgXSJawu/MYPYbAI6EqdWHwGrZxFQlTjQfAMsLioQIbFxwicwm1dAUOLkzCdgJ3EK WEpMObsZao64RNOXlVC2vMT2t3PALpIQmMcu8Xr2dlaI5jKJBzNnMEGc7SLR0zmRFcIWlnh1 fAvUOzIS/3fOh6qpl7jf8pIRYlAHo8T0Q/+gEvYSW16fYwcFGLOApsT6XfoQYUeJCa1LmSDh yCdx460gxD18EpO2TWeGCPNKdLQJQVSrSPw+uJwZwpaSuPnuM/sERqVZSL6cheSzWUg+m4Ww dwEjyypG8dTS4tz01GLDvNRyveLE3OLSvHS95PzcTYzAJHP63/FPOxi/Xko6xCjAwajEw8uQ mhMtxJpYVlyZe4hRgoNZSYQ30zQ3Wog3JbGyKrUoP76oNCe1+BCjNAeLkjgvn1ZatJBAemJJ anZqakFqEUyWiYNTqoHRsfmD24egy1c/aCrs6X566uCGt7E3bi9OMTy+Qf3D2ReqzOmR4qbd hycfPhQ9a88Hf9vUHV6cCmfdv72VXyp/kkN/98S9FbwHfmgtjrL9Or9Rpnd/4xL2RwssjxuH mGpff8zFMPdDj+NPi23ps+aZ7RF1XMVhPfHP+28RdRelHz9gsnJiiOtbocRSnJFoqMVcVJwI AOK7EwcuAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xe7oVtrnRBmem8li8+7SdyeJK+092 i2Ode1gstjb8Z7LYfHESkwOrx68FS1k9Fu95yeTxft9VNo++LasYA1ii9GyK8ktLUhUy8otL bJWiDS2M9AwtLfSMTCz1DI3NY62MTJX07WxSUnMyy1KL9O0S9DL+9F5nLLjMXdHw+BJ7A+N0 zi5GTg4JAROJZf+PMYPYQgJLGSVmn82CiEtJ/Ph1gRXCFpb4c62LrYuRC6jmPaNE09y57CAJ YQFniU1PLzCB2CICyhLfzswEa2AWSJeYcewMC0TDSUaJQ81b2UASbAI6EqdWH2EEsXkF7CSe vu8HG8QioCpxoPkG2BWiAhESTfPWsEPUCEqcnPmEBcTmFLCUmHJ2M9QCdYk/8y4xQ9jiEk1f VkLF5SW2v53DPIFRaBaS9llIWmYhaZmFpGUBI8sqRpHU0uLc9NxiI73ixNzi0rx0veT83E2M wMjaduznlh2MXe+CDzEKcDAq8fAypOZEC7EmlhVX5h5ilOBgVhLhzTTNjRbiTUmsrEotyo8v Ks1JLT7EaAr03ERmKdHkfGDU55XEG5oamltYGpobmxubWSiJ8543qIwSEkhPLEnNTk0tSC2C 6WPi4JRqYFRVY03r+qRQx/ykaOfVJ3ek+c4GR9/kbBOe+yN0r8pVj5IVn7gidk9i4n/eJXl1 o/Dt3yf38Gk56szMzv+kMrWl5ttWgTj3q5Vuyy8wvJuqeLtm+qV5BqrMPxbFX0uv2mbCcfqm VUXeckvFCMaHJjcPfWV7ZyhoyWUWXey0NmO+QHPl640zryixFGckGmoxFxUnAgBK71gYwgIA AA== Message-Id: <20180810072336eucas1p27b000aea0d5adbcb0a9849444bb67e87~JdQXy_oIN1914019140eucas1p2x@eucas1p2.samsung.com> X-CMS-MailID: 20180810072336eucas1p27b000aea0d5adbcb0a9849444bb67e87 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180809160856eucas1p2e22900aa2de83e9b17f5843151557d7b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180809160856eucas1p2e22900aa2de83e9b17f5843151557d7b References: <1533830978-23518-1-git-send-email-i.maximets@samsung.com> <20180810030326.GA88853@debian.sh.intel.com> Subject: Re: [dpdk-dev] [PATCH] vhost: suppress error if numa is not available X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 07:23:39 -0000 On 10.08.2018 06:03, Tiwei Bie wrote: > > [PATCH] vhost: suppress error if numa is not available > > s/numa/NUMA/ > > Otherwise check-git-log.sh [1] will complain: > > Wrong headline lowercase: > vhost: suppress error if numa is not available Sure. Thanks for pointing that. I'll send v2. > > Apart from that, > > Reviewed-by: Tiwei Bie > > [1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109 > > Thanks > > On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote: >> It's a common case that 'get_mempolicy' fails on systems >> without NUMA support. No need to flag an error in log for >> this situation. >> >> Signed-off-by: Ilya Maximets >> --- >> lib/librte_vhost/vhost.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >> index 3c9be10..91026b3 100644 >> --- a/lib/librte_vhost/vhost.c >> +++ b/lib/librte_vhost/vhost.c >> @@ -8,6 +8,7 @@ >> #include >> #include >> #ifdef RTE_LIBRTE_VHOST_NUMA >> +#include >> #include >> #endif >> >> @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) >> int numa_node; >> int ret; >> >> - if (dev == NULL) >> + if (dev == NULL || numa_available() != 0) >> return -1; >> >> ret = get_mempolicy(&numa_node, NULL, 0, dev, >> -- >> 2.7.4 >> > >