From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730050.outbound.protection.outlook.com [40.107.73.50]) by dpdk.org (Postfix) with ESMTP id 80D492674 for ; Thu, 16 Aug 2018 11:04:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PT1jolNbndulUQgb+Bq60d/Aui1CK7ef9ocLmAzwrKc=; b=PeA67B7YlyifUPuHC00+wypqNpkob/4ZLnhSnS8nRoyA0OBnUw6wE/TG3NxWaMVZrRS031em7AWlxcL2pRP0m2acXM4L53Zipj6JxfRjULbvMFYjkMk90ZSusJhyLGf/uLaxE7tLM/N/y4YkEMxr/R3qL2JxqVlXW7Uew0omtF8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.25; Thu, 16 Aug 2018 09:01:31 +0000 Date: Thu, 16 Aug 2018 14:31:17 +0530 From: Jerin Jacob To: Kiran Kumar Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180816090115.GA20462@jerin> References: <1533810233-7706-1-git-send-email-kkokkilagadda@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533810233-7706-1-git-send-email-kkokkilagadda@caviumnetworks.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0005.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::15) To DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a8e827a-6590-4867-bc7b-08d60356dced X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5002; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 3:LNVVgEnHrVShHVas6S1s70DmTyPGielP44M71YKfEXzm2cO9ICZA9q/vFOrCOylZaGWXms0DA4cWNOroybpc4gzvVFp4dCpbD8HyqXilY09Ssh8oQwzT/UeU2ZR4EtH14cxmJGL5pHOROPdYz9TO//bWxXruAqH2+qNDN601KtJRgut9PL/qBjgluTflNNUoojtpvgctHSTubuBv7HiKau2npB61arTRDsX/Zn8BsKam0ndf1RJ1qW0r26QzPcFe; 25:Tvkg1hJTjp7W+yGitudF0EhgGs+5vqw9UfBYit750ChUBQ1RPkItzZ1NpgaVMvbItzQyaBN92pakVPTgFbTlS2htJN/PUYq68l+gN/GQMhcUeWmvMMkOUcXYwg75HEPUQCOB/blxIYx4ALGoA1mYhhNoz+UaPrEGCret5zvFvySH6Ps0mhLLEbD72khiY7RK1vydhw64rFsOYDjZT8fNAzTzdzBsTETDN5Ditqjb73BKmALHhQcWcpBPh4ePJDpQkqhICLNi2A3Ls61VNfO+4gOsTMnj3uBeN0BMnnIOgA3XQDyvb9zvxcqc0qTzsulqxRCoC0Y/O8cBZXIu80DLeQ==; 31:MJjacW+5PQNT4YrN7fWzCNaM4A1jjlmwd0m8XaZkFyfak598RsB/xuewuj72h/5jeMu5BNazN82Tuszkclpuj1j7sazg6nYLPi1tOu3JJONu4S1PKhIk8Egb8s6NSwUtwV3UU+QDbUC4WVBN4ZipGJl6v4wWe3PDk6hv6SOpFL+2ot/IEYSnY8A/1e5s++fOiZ+3Oma18RrprO5yS30HWBw2t7PWIYBfaWun3F01SjE= X-MS-TrafficTypeDiagnostic: DM6PR07MB5002: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 20:h+CLjIDMF/Uuvja4l9SVxRlB5C3OXB3eAo7qOkktN6HHOg+QS/eJiu+BeT11iiFTV7V8C6zDqC2Kyaa3VmDeawG2NBKTj0Tk581N1hKbtfhdv4FVQd33ulf14mEOrS3S3UU52j+CVcDEeK5wPYq5a4l0D/Dn9dvaZxRMEDtXpN2ArEvOy3MV+WNX6t04BEY01o/kOJBkboBTtPN/Ebht+htzayYpVHKv4Wy4INodaMbPGtVv1GT8ynAC8WK1n3pD8cy4esinW4SZ9qv+yE4EF4ibvPa7URH5w9hZ3jdTb9d6u+lFlHUSVgWIy4rwpjVGi2U/xGE1kbwaN5D+JFpYRT48pc9hOKMev80pL1qythbXlZkbEPEBBblD3Rl669j/CDPNdmTp4LvOZMYgx9xxc5Yk6npKMDOJLA8PjpggRi8XIFdE90CidRMEtCnRxfegHk/bXKQZFR7LVPnFEDu89YXHSPsSpMCAYVHnSYpTwQFHDdZXfJrEwA6WHgQlfzC/0PTpp45KbdzTe7CFgPHtNtCSabDS5VavBJKbYiZ/amZ4q7E5Ck30GTm48g6MiMiRM9hxDd+vRUMvrosUBJYhv/x59wDIKENJU3SmnJU9eUA=; 4:nJdbBLZy2qaGXCppogCoqFO3oHZRp3JUdDbqMjxqcq6/BPuB6QtRFtHgtO8fvh+z4/tNGon7khPY8dGcboP9/Ljo8naI+YrLG6WJAGcyBbE7l3Usznw+6NH1HtlR/tRByr7KZ/vv4PLUV6EHSA9KBrY0rBt/S+lYcAapRo/c3JIppspQ8XeEHLMTiY70/vtKAr8yPoyYU/TFef/7VuoOQW41Msrh26cScBQLjtqwWY6YcDFsxLQQ9bZzEw+S5RkFmFUgzwNVIRX8dftmpLm1vWeH6Ag/lNGOwDTScHOl+ykVMYFJ8WCrKOgHI5bCgwNu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016); SRVR:DM6PR07MB5002; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5002; X-Forefront-PRVS: 07665BE9D1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(376002)(39860400002)(136003)(199004)(189003)(13464003)(58126008)(6496006)(81156014)(6246003)(81166006)(16526019)(8676002)(316002)(97736004)(26005)(33896004)(6862004)(53936002)(8936002)(33716001)(16586007)(72206003)(2906002)(305945005)(68736007)(229853002)(7736002)(6666003)(5009440100003)(386003)(50466002)(956004)(478600001)(47776003)(25786009)(105586002)(6636002)(476003)(6116002)(3846002)(52116002)(5660300001)(106356001)(446003)(55016002)(76176011)(486006)(9686003)(66066001)(44832011)(11346002)(33656002)(1076002)(42882007)(23726003)(4326008)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5002; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5002; 23:wIF6L+0UnTOC8JP5iIO3qMm+96hhG8B6WytTCEH3t?= =?us-ascii?Q?BMLusRapEJVf4dtFPe607JmbHZAJEQMfhZE5YL2DNCoHI+ord2fdXa1pwGKb?= =?us-ascii?Q?+nALoATQkQTrNUL9oYKsKwSKCRv38KqN0o71zFmdBrJqb6Pf//dA/z3aPjm+?= =?us-ascii?Q?RoPcwoUsx2o5ExpVe+5HauR51jAI3Go2PlkZ2WnT77V8WieusKv0urilFQsB?= =?us-ascii?Q?d2kffyy+8U52lHM1n5CWFMrzBZQN/7dVSlVi8XGyMxQb8yEgSH8NbLrmqp07?= =?us-ascii?Q?dp/QBdLb7sc46F/shdpxBuDFMWNB2Eq230oA0ENz8zx4/NXPps5wLdKd0qVk?= =?us-ascii?Q?8mRLa6imX5bLW19qYYqpTFaOp29I6+yeoEmzxfugEiAVAsg99Xt/1Y/jFfVL?= =?us-ascii?Q?TG5hl/0X7ae6t1cPHayhof5Q1OJHgNsmOb7yZF2LeDO8V4JUWhdqMp+gfWVS?= =?us-ascii?Q?/e8JYoWvUA71rvx9Zw8s3QTpnZtPDtqVIkpm5FXbKP2peVN3+I70R0ZZ/tr/?= =?us-ascii?Q?YwkexZgjHSNMwUYisKEunnRHKg7erTVjBdHZVt4hopruWWTMIablr9DT+vav?= =?us-ascii?Q?nBJQTK/fRsrpmxRm0FPopZYSyuQ7YTPNjd3cpmmyTk3AKIw7oC/xM8aLEBqp?= =?us-ascii?Q?rCmKB+Eyoe2Ic4X6WoEt3IYhnxvcpBfXCG3dx2hlBb1AAfLeS1w+mWuxclCL?= =?us-ascii?Q?qVUMYzaO3E4BTX5FA69CpB0mXzUxAww6IuQ2sr99gXFd6iwWZW+HWvWATzV3?= =?us-ascii?Q?mYxpkytXwl27yQ/e0UqFtgmvSdf/EjRLn1X+JpYZqJfBwAnYk/DC2UpgauHF?= =?us-ascii?Q?hD95Cgs/O8yte6nc3As82lNV02CL8jUpnGKm9X4P4uCEzXlD8Pm/AS9JcSMd?= =?us-ascii?Q?F/MMBQFe3sPrNgrqVYfLt+uToVotKSWMD5vjW5AfN+Ey97Oi74ym/aGIt0Ov?= =?us-ascii?Q?edn+XipKi06PnK3hdvqaGdd+LXhSN8RNbdnoQQYjT9IlNgmRrlDXCGDg2wdD?= =?us-ascii?Q?lWLZeCxI/xHjP9jw4RX174XXii0dVAK2B+pWVmvnK+jiqYGbobMXCt5nungg?= =?us-ascii?Q?s45I4fzWStA21UasIqdiB8ipThzqreZLWJ46YEM6YMKJXsGDGyqQCxdu4xIz?= =?us-ascii?Q?F1XzbIkDF6Tw7FMLEdiR+rdI5tYJ3WtkE1HILAslj2qpuO2FvtNQYBJXTnKL?= =?us-ascii?Q?ebpdeS2sPrLgIoG0YlkBLk2tldKAXM+3Fq9XdFqLMoHXlBSJFt2gx7Z2P4Xk?= =?us-ascii?Q?0WUfbJ9ranMZoyB41Gttc4yaQw+AfzCmXSWKO0I++1xbRhPb34tFUNDYmV5A?= =?us-ascii?Q?j26M7LA5vULFBf0I2A3d7XL9bZlnEviw5ghh3jNY1vwr+5KHB322iaYIsT67?= =?us-ascii?Q?rJwvQ=3D=3D?= X-Microsoft-Antispam-Message-Info: vbSCejkepqzIRMvurnVhXPVR/d9obpyI/6N296lzZ3XxenUZDOCUnrkZ8h30UdYjIy7k0Z0AibIelXWYfMSU6wVJ3Nap0G9aBHyjIjNTW5OtJdqWEk3qv7CzNXNX1VNxpdszlRWyTDHHrFbUrBOhuAivcsdkV9WroYKv0pmZdAIDdhwtpxOUXmmtzSkRvIY6sF0qs7HR7f+Eau0S2RlSGDLy/Nxgz14SPHl2B+6G4jHFwsgq03wM1XYJnO06g+9rFTg8b5rtXBbGDre+hDOHOGRTVFSc4o80g8Lua04yJRQCjDBPJZB6H3PT24b62pW/z9iP4Mw28M3HU7UPkgiEbw3Ij/jeaRL2LbJNi0y++WY= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 6:BvKDCH3YM1dpik7ReUFSkYp42iwxvSRO3R08g/oKvD8uz3p4TK5gXF/Pw/duYSlwgXqlica7/qfs0tsZ7FwU7kPFC62vDK07nKK3sUwDFc92h6Z2+TvtreoH+7i/CuEsGo9wxDgAjJ/UCTo27SZtgMNzoN29rMZvuhzu8LW8MpdHKY2zFnPpxGPLbxmhZrj51OAgyGIkT7gJ+XsH1og5ap4wEq8nxjX4T0nKBKcYIonOPw8Yo1JGRqbxFIg6zdRLdbkkV+essTScJdYbC5AdTuySb8axkeS7luWLsgOT08hiW797lW7ya0umszwU7YiPWk0FwEjocIhEn03LlvZDlhj9n4ssLplLJRYu5MDA08PRp5LpcQ29PdOZ+lLDehbZa0HRhSbLgp+l7iSIMzwwDccHzZyJ6bWPrnKi+bru1b32JnSlOkN6dER1UURK68XDURCZ2ua0/w93WUJAon2q7g==; 5:BZBhmJeQV/UbwllajSHAl6e2JDbiIJJTkAK1VSjm9uofzox4OlrU5fbRcK7NQkOUZcgSg/DMOShdikiritR+DZOQoenbMoLyt6+4Hei0wYLE2FTXSGfcyCk/hQX9DOswLZn5DHwMYZsG9pbQ3+IeoH6n8jh2F5eIdkTgWBRU+kI=; 7:6th7JiIOM1QwEagVOpzQK2zMXYT+KirGjRORG0kUNonhv3BPftwr0I8ogVuGGCBYrH7MAZC+uUkgvCqHEHOFSIFEvnDLzr6HMq6k/ETduJRq3+rCAIOo+RRe1PRiBbND4kVUrH2e0lBeQsR8lz92hrf420mDHIAscTBTE5qGm7rW7X6iIki/a/h/TFxKoMQC5+x2gf/He8SvQ8WMkUNOOplXQAfLEqUIvg2zi//2cM89q7YPjDndyUFy995ce0oy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2018 09:01:31.5329 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8e827a-6590-4867-bc7b-08d60356dced X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5002 Subject: Re: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 09:04:10 -0000 -----Original Message----- > Date: Thu, 9 Aug 2018 15:53:53 +0530 > From: Kiran Kumar > To: ferruh.yigit@intel.com > CC: dev@dpdk.org, Kiran Kumar > Subject: [dpdk-dev] [PATCH] kni: fix kni rx fifo producer synchronization > X-Mailer: git-send-email 2.7.4 > > External Email > > With existing code in kni_fifo_put, rx_q values are not being updated > before updating fifo_write. While reading rx_q in kni_net_rx_normal, > This is causing the sync issue on other core. So adding a write > barrier to make sure the values being synced before updating fifo_write. > > Fixes: 3fc5ca2f6352 ("kni: initial import") > Please fix following check patch issue. Wrong headline lowercase: kni: fix kni rx fifo producer synchronization and Cc stable@dpdk.org With above change: Acked-by: Jerin Jacob > Signed-off-by: Kiran Kumar > --- > lib/librte_kni/rte_kni_fifo.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_kni/rte_kni_fifo.h b/lib/librte_kni/rte_kni_fifo.h > index ac26a8c..4d6b33e 100644 > --- a/lib/librte_kni/rte_kni_fifo.h > +++ b/lib/librte_kni/rte_kni_fifo.h > @@ -39,6 +39,7 @@ kni_fifo_put(struct rte_kni_fifo *fifo, void **data, unsigned num) > fifo->buffer[fifo_write] = data[i]; > fifo_write = new_write; > } > + rte_smp_wmb(); > fifo->write = fifo_write; > return i; > } > -- > 2.7.4 >