From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 467462BAF for ; Thu, 16 Aug 2018 12:43:03 +0200 (CEST) Received: from cpe-2606-a000-111b-40fe-f1c6-eb46-ccca-fca5.dyn6.twc.com ([2606:a000:111b:40fe:f1c6:eb46:ccca:fca5] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1fqFjp-0004X8-DZ; Thu, 16 Aug 2018 06:42:57 -0400 Date: Thu, 16 Aug 2018 06:42:12 -0400 From: Neil Horman To: "Rao, Nikhil" Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "Mcnamara, John" , "Richardson, Bruce" , "Yigit, Ferruh" , "stephen@networkplumber.org" , "toggle-mailboxes@hmswarspite.think-freely.org" Message-ID: <20180816104212.GA2641@hmswarspite.think-freely.org> References: <20180814105208.GA24870@hmswarspite.think-freely.org> <1534313442-26927-1-git-send-email-nikhil.rao@intel.com> <20180815104859.GA3846@hmswarspite.think-freely.org> <1F668163772FA946975B9466A9DFF729ED33A79E@ORSMSX110.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1F668163772FA946975B9466A9DFF729ED33A79E@ORSMSX110.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 10:43:03 -0000 On Thu, Aug 16, 2018 at 06:19:40AM +0000, Rao, Nikhil wrote: > > > > -----Original Message----- > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Wednesday, August 15, 2018 4:19 PM > > To: Rao, Nikhil > > Cc: dev@dpdk.org; thomas@monjalon.net; Mcnamara, John > > ; Richardson, Bruce > > ; Yigit, Ferruh ; > > stephen@networkplumber.org; toggle-mailboxes@hmswarspite.think- > > freely.org > > Subject: Re: [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition > > > > > > > > Thanks, I think I made a mistake in how I detect section names in the awk > > script. The rule assumes that the entire section is getting added (i.e. we are > > adding the EXPERIMENTAL section as a whole unit, hence the starting a line > > with > > + to id the section name, and thats not the case here. I think the rule > > + needs > > to be any line in a map file that ends with a { (based on our coding practice), is > > a section start, and the section name is the next to the last field in the line (i.e. > > $(NF-1) ). Please apply the patch below and confirm that this works for you. > > > > Best > > Neil > > > > > Thanks for the fix, it works. > > Nikhil Thanks, I'll propose it as a fix here shortly. Neil > > > > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol- > > change.sh index daaf45e14..cf9cfc745 100755 > > --- a/devtools/check-symbol-change.sh > > +++ b/devtools/check-symbol-change.sh > > @@ -25,14 +25,14 @@ build_map_changes() > > # supresses the subordonate rules below > > /[-+] a\/.*\.^(map)/ {in_map=0} > > > > - # Triggering this rule, which starts a line with a + and ends it > > + # Triggering this rule, which starts a line and ends it > > # with a { identifies a versioned section. The section name is > > # the rest of the line with the + and { symbols remvoed. > > # Triggering this rule sets in_sec to 1, which actives the > > # symbol rule below > > - /+.*{/ {gsub("+",""); > > + /^.*{/ { > > if (in_map == 1) { > > - sec=$1; in_sec=1; > > + sec=$(NF-1); in_sec=1; > > } > > } > > >