From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by dpdk.org (Postfix) with ESMTP id 96A2F98 for ; Tue, 21 Aug 2018 17:06:47 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id y4-v6so8583055pgp.9 for ; Tue, 21 Aug 2018 08:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WBMPfENP+hSpUoP1P85ROCBVk2WnK8NW3PcO8SRTPZ0=; b=cNgYW+7z70evJjhB3kSMYAZwgjNBWvKERilPtyw1evtBg8Qwu1WKIKLhRMJRKmVDIx /ggJBK0k0CHpB6pG2K0tiCRX4+oUtgOmNdgJx9deWgTrAw1R0dJCvO3vH+mhDk9AaAt4 RR1AgueDH1toAcalpZ7sS/cPeMzEFMXIBiHgZQXgXG9VCJgYwr1JFMxiezlkqFay7Xs1 5l1AC2focoTsAz4mp0NntTuMGaijk4cj2T8sM7aWEYKJ0K9cMZVrXLd0wkRPqio5XPMi +bILgA9LWC2l85nCGesU755Y/FEMoIIAlD5R2srtA0Ui6myeo6z0svnVP6iWMPfaA+V0 IXEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WBMPfENP+hSpUoP1P85ROCBVk2WnK8NW3PcO8SRTPZ0=; b=jhmTJQY6sxDSdXYstOLtUcJFO0xyZG+UtOrHJHx5H7Bjl/6EaT/7KFRLIOyT55fjoQ 4RU8ZQnAnnXaAzjNeRpmQrzeZ0DwSlIOLqNzt7gv5Xn96RUJF1wG6P1X1ecPjsm6cUuc lmNTlB39NxM1xL3hKhmblJBh4bBrDnXnxbm0nIo23Bc6BqYLcBSL9mKzyZ9hiN5QrusC qhBC0heJVohsYaMP9PYuZ6jp9a3lkOU4KGIUHF8hpWZIcB75ret1Uk6+KJ1QRIVs3/W0 PsYOXOqjaYMripGMLm782GV2MHGmKr8Kpmws94yUSAIl8dllTNcSc969m3F+MfaHGkW7 /A3Q== X-Gm-Message-State: AOUpUlGwfmDH+fPlBmljXTPIqtgwTTrHWT7i43rspoEkw0pe/6Y0vels OLzT6wJ3csH5O4kn+U4HNaXz3Q== X-Google-Smtp-Source: AA+uWPxy7Yssyiv0Iu+Ff4WVYeOQDXRQIPeYxqTwbqTBcjDzWIKxu1P/Oz+y9BO5rnYRCB3sH3VoDg== X-Received: by 2002:a65:6551:: with SMTP id a17-v6mr48293096pgw.132.1534864006696; Tue, 21 Aug 2018 08:06:46 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j5-v6sm17278656pff.139.2018.08.21.08.06.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Aug 2018 08:06:46 -0700 (PDT) Date: Tue, 21 Aug 2018 08:06:44 -0700 From: Stephen Hemminger To: Matan Azrad Cc: "dev@dpdk.org" , Stephen Hemminger Message-ID: <20180821080644.306bba69@xeon-e3> In-Reply-To: References: <20180814001926.19630-1-stephen@networkplumber.org> <20180816224409.5719-1-stephen@networkplumber.org> <20180816224409.5719-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 15:06:47 -0000 On Tue, 21 Aug 2018 10:20:43 +0000 Matan Azrad wrote: > From: Stephen Hemminger > > Function is boolean so use that. > > Ethdev is not using bool type, see also: > rte_eth_dev_is_valid_port > rte_eth_dev_is_removed > rte_eth_dev_pool_ops_supported > > I think it should be a full solution to all. > > > Signed-off-by: Stephen Hemminger I didn't want change type of visible (exported by ABI) functions.