From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0080.outbound.protection.outlook.com [104.47.36.80]) by dpdk.org (Postfix) with ESMTP id CAADCDED for ; Tue, 21 Aug 2018 11:13:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/vWI0CC+C7BFGTnTEh2fW7BN3eSR0u3B/90O/E42Sio=; b=b2NFaSfGm1D9piLaMXKoEc7iiLPUuybl9Ub2tp0kLCXb/NSoPf/UXcxk5wgqF+glBra4TOTFQELsIR2+ZLZa5/H/dWg6DFy+MS3nKHI3RQp1MGr+YEdo878on/dgWRv+gbVVTS1PzCBJ+FCtRZvL+Pk4vnb5rIVZljqgdC5zuRk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.13; Tue, 21 Aug 2018 09:11:56 +0000 Date: Tue, 21 Aug 2018 14:41:41 +0530 From: Jerin Jacob To: "Rao, Nikhil" Cc: olivier.matz@6wind.com, dev@dpdk.org Message-ID: <20180821091139.GA13834@jerin> References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com> <1534479652-80182-2-git-send-email-nikhil.rao@intel.com> <20180819104534.GB11085@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0054.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::16) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0a64905-7c61-41ff-0459-08d607462604 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4997; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 3:v6fihv3qhm9Nfpevh7vQuonJMXUsqXRdqvQoaXNNZPS+o3+Zi7PasrFkGLubXvrft5ZxNyepXR9iNI65qdSRm+hmML3flP8kfPfrILtQrRFWSJXrFEsIr+BF9dVhRfcnnSVCCN2/CsLDCt6cDHpXhZ0Zldxw/Tk4Ej7sjkQkSc/igtVkaEYkgJQOCTnZG/QzV9/nmw1c4Atw8PQlOrJbXFXMW7GaQaR5LsjnGW+dQYpi1yD/Y2U4K7t9VIe/FXLP; 25:fQS8CJPVE9EV45jgpshrrZg+Y0lzH8byx6BwymXL2pi5yqarXoAZSK+spTgbtSVyrxqYj7uR5H2pcUWP5RTyWe7Yv81tExKQ9P+TE/LA7aVFapTr93eIo6I6rR7mqbWnGS/Q6VeMVpBxqxBSIDOf4gZmb3teO3r3zXKH73sDMy33cMdkRxRKyx0ga/LajgCqkXGfJ6PWifqZ4utPMAHsgfyypGtXoegzx2V2lKzXrUyZGqq+zA7E/zDI3Yn0LeAJG9jyDVRc8GzHbh1e4qDBV+UQ6UbaH6eCVGMvXV7qtfsB22fTmJp7SuC7NESk4Zz+zjMKworC0Xul2cCtsj3gGQ==; 31:AqxxOVR/eUJ2EtuBdkIhmFS38f81QY55EvlftKdylIj8Q53CV+P1ecBJD9Afl6XA2Ii55Uc0xL+hbEE1QMOPgUraMLaz9Zx2UfV1kqxiTyzRjAZwLEKmGGbbiDZxoAHae71FZF/I0dN9FohdIZarc1bV1Ov2sKwYYhU0GE3FmsN4OgJpSh/tXhA0fLtduvLCylJEjSmTMZPAIBsXG6NfZup6fh4X3lrScSDJeS4q7eU= X-MS-TrafficTypeDiagnostic: BYAPR07MB4997: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 20:1QFjEHNevuP/Ir16NjLE6qZujGf4wKqeUMEhQTrHx/UqZDW8qhdZLEWhcZUF5Km3NZQc33sISnNesak33qHXnkw4fErBGQWvjWq6bZQ1Ci5al0wfkHMkw8WHK/DEXrAFnCpzuge9U3kASL+EJZYxKF0Db31ftSlVAXdBHo5jPe8IGzZvyFtP5ZMun+5PvBaqLqRKOTCevazCqxjaFy/LKyJH3PnTQNjWuAuO6oy+BXtTcBgBUyAo8IRZn0/hESe/ePtbLWt/nxuWSiFRFWlNJ9xckwpweZZ17DthWje01IsqyxYVYgeBSJxvA27sFKg7CvkGOQ62C0CQt1JQCIEztZbECYpZQP/aLef7vLC0Qo17kzx7kGNwkkpbHSXF2cIZBTLVzl1GI3FaPL4nLvPbkziqipWho7KZqD130xmu3Xov2rVtpLz7udOEAhCpP/uf7duNP321vKu0HtQ8jjiOWClY4usFbHHYB3J05orzNvvd/ILMlGWvAzBN3fLnLBHGZ8t6tAXo0E3uHEzb91n7BL5iXvwPWOlMnCXBJmDaSiXPP6up1cCXiXpd4dNBqnQRztYjDMtOUVcC7cYiRmMmm/KrdOEvBqn2sqQLCSMNLOQ=; 4:ZM0PA9+sNLKHNGssZXV4k4PyZHGFwlpk96ov4ghl5lDGR+exr5HmOelSwPr/EF7VhmqQ8b/99quLRypoqGxkbBy1W2D9E5uAuM3B1BSAe7i7im1hmTdI6I2tyx6Ymkeu/+e9gqhUW1ryL32FE9OT2fs9GZ/0sbbzPB32SRwwd4NK2+DFejBr7X5DDaC1RpSfjdPEnlKfOVzulY/W0J8edJLTjae7nd1HHJkhy8VgJcYppL8I7JHof6HLQKJp9OEVaJDVLcQuqsNYZpt3QYGZRlFvHcBKUg8tDzHxlypRm2STb8gPC7kWvnKwQ5JD4fnk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699016); SRVR:BYAPR07MB4997; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4997; X-Forefront-PRVS: 0771670921 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(376002)(366004)(396003)(39860400002)(346002)(51914003)(13464003)(189003)(57704003)(199004)(6116002)(186003)(58126008)(16586007)(16526019)(386003)(76176011)(33896004)(8676002)(3846002)(316002)(81156014)(23726003)(42882007)(6666003)(4326008)(6916009)(68736007)(81166006)(93886005)(5660300001)(6496006)(8936002)(52116002)(53546011)(26005)(55236004)(2906002)(105586002)(106356001)(446003)(956004)(11346002)(1076002)(305945005)(7736002)(97736004)(47776003)(476003)(55016002)(6246003)(66066001)(53936002)(44832011)(25786009)(486006)(9686003)(72206003)(50466002)(478600001)(33716001)(33656002)(229853002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4997; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4997; 23:GSKV3QTTQPJYn+Y/tjqWSUC+EHBh448r76UPT0JW9?= =?us-ascii?Q?1uP+yVyt4DBoJl5eqzCVetFAKn50rgbKcTWjT+xqgMQpujCdkR2wXfmj0ITG?= =?us-ascii?Q?Vu4407wMv1l6YdY3BGutpU82cdEBHKNQAB2u/iqvYpKYydJjkS1xPvTI+Ap/?= =?us-ascii?Q?S3v3Yoyx1qEZZtgqeMngNOPTYn2biNbVVxZbpbdoiI0B5LjaZ9Z46Qayg+lD?= =?us-ascii?Q?NCba6y9HAIq6r5xEGp0i/jyawvpMisSEtOP57RJ1NzzjNGVn4Hi2hNHx/hEY?= =?us-ascii?Q?epFihKK06qPIxvdJf62b7zYmpT49lP/nSH82cmZjpkSX3U6YQ3kZG3WqZcsq?= =?us-ascii?Q?JFbYB+90MitjEsqEYT97rC8+rZev4ybuV19izgaQmOuVGuVG5jpvKGWlABmv?= =?us-ascii?Q?DZpsiV9ljDTPtGW0XDCYjJylZU1e0MHbne5/oXXygiR6mQh29cuG5nycCBNI?= =?us-ascii?Q?p662SKxVGEGvxhWPa7YctFAjUl/KrPQxE9zypPYBDJTZ88fOrTBi1i+TY+r5?= =?us-ascii?Q?70/9q6HvjrjaHpq9CcwzSGsE8kgL1Sjzo6szT3cSw35b/F7bWSxGQlo6VGKa?= =?us-ascii?Q?FgwEkSAvycO1Hq8IUcJPw3MTnKw6CktIdO3+WfPiJRquwqId69xe/kmsW8Au?= =?us-ascii?Q?b7F6iZHhi9PqIFcFcuJ1HR89rxX8p5RyQrt/aufX3814apo2RoCkccwT/M1T?= =?us-ascii?Q?9vMEBscBLvyuO25WG3A5XXJ5JzAGS4G7y4FedpZPaGLgy/MOUx5y7sGyrwew?= =?us-ascii?Q?2VItXQLosfr/MmDPvrEzPHkhOAIq6NkuQuhQ9yyRNBfNLJKKGTWMq4Q0hMKo?= =?us-ascii?Q?rPoTOp1ziEzuTiX817vBo/1JQb7Ru39FADliURbrQdpMO0TFhG8IKPA2eZ0I?= =?us-ascii?Q?ss//D11ItVd7VkFC5NuhrMOzdGIxjUDSSnJEGqx8GNMiGyp4SKQO9fe9Kddr?= =?us-ascii?Q?pp0umdmRHEY+3Ay2U2n51at3BCeq/UVu/cbg22txLCJurDh5Fr3ZXTl3czn5?= =?us-ascii?Q?DBp0R7Ld9PtExSyhy5bp41ntpger8T8QBE6RLwKX5BOPEuHAnctXHSlR28yF?= =?us-ascii?Q?uf1Pqh61JYInYLXGLptfF1aT0BicUoUiPyQk5iKenqFfE90AqlTnuUHzr09B?= =?us-ascii?Q?fkk1Kg7CvpAB3CUvfwTmzB3keF+8fjgOOVwhZXBP4nb6QeDIXS9zZKoXAGu1?= =?us-ascii?Q?O03ababWuUs2eGDBCMFgCiQ4V/I//X6n4HT4HSpnXpYftizvEHu/H0KSSbT/?= =?us-ascii?Q?E1icys8GwcvYpDJwgtgtwwqb/d8e2K6xkYT4mhFMJJk0VcuJn6kkkIvbZEG1?= =?us-ascii?Q?usLAHyEajvohNcDmWlSrl00Als2OMROnrinYjkxJjKsYeAyVqbZTdd0C5MKU?= =?us-ascii?Q?xBXP3JhosDFSBuFyFnip5dFj5q8ATqVW+iQiy3YFzJYau8oY4FcHpaiNktbJ?= =?us-ascii?Q?0F2DtE5jw=3D=3D?= X-Microsoft-Antispam-Message-Info: TVghCHNnr4sZPBbrBmN3wlhkcJPn9CqmdCl0cIUx8orwa4kRgzhkPNCPLkHcF3M6gf/65swZja1e5soHSSVbssp36QJu1BuhHeK4iyrDg2HnGB4AwlfR7Isc3fwY9SFQRtkIHGecwzqFZ3jG7fZqbaYYXc1Y0A5np+iLY5GMbYmf9sb1dbX9FusS7wFpoedGYV/h7Jp2Q03Kq+HWGw6fwSvAlraPoBxS2Y/69DbJWFLEw6e9EQJ01osTwEsbaSZqOexfc+HdbR1+NBMyWAbGtjGG48c9HWKoOCIrhtAkXhWF8bZS6Diswj24OBGr/Tw7Bf4LtkzcaK37TotyeWvhRbBlVspdOgAwv+KoN0a6F+Q= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 6:10vwPAKoapHQ6z00A6VjYg+8AJQd43krtxaUiH4NnpyEYJ0aEW6Lmaj3Oamnusm7bQ+gpk0tyXjufKW/Dfkel33poLA5mKGOngvXmSklQIsIJHHGMP47tv2VrIaZLlM+A+CUsAntHoXNvpQpdxzNbMM7/t3yhvbWnGKOpwa/kyZ8vbHGckUkVfPYjBG9S9eQwsk5iNCZtW7dAjlWO1x9Jun2F38DqQifDs2wvGJCf26gGtxqhHwENR3e2Q4w4RqTDY/h7GmD1BkxUwcQ/A5me8GgfnXd7fpFdAKNZmmHsdyBlZumIjfPG0a8HrJYvX6SS5a8dzPQQwrJf1Km6AZIysLhfFr4Yx5Fb4MI9Xk/yZ/CThyvYVC8Yvz+/dqJH6xrpgHx9cmu2GK6iDYzc5Z+5KDV+00FeTVeqPNTGlwsGbtA8zKzshrXRbJopTfGuu0huXH5uedgo/LdAgyNy51Png==; 5:EljWqsTfaqLmRYfvpsDk4vg6cUV8pmFw8OhWmsqdZFjSxTPXGEtzUsm8BwlZtizUPkJc/jCmUBYuCCjPQC+5HLyr4I8uUEPsgTQGfrrH1jqcgXHtsecguKHS3RmEFjgvg5tg4QkiQS6WASxAO//Z3nhgC7CfeufhU49PqhWxFlc=; 7:84WIibqfPWSd2w4MAsrXQfLOfs4P4VCFV8XbyVsIIDyA4hQ/jz4IWzzgV5qKeHHSxSVDmfCFgFI4rFpUgQE8CTjUOgD7e1uk1plR7PUVawA+8MeXd/oFAyPKsVhWVNHIg15BEFQw3oOLg9HolOzq4xoqNcw5ofszdBLUNJQmsGW3ma8cmAcWz9s59RGdLd2o1XCMKuBsowu5ssZbk81YjlQtVOtKb1oCNT0rRW8SRWsYHTXp5R2fnLnXyIS+ttzA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2018 09:11:56.4921 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0a64905-7c61-41ff-0459-08d607462604 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4997 Subject: Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 09:13:21 -0000 -----Original Message----- > Date: Tue, 21 Aug 2018 14:22:15 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: olivier.matz@6wind.com, dev@dpdk.org, nikhil.rao@intel.com > Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for > eth Tx adapter > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 > Thunderbird/60.0 > > External Email > > On 8/19/2018 4:15 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Fri, 17 Aug 2018 09:50:50 +0530 > > > From: Nikhil Rao > > > To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com > > > CC: dev@dpdk.org, Nikhil Rao > > > Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx > > > adapter > > > X-Mailer: git-send-email 1.8.3.1 > > > > > > > > > The caps API allows the application to query if the transmit > > > stage is implemented in the eventdev PMD or uses the common > > > rte_service function. The PMD callbacks support the > > > eventdev PMD implementation of the adapter. > > > > > > Signed-off-by: Nikhil Rao > > > --- > > > + > > > static inline int > > > rte_event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues) > > > { > > > @@ -1275,6 +1300,15 @@ int rte_event_dev_selftest(uint8_t dev_id) > > > return RTE_EVENT_MAX_DEVS; > > > } > > > > > > @@ -1295,6 +1329,9 @@ struct rte_eventdev * > > > > > > eventdev = &rte_eventdevs[dev_id]; > > > > > > + if (eventdev->txa_enqueue == NULL) > > > > Is this check required, it will be always NULL. Right? if so, > > Can't we write eventdev->txa_enqueue directly? > > > > > + eventdev->txa_enqueue = rte_event_tx_adapter_enqueue; > > > + > > > > The thought was that if the PMD supports txa_enqueue then it wouldn't be > NULL. Yes that's true. But in rte_event_pmd_allocate(), eventdev->txa_enqueue it will be NULL. Right? Do we need to add the if (eventdev->txa_enqueue == NULL) check? > > Thanks for the review, > Nikhil >