[dpdk-dev] [PATCH] bus/fslmc: fix shared build

[dpdk-dev] [PATCH] bus/fslmc: fix shared build

[Pablo de Lara]

When building DPDK as shared library, disabling optimizations,
the following compilation issue appears:

portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov':
drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:289: undefined reference to `rte_dpaa2_memsegs'
...

Bugzilla ID: 61
Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search")
Cc: stable@dpdk.org

Reported-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c            | 7 +++++++
 drivers/bus/fslmc/rte_bus_fslmc_version.map         | 1 +
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c            | 7 -------
 drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 -
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
index 39c5adf90..db49d637f 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
@@ -28,6 +28,13 @@
 #include "portal/dpaa2_hw_pvt.h"
 #include "portal/dpaa2_hw_dpio.h"
 
+/* List of all the memseg information locally maintained in dpaa2 driver. This
+ * is to optimize the PA_to_VA searches until a better mechanism (algo) is
+ * available.
+ */
+struct dpaa2_memseg_list rte_dpaa2_memsegs
+	= TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
+
 TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev);
 static struct dpbp_dev_list dpbp_dev_list
 	= TAILQ_HEAD_INITIALIZER(dpbp_dev_list); /*!< DPBP device list */
diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index fe45a1136..b4a881704 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -114,5 +114,6 @@ DPDK_18.05 {
 	dpdmai_open;
 	dpdmai_set_rx_queue;
 	rte_dpaa2_free_dpci_dev;
+	rte_dpaa2_memsegs;
 
 } DPDK_18.02;
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index 7d0435f51..84ff12811 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -33,13 +33,6 @@
 struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];
 static struct dpaa2_bp_list *h_bp_list;
 
-/* List of all the memseg information locally maintained in dpaa2 driver. This
- * is to optimize the PA_to_VA searches until a better mechanism (algo) is
- * available.
- */
-struct dpaa2_memseg_list rte_dpaa2_memsegs
-	= TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs);
-
 /* Dynamic logging identified for mempool */
 int dpaa2_logtype_mempool;
 
diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
index b9d996a62..b45e7a9ac 100644
--- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
+++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
@@ -3,7 +3,6 @@ DPDK_17.05 {
 
 	rte_dpaa2_bpid_info;
 	rte_dpaa2_mbuf_alloc_bulk;
-	rte_dpaa2_memsegs;
 
 	local: *;
 };
-- 
2.17.1

Re: [dpdk-dev] [PATCH] bus/fslmc: fix shared build

[Shreyansh Jain]

On Tuesday 21 August 2018 04:55 PM, Pablo de Lara wrote:
> When building DPDK as shared library, disabling optimizations,
> the following compilation issue appears:
> 
> portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov':
> drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:289: undefined reference to `rte_dpaa2_memsegs'
> ...
> 
> Bugzilla ID: 61
> Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search")
> Cc: stable@dpdk.org
> 
> Reported-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>   drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c            | 7 +++++++
>   drivers/bus/fslmc/rte_bus_fslmc_version.map         | 1 +
>   drivers/mempool/dpaa2/dpaa2_hw_mempool.c            | 7 -------
>   drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 -
>   4 files changed, 8 insertions(+), 8 deletions(-)
> 

Another patch for same issue was already submitted by Hemant a few days 
back: http://patches.dpdk.org/patch/43788/

-
Shreyansh

Re: [dpdk-dev] [PATCH] bus/fslmc: fix shared build

[Ajit Khaparde]

On Wed, Aug 22, 2018 at 10:31 PM Shreyansh Jain <shreyansh.jain@nxp.com>
wrote:

> On Tuesday 21 August 2018 04:55 PM, Pablo de Lara wrote:
> > When building DPDK as shared library, disabling optimizations,
> > the following compilation issue appears:
> >
> > portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov':
> > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:289: undefined reference to
> `rte_dpaa2_memsegs'
> > ...
> >
> > Bugzilla ID: 61
> > Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address
> search")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >   drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c            | 7 +++++++
> >   drivers/bus/fslmc/rte_bus_fslmc_version.map         | 1 +
> >   drivers/mempool/dpaa2/dpaa2_hw_mempool.c            | 7 -------
> >   drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 -
> >   4 files changed, 8 insertions(+), 8 deletions(-)
> >
>
> Another patch for same issue was already submitted by Hemant a few days
> back: http://patches.dpdk.org/patch/43788/

If Hemant's patch is going to make it in:
Hemant, can you add the Bugzilla ID in the commit message?

Thanks


>
>
> -
> Shreyansh
>
>
>
>