* [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit
@ 2018-08-22 6:05 Brian Archbold
2018-08-23 11:16 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Brian Archbold @ 2018-08-22 6:05 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, brian.archbold, stable
In interactive mode, when the "quit" command is issued, pmd_test_exit()
is being called twice, once through the "quit" command and the other
after termination of prompt.
Remove duplicated exit routine by removing call from "quit" command.
Steps to reproduce:
- Run testpmd in interactive mode.
- type "quit".
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Brian Archbold <brian.archbold@intel.com>
---
app/test-pmd/cmdline.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 589121d..76b7cc1 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7573,7 +7573,6 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
struct cmdline *cl,
__attribute__((unused)) void *data)
{
- pmd_test_exit();
cmdline_quit(cl);
}
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit
2018-08-22 6:05 [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit Brian Archbold
@ 2018-08-23 11:16 ` Iremonger, Bernard
2018-10-11 11:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2018-08-23 11:16 UTC (permalink / raw)
To: Archbold, Brian, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, stable
> -----Original Message-----
> From: Archbold, Brian
> Sent: Wednesday, August 22, 2018 7:05 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Archbold, Brian <brian.archbold@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix duplicate exit
>
> In interactive mode, when the "quit" command is issued, pmd_test_exit() is
> being called twice, once through the "quit" command and the other after
> termination of prompt.
>
> Remove duplicated exit routine by removing call from "quit" command.
>
> Steps to reproduce:
> - Run testpmd in interactive mode.
> - type "quit".
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Brian Archbold <brian.archbold@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix duplicate exit
2018-08-23 11:16 ` Iremonger, Bernard
@ 2018-10-11 11:41 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-11 11:41 UTC (permalink / raw)
To: Iremonger, Bernard, Archbold, Brian, Lu, Wenzhuo, Wu, Jingjing
Cc: dev, stable
On 8/23/2018 12:16 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Archbold, Brian
>> Sent: Wednesday, August 22, 2018 7:05 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Archbold, Brian <brian.archbold@intel.com>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix duplicate exit
>>
>> In interactive mode, when the "quit" command is issued, pmd_test_exit() is
>> being called twice, once through the "quit" command and the other after
>> termination of prompt.
>>
>> Remove duplicated exit routine by removing call from "quit" command.
>>
>> Steps to reproduce:
>> - Run testpmd in interactive mode.
>> - type "quit".
>>
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Brian Archbold <brian.archbold@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-11 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22 6:05 [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit Brian Archbold
2018-08-23 11:16 ` Iremonger, Bernard
2018-10-11 11:41 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).